PCI: Prevent out of bounds access in numa_node override

63692df103 ("PCI: Allow numa_node override via sysfs") didn't check that
the numa node provided by userspace is valid.  Passing a node number too
high would attempt to access invalid memory and trigger a kernel panic.

Fixes: 63692df103 ("PCI: Allow numa_node override via sysfs")
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Bjorn Helgaas <[email protected]>
CC: [email protected]	# v3.19+
This commit is contained in:
Sasha Levin authored and Bjorn Helgaas committed 2015-10-07 11:03:28 -05:00
1 parent de24c18c0f
commit 1266963170
1 file changed
+1 -1
+1 -1
View File
@@ -216,7 +216,7 @@ static ssize_t numa_node_store(struct device *dev,
if (ret)
return ret;
if (!node_online(node))
if (node >= MAX_NUMNODES || !node_online(node))
return -EINVAL;
add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);