BackPup/Linux
1
0 Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-07 22:37:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

tipc: Fix namespace violation in tipc_sk_fill_sock_diag

Browse Source 
To fetch UID info for socket diagnostics, we determine the
namespace of user context using tipc socket instance. This
may cause namespace violation, as the kernel will remap based
on UID.

We fix this by fetching namespace info using the calling userspace
netlink socket.

Fixes: c30b70deb5 (tipc: implement socket diagnostics for AF_TIPC)
Reported-by: [email protected]
Acked-by: Jon Maloy <[email protected]>
Signed-off-by: GhantaKrishnamurthy MohanKrishna <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
This commit is contained in:
GhantaKrishnamurthy MohanKrishna authored and David S. Miller committed 2018-04-04 11:54:35 -04:00
1 parent 9e8445a56c
commit 4b2e6877b8
1 file changed
+2 -1
Download Patch File Download Diff File Expand all files Collapse all files
net/tipc/socket.c
+2 -1
View File
@@ -3280,7 +3280,8 @@ int tipc_sk_fill_sock_diag(struct sk_buff *skb, struct tipc_sock *tsk,
nla_put_u32(skb, TIPC_NLA_SOCK_TIPC_STATE, (u32)sk->sk_state) ||
nla_put_u32(skb, TIPC_NLA_SOCK_INO, sock_i_ino(sk)) ||
nla_put_u32(skb, TIPC_NLA_SOCK_UID,
from_kuid_munged(sk_user_ns(sk), sock_i_uid(sk))) ||
from_kuid_munged(sk_user_ns(NETLINK_CB(skb).sk),
sock_i_uid(sk))) ||
nla_put_u64_64bit(skb, TIPC_NLA_SOCK_COOKIE,
tipc_diag_gen_cookie(sk),
TIPC_NLA_SOCK_PAD))