BackPup/Linux
1
0 Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-07 22:37:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

apparmor: Fix memory leak of rule on error exit path

Browse Source 
Currently on the error exit path the allocated rule is not free'd
causing a memory leak. Fix this by calling aa_audit_rule_free().

Detected by CoverityScan, CID#1468966 ("Resource leaks")

Fixes: cb740f574c7b ("apparmor: modify audit rule support to support profile stacks")
Signed-off-by: Tyler Hicks <[email protected]>
Signed-off-by: John Johansen <[email protected]>
This commit is contained in:
Tyler Hicks authored and John Johansen committed 2018-06-07 01:50:48 -07:00
1 parent 2ab47dae54
commit 52e8c38001
1 file changed
+4 -2
Download Patch File Download Diff File Expand all files Collapse all files
security/apparmor/audit.c
+4 -2
View File
@@ -200,10 +200,12 @@ int aa_audit_rule_init(u32 field, u32 op, char *rulestr, void **vrule)
/* Currently rules are treated as coming from the root ns */
rule->label = aa_label_parse(&root_ns->unconfined->label, rulestr,
GFP_KERNEL, true, false);
if (IS_ERR(rule->label))
if (IS_ERR(rule->label)) {
aa_audit_rule_free(rule);
return PTR_ERR(rule->label);
*vrule = rule;
}
*vrule = rule;
return 0;
}