BackPup/Linux
1
0 Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-07 22:37:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

crypto: stm32/cryp - Fix PM reference leak on stm32-cryp.c

Browse Source 
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Signed-off-by: Shixin Liu <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
This commit is contained in:
Shixin Liu authored and Herbert Xu committed 2021-04-16 21:16:33 +10:00
1 parent 1cb3ad7019
commit 747bf30fd9
1 file changed
+2 -2
Download Patch File Download Diff File Expand all files Collapse all files
drivers/crypto/stm32/stm32-cryp.c
+2 -2
View File
@@ -542,7 +542,7 @@ static int stm32_cryp_hw_init(struct stm32_cryp *cryp)
int ret;
u32 cfg, hw_mode;
pm_runtime_get_sync(cryp->dev);
pm_runtime_resume_and_get(cryp->dev);
/* Disable interrupt */
stm32_cryp_write(cryp, CRYP_IMSCR, 0);
@@ -2043,7 +2043,7 @@ static int stm32_cryp_remove(struct platform_device *pdev)
if (!cryp)
return -ENODEV;
ret = pm_runtime_get_sync(cryp->dev);
ret = pm_runtime_resume_and_get(cryp->dev);
if (ret < 0)
return ret;