mirror of
https://github.com/torvalds/linux.git
synced 2026-10-07 22:37:45 -04:00
ALSA: usb-audio: Fix potential zero-division at parsing FU
parse_audio_feature_unit() contains a code dividing potentially with
zero when a malformed FU descriptor is passed. Although there is
already a sanity check, it checks only the value zero, hence it can
still lead to a zero-division when a value 1 is passed there.
Fix it by correcting the sanity check (and the error message
thereof).
Fixes: 23caaf19b1 ("ALSA: usb-mixer: Add support for Audio Class v2.0")
Cc: <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
This commit is contained in:
1 parent
f658f17b5e
commit
8428a8ebde
1 file changed
+2
-2
+2
-2
@@ -1476,9 +1476,9 @@ static int parse_audio_feature_unit(struct mixer_build *state, int unitid,
|
||||
return -EINVAL;
|
||||
}
|
||||
csize = hdr->bControlSize;
|
||||
if (!csize) {
|
||||
if (csize <= 1) {
|
||||
usb_audio_dbg(state->chip,
|
||||
"unit %u: invalid bControlSize == 0\n",
|
||||
"unit %u: invalid bControlSize <= 1\n",
|
||||
unitid);
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user