BackPup/Linux
1
0 Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-07 22:37:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

blkcg: fix edge case for blk_get_rl() under memory pressure

Browse Source 
It is possible for blkg creation to fail when in blk_get_rl(). In this
situation, the fallback logic returns the nearest created blkg. There is
however special handling for the request_list for the root blkcg. This
fixes the missing edge case from the earlier series changing
blk_get_rl().

Fixes: e2b0989954 ("blkcg: cleanup and make blk_get_rl use blkg_lookup_create")
Signed-off-by: Dennis Zhou <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
This commit is contained in:
Dennis Zhou authored and Jens Axboe committed 2018-10-20 15:39:54 -06:00
1 parent bbc152825a
commit b2c3fa5467
1 file changed
+1 -1
Download Patch File Download Diff File Expand all files Collapse all files
include/linux/blk-cgroup.h
+1 -1
View File
@@ -597,7 +597,7 @@ static inline struct request_list *blk_get_rl(struct request_queue *q,
if (unlikely(!blkg))
blkg = __blkg_lookup_create(blkcg, q);
if (!blkg_tryget(blkg))
if (blkg->blkcg == &blkcg_root || !blkg_tryget(blkg))
goto rl_use_root;
rcu_read_unlock();