HID: core: fix memory leak on probe

The dynamically allocted collection stack does not get freed in
all situations. Make sure to also free the collection stack when
using the parser in hid_open_report().

Fixes: 08a8a7cf14 ("HID: core: do not upper bound the collection stack")
Signed-off-by: Stefan Agner <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
This commit is contained in:
Stefan Agner authored and Jiri Kosina committed 2018-08-28 14:07:16 +02:00
1 parent e38c0ac55e
commit b2dd9f2e5a
1 file changed
+2
+2
View File
@@ -1039,6 +1039,7 @@ int hid_open_report(struct hid_device *device)
hid_err(device, "unbalanced delimiter at end of report description\n");
goto err;
}
kfree(parser->collection_stack);
vfree(parser);
device->status |= HID_STAT_PARSED;
return 0;
@@ -1047,6 +1048,7 @@ int hid_open_report(struct hid_device *device)
hid_err(device, "item fetching failed at offset %d\n", (int)(end - start));
err:
kfree(parser->collection_stack);
vfree(parser);
hid_close_report(device);
return ret;