BackPup/Linux
1
0 Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-07 05:31:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

livepatch: RCU protect struct klp_func all the time when used in klp_ftrace_handler()

Browse Source 
func->new_func has been accessed after rcu_read_unlock() in klp_ftrace_handler()
and therefore the access was not protected.

Signed-off-by: Petr Mladek <[email protected]>
Acked-by: Josh Poimboeuf <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
This commit is contained in:
Petr Mladek authored and Jiri Kosina committed 2015-02-22 23:02:56 +01:00
1 parent e0b561ee78
commit c4ce0da8ec
1 file changed
+3 -3
Download Patch File Download Diff File Expand all files Collapse all files
kernel/livepatch/core.c
+3 -3
View File
@@ -314,12 +314,12 @@ static void notrace klp_ftrace_handler(unsigned long ip,
rcu_read_lock();
func = list_first_or_null_rcu(&ops->func_stack, struct klp_func,
stack_node);
rcu_read_unlock();
if (WARN_ON_ONCE(!func))
return;
goto unlock;
klp_arch_set_pc(regs, (unsigned long)func->new_func);
unlock:
rcu_read_unlock();
}
static int klp_disable_func(struct klp_func *func)