mirror of
https://github.com/torvalds/linux.git
synced 2026-10-07 05:31:08 -04:00
HATAYAMA Daisuke
5375b708f2
Commit f06e5153f4 ("kernel/panic.c: add "crash_kexec_post_notifiers"
option for kdump after panic_notifers") introduced
"crash_kexec_post_notifiers" kernel boot option, which toggles wheather
panic() calls crash_kexec() before panic_notifiers and dump kmsg or after.
The problem is that the commit overlooks panic_on_oops kernel boot option.
If it is enabled, crash_kexec() is called directly without going through
panic() in oops path.
To fix this issue, this patch adds a check to "crash_kexec_post_notifiers"
in the condition of kexec_should_crash().
Also, put a comment in kexec_should_crash() to explain not obvious things
on this patch.
Signed-off-by: HATAYAMA Daisuke <[email protected]>
Acked-by: Baoquan He <[email protected]>
Tested-by: Hidehiro Kawai <[email protected]>
Reviewed-by: Masami Hiramatsu <[email protected]>
Cc: Vivek Goyal <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Hidehiro Kawai <[email protected]>
Cc: Baoquan He <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>