mirror of
https://github.com/torvalds/linux.git
synced 2026-10-07 05:31:08 -04:00
Alessandro Astone
ef38de9217
Some android userspace is sending BINDER_TYPE_FDA objects with num_fds=0. Like the previous patch, this is reproducible when playing a video. Before commit09184ae9b5BINDER_TYPE_FDA objects with num_fds=0 were 'correctly handled', as in no fixup was performed. After commit09184ae9b5we aggregate fixup and skip regions in binder_ptr_fixup structs and distinguish between the two by using the skip_size field: if it's 0, then it's a fixup, otherwise skip. When processing BINDER_TYPE_FDA objects with num_fds=0 we add a skip region of skip_size=0, and this causes issues because now binder_do_deferred_txn_copies will think this was a fixup region. To address that, return early from binder_translate_fd_array to avoid adding an empty skip region. Fixes:09184ae9b5("binder: defer copies of pre-patched txn data") Acked-by: Todd Kjos <[email protected]> Cc: stable <[email protected]> Signed-off-by: Alessandro Astone <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>