Al Viro 25885a35a7
Change calling conventions for filldir_t ...
filldir_t instances (directory iterators callbacks) used to return 0 for
"OK, keep going" or -E... for "stop". Note that it's *NOT* how the
error values are reported - the rules for those are callback-dependent
and ->iterate{,_shared}() instances only care about zero vs. non-zero
(look at emit_dir() and friends).
So let's just return bool ("should we keep going?") - it's less confusing
that way. The choice between "true means keep going" and "true means
stop" is bikesheddable; we have two groups of callbacks -
do something for everything in directory, until we run into problem
and
find an entry in directory and do something to it.
The former tended to use 0/-E... conventions - -E<something> on failure.
The latter tended to use 0/1, 1 being "stop, we are done".
The callers treated anything non-zero as "stop", ignoring which
non-zero value did they get.
"true means stop" would be more natural for the second group; "true
means keep going" - for the first one. I tried both variants and
the things like
if allocation failed
something = -ENOMEM;
return true;
just looked unnatural and asking for trouble.
[folded suggestion from Matthew Wilcox <[email protected] [email protected] [email protected]
2022-08-17 17:25:04 -04:00
2022-07-28 11:44:30 +02:00
2022-08-03 14:05:39 +02:00
2022-08-04 19:30:35 -07:00
2022-07-28 11:29:36 +02:00
2022-08-10 11:01:44 -07:00
2022-08-04 18:34:05 -07:00
2022-07-18 18:29:13 +01:00
2022-07-25 09:42:24 +01:00
2022-08-04 10:28:48 -04:00
2022-08-02 15:06:57 -05:00
2022-07-28 11:29:36 +02:00
2022-08-06 10:25:16 -07:00
2022-08-12 09:50:34 -07:00
2022-07-26 16:58:31 +02:00
2022-08-01 21:31:22 +02:00
2022-07-11 16:25:16 +02:00
2022-07-06 10:57:30 +01:00
2022-08-07 09:53:58 -07:00
2022-07-28 00:01:30 +01:00
2022-08-05 16:32:45 -07:00
2022-08-04 12:12:54 -07:00
2022-08-06 10:19:51 -07:00
2022-08-10 14:04:32 -07:00
2022-07-02 11:23:14 +02:00
2022-08-04 12:12:54 -07:00
2022-07-06 12:51:11 +02:00
2022-07-05 20:25:39 +02:00
2022-08-11 13:26:09 -07:00
2022-07-15 10:41:04 +02:00
2022-07-04 16:22:29 +01:00
2022-07-28 11:29:36 +02:00
2022-08-04 08:33:54 -06:00
2022-07-29 18:12:35 -07:00
2022-07-29 18:07:15 -07:00
2022-08-02 12:34:03 -04:00
2022-08-02 17:14:47 -06:00
2022-07-14 12:14:30 -06:00
2022-08-07 17:52:35 -07:00
2022-07-14 12:14:30 -06:00
2022-07-14 12:14:30 -06:00
2022-08-04 20:00:14 -07:00
2022-07-14 12:14:30 -06:00
2022-07-11 21:18:55 -07:00
2022-07-22 22:04:37 +02:00
2022-08-04 16:57:43 -07:00
2022-07-04 10:33:06 +01:00
2022-07-22 09:07:07 -07:00
2022-07-21 21:03:09 -07:00
2022-08-09 15:03:02 -07:00
2022-07-04 16:22:28 +01:00
2022-08-03 09:45:08 -07:00
2022-08-02 12:19:18 -07:00
2022-07-03 11:32:22 -07:00
2022-07-17 17:31:38 -07:00
2022-07-05 13:32:59 -07:00
2022-07-05 13:33:00 -07:00
2022-07-05 13:33:00 -07:00
2022-07-06 16:32:08 +01:00
2022-08-01 12:48:15 -07:00
2022-08-07 17:52:35 -07:00
2022-07-03 18:08:43 -07:00
2022-07-17 17:14:32 -07:00
2022-08-11 12:41:07 -07:00
2022-07-28 17:36:30 -04:00
2022-07-28 17:46:14 -04:00
2022-07-14 12:14:31 -06:00
2022-07-08 10:47:07 -07:00
2022-07-14 14:41:30 +02:00
2022-08-08 15:16:29 -07:00
2022-07-26 07:27:48 -04:00
2022-07-15 10:21:43 +02:00
2022-08-03 14:41:36 -07:00
2022-07-15 19:17:30 +02:00
2022-07-05 13:32:59 -07:00
2022-07-15 11:37:41 +09:00
2022-07-01 14:53:01 +02:00
2022-07-07 10:50:46 +02:00
2022-07-12 17:33:22 -07:00
2022-08-17 17:25:04 -04:00
2022-08-02 19:24:24 -07:00
2022-08-03 00:54:11 +02:00
2022-07-01 14:51:13 +02:00
2022-07-22 22:04:30 +02:00
2022-08-07 17:52:35 -07:00
2022-07-15 06:35:54 -07:00
2022-07-19 09:56:34 +02:00
2022-07-05 13:33:00 -07:00
2022-07-25 17:45:40 +02:00
2022-08-08 18:06:46 -07:00
2022-07-28 11:29:36 +02:00
2022-07-08 16:27:52 +02:00
2022-08-05 16:32:45 -07:00
2022-08-08 18:06:44 -07:00
2022-07-22 16:06:03 -05:00
2022-07-26 23:13:36 +02:00
2022-07-22 14:28:22 +02:00
2022-07-28 11:29:36 +02:00
2022-07-28 11:29:36 +02:00
2022-07-28 11:29:36 +02:00
2022-07-28 11:29:36 +02:00
2022-07-01 15:22:16 +02:00
2022-07-15 18:55:49 -07:00
2022-07-04 16:14:29 +03:00
2022-08-12 17:01:00 -06:00
2022-07-07 09:42:59 +02:00
2022-08-11 13:11:49 -07:00
2022-07-15 10:13:45 +02:00
2022-07-21 17:19:25 -07:00
2022-07-19 06:05:45 +02:00
2022-07-20 15:26:05 +01:00
2022-07-11 10:12:49 +01:00
2022-07-22 17:24:47 -05:00
2022-08-04 20:13:46 -07:00
2022-07-04 09:23:07 +02:00
2022-07-06 14:20:22 +02:00
2022-07-15 12:21:16 -04:00
2022-07-17 17:31:38 -07:00
2022-07-17 17:14:33 -07:00
2022-08-01 03:21:00 -04:00
2022-08-01 03:21:00 -04:00
2022-07-22 12:53:22 +01:00
2022-07-26 12:23:01 -07:00
2022-07-03 14:40:28 -07:00
2022-07-15 18:21:49 +00:00
2022-07-15 18:21:49 +00:00
2022-08-02 23:56:25 -04:00
2022-07-07 14:06:12 -06:00
2022-07-03 18:08:40 -07:00
2022-07-03 18:08:49 -07:00
2022-07-17 17:14:30 -07:00
2022-08-05 16:32:45 -07:00
2022-07-27 14:04:52 +02:00
2022-07-17 17:14:34 -07:00
2022-08-08 18:06:44 -07:00
2022-08-03 00:54:12 +02:00
2022-07-29 18:07:19 -07:00
2022-07-15 22:08:01 +02:00
2022-07-11 17:13:15 -06:00
2022-08-02 12:34:04 -04:00
2022-08-07 10:03:24 -07:00
2022-08-03 10:35:43 -07:00
2022-08-08 16:25:56 -04:00
2022-08-09 14:11:34 -04:00
2022-07-29 20:16:58 -04:00
2022-07-23 15:28:59 -04:00
2022-07-28 11:29:36 +02:00
2022-07-27 21:35:32 +10:00
2022-08-01 08:13:21 -07:00
2022-08-02 17:14:49 -06:00
2022-08-02 17:14:47 -06:00
2022-08-02 19:24:24 -07:00
2022-07-19 10:24:01 +02:00
2022-07-08 14:53:50 +02:00
2022-08-04 18:08:34 -07:00
2022-07-21 10:39:42 +02:00
2022-07-17 17:31:37 -07:00
2022-08-08 18:06:43 -07:00
2022-08-05 16:32:45 -07:00
2022-08-05 16:32:45 -07:00
2022-07-01 16:38:35 -06:00
2022-08-10 11:07:26 -07:00
2022-07-19 15:38:04 -07:00
2022-07-14 15:25:36 -05:00
2022-07-26 07:28:08 -04:00
2022-07-29 12:08:44 -05:00
2022-07-17 17:14:37 -07:00
2022-07-28 11:29:36 +02:00
2022-08-08 22:37:19 -04:00
2022-07-12 20:35:21 +05:30
2022-07-01 21:04:02 +02:00
2022-07-05 20:48:46 +02:00
2022-07-15 22:08:59 +02:00
2022-07-15 22:09:57 +02:00
2022-07-28 11:29:36 +02:00
2022-07-26 09:49:12 -07:00
2022-07-28 11:29:36 +02:00
2022-07-28 11:29:36 +02:00
2022-07-28 11:29:36 +02:00
2022-08-14 13:31:03 -07:00
2022-07-25 13:26:14 +02:00
2022-07-21 17:46:18 -07:00
2022-07-21 17:46:18 -07:00
2022-07-21 17:46:18 -07:00
2022-07-03 11:32:22 -07:00
2022-08-11 04:06:37 -04:00
2022-07-03 18:08:36 -07:00
2022-07-30 14:01:28 -04:00
2022-07-26 07:27:47 -04:00
2022-08-06 17:34:06 -07:00
2022-08-02 11:17:00 -07:00
2022-08-02 15:12:13 -07:00
2022-07-28 11:29:36 +02:00
2022-08-08 11:31:40 -07:00
2022-07-29 18:07:15 -07:00
2022-07-03 18:08:40 -07:00
2022-07-22 16:55:44 -07:00
2022-08-10 21:47:58 -07:00
2022-08-03 16:29:08 -07:00
2022-07-06 12:56:35 +01:00
2022-07-18 11:14:35 +01:00
2022-07-28 11:29:36 +02:00
2022-08-05 16:32:45 -07:00
2022-08-08 18:06:44 -07:00
2022-07-18 06:50:18 +02:00
2022-08-08 18:06:43 -07:00
2022-07-19 15:38:04 -07:00
2022-07-15 10:21:30 +02:00
2022-07-02 16:22:25 +01:00
2022-07-28 17:29:56 +02:00
2022-08-09 20:02:13 +02:00
2022-08-03 23:56:20 +03:00
2022-07-15 17:42:34 -04:00
2022-08-05 09:41:12 -07:00
2022-07-19 09:56:51 +02:00
2022-08-08 22:37:24 -04:00
2022-08-11 04:31:14 -04:00
2022-08-06 08:59:35 -07:00
2022-07-25 13:41:22 -06:00
2022-08-01 07:42:49 +02:00
2022-08-11 04:06:41 -04:00
2022-08-11 04:06:40 -04:00
2022-08-11 04:06:38 -04:00
2022-08-11 04:06:40 -04:00
2022-07-28 12:35:12 +02:00
2022-07-07 13:09:59 -06:00
2022-07-12 11:07:32 +10:00
2022-08-02 13:46:35 -07:00
2022-07-10 21:17:30 -04:00
2022-07-15 22:08:59 +02:00
Al Viro
25885a35a7