Nicholas Bellinger 410c29dfbf target: Fix ordered task CHECK_CONDITION early exception handling ...

If a Simple command is sent with a failure, target_setup_cmd_from_cdb
returns with TCM_UNSUPPORTED_SCSI_OPCODE or TCM_INVALID_CDB_FIELD.

So in the cases where target_setup_cmd_from_cdb returns an error, we
never get far enough to call target_execute_cmd to increment simple_cmds.
Since simple_cmds isn't incremented, the result of the failure from
target_setup_cmd_from_cdb causes transport_generic_request_failure to
decrement simple_cmds, due to call to transport_complete_task_attr.

With this dev->simple_cmds or dev->dev_ordered_sync is now -1, not 0.
So when a subsequent command with an Ordered Task is sent, it causes
a hang, since dev->simple_cmds is at -1.

Tested-by: Bryant G. Ly <[email protected]>
Signed-off-by: Bryant G. Ly <[email protected]>
Tested-by: Michael Cyr <[email protected]>
Signed-off-by: Michael Cyr <[email protected]>
Cc: [email protected] # 4.4+
Signed-off-by: Nicholas Bellinger <[email protected]>

2016-07-20 00:58:40 -07:00

..

iscsi

cxgbit: Use type ISCSI_CXGBIT + cxgbit tpg_np attribute

2016-05-16 22:23:59 -07:00

target_core_backend.h

target: Fix max_unmap_lba_count calc overflow

2016-07-20 00:58:36 -07:00

target_core_base.h

target: Fix ordered task CHECK_CONDITION early exception handling

2016-07-20 00:58:40 -07:00

target_core_fabric.h

target: Fix ordered task target_setup_cmd_from_cdb exception hang

2016-07-20 00:58:38 -07:00