deps: Intl: ICU 58 bump: configure/LICENSE/docs

* bump to ICU 58.1 - update URL / hash
* does not attempt to reduce size - yet
* patch to work around http://bugs.icu-project.org/trac/ticket/12822
  ( compile issue on Windows)
* Fix ICU shrinker to delete old license.html file
  (update to https://github.com/nodejs/node/pull/8674 )

Fixes: https://github.com/nodejs/node/issues/7844
PR-URL: https://github.com/nodejs/node/pull/9234
Reviewed-By: James M Snell <jasnell@gmail.com>

tools/icu/README.md

@@ -8,11 +8,12 @@
 ```shell
 ./configure \
     --with-intl=small-icu \
-    --with-icu-source=http://download.icu-project.org/files/icu4c/56.1/icu4c-56_1-src.zip
+    --with-icu-source=http://download.icu-project.org/files/icu4c/58.1/icu4c-58_1-src.tgz
 make
 ```
 
-(the equivalent `vcbuild.bat` commands should work also.)
+(The equivalent `vcbuild.bat` commands should work also. Note that we use the `.tgz` and not the `.zip` here,
+that is because of line endings.)
 
 - (note- may need to make changes in `icu-generic.gyp` or `tools/icu/patches` for
 version specific stuff)
@@ -58,6 +59,14 @@ new Intl.DateTimeFormat('es',{month:'long'}).format(new Date(9E8));
 - You are ready to check in the updated `deps/small-icu`.
 This is a big commit, so make this a separate commit from other changes.
 
+- Now, rebuild the Node license.
+
+```shell
+# clean up - remove deps/icu
+make clean
+tools/license-builder.sh
+```
+
 - Now, fix the default URL for the `full-icu` build in `/configure`, in
 the `configure_intl()` function. It should match the ICU URL used in the
 first step.  When this is done, the following should build with full ICU.
@@ -70,7 +79,7 @@ make
 make test-ci
 ```
 
-- commit the change to `configure`.
+- commit the change to `configure` along with the updated `LICENSE` file.
 
 -----
 

tools/icu/shrink-icu-src.py

@@ -48,18 +48,17 @@ def icu_ignore(dir, files):
         ign = ign + files
         # except...
         ign.remove('source')
-        ign.remove('license.html')
-        ign.remove('LICENSE')
+        if 'LICENSE' in ign:
+            ign.remove('LICENSE')
+            # license.html will be removed (it's obviated by LICENSE)
+        elif 'license.html' in ign:
+            ign.remove('license.html')
     elif subdir == 'source':
-        ign = ign + ['layout','samples','test','extra','config','layoutex','allinone']
+        ign = ign + ['layout','samples','test','extra','config','layoutex','allinone','data']
         ign = ign + ['runConfigureICU','install-sh','mkinstalldirs','configure']
     elif subdir == 'source/tools':
         ign = ign + ['tzcode','ctestfw','gensprep','gennorm2','gendict','icuswap',
         'genbrk','gencfu','gencolusb','genren','memcheck','makeconv','gencnval','icuinfo','gentest']
-    elif subdir == 'source/data':
-        ign = ign + ['unidata','curr','zone','unit','lang','region','misc','sprep']
-    # else:
-        # print '!%s! [%s]' % (subdir, files)
     ign = ign + ['.DS_Store', 'Makefile', 'Makefile.in']
 
     for file in files:
@@ -103,6 +102,10 @@ print '%s --> %s' % (options.icusrc, options.icusmall)
 shutil.copytree(options.icusrc, options.icusmall, ignore=icu_ignore)
 print '%s --> %s' % (src_datafile, dst_datafile)
 
+# now, make the data dir (since we ignored it)
+os.mkdir(os.path.join(os.path.join(options.icusmall, "source", "data")))
+os.mkdir(os.path.join(os.path.join(options.icusmall, "source", "data", "in")))
+
 # OK, now copy the data file
 shutil.copy(src_datafile, dst_datafile)