BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-14 10:26:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

assert: fix the string length check for printing the simple diff

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/55474
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Giovanni Bucci authored and GitHub committed 2024-11-02 15:12:12 +00:00
1 parent 81859cf01f
commit 10cce655ca
3 files changed
+31 -16
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

lib/internal/assert/assertion_error.js
+8 -1
View File
@@ -134,7 +134,14 @@ function getStackedDiff(actual, expected) {
}
function getSimpleDiff(originalActual, actual, originalExpected, expected) {
const stringsLen = actual.length + expected.length;
let stringsLen = actual.length + expected.length;
// Accounting for the quotes wrapping strings
if (typeof originalActual === 'string') {
stringsLen -= 2;
}
if (typeof originalExpected === 'string') {
stringsLen -= 2;
}
if (stringsLen <= kMaxShortStringLength && (originalActual !== 0 || originalExpected !== 0)) {
return { message: `${actual} !== ${expected}`, header: '' };
}