mirror of
https://github.com/nodejs/node.git
synced 2026-10-14 10:26:26 -04:00
src: skip inspector wait in internal workers
Internal workers are essential to load user scripts and bootstrapped with internal entrypoints. They should not be waiting for inspectors even when `--inspect-brk` and `--inspect-wait` were specified, and avoid blocking main thread to bootstrap. IsolateData can be created with a specified PerIsolateOptions instead of creating a copy from the per_process namespace. This also avoids creating a copy bypassing the parent env's modified options, like creating a worker thread from a worker thread. PR-URL: https://github.com/nodejs/node/pull/54219 Fixes: https://github.com/nodejs/node/issues/53681 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit is contained in:
1 parent
e9deab9915
commit
2bcf9995d2
10 files changed
+148
-28
No files matched your search
@@ -309,6 +309,10 @@ class InspectorSession {
|
||||
return notification.method === 'Runtime.executionContextDestroyed' &&
|
||||
notification.params.executionContextId === 1;
|
||||
});
|
||||
await this.waitForDisconnect();
|
||||
}
|
||||
|
||||
async waitForDisconnect() {
|
||||
while ((await this._instance.nextStderrString()) !==
|
||||
'Waiting for the debugger to disconnect...');
|
||||
await this.disconnect();
|
||||
|
||||
Reference in new issue
Block a user