mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
test: wrap assert.fail when passed to callback
Currently there are many instances where assert.fail is directly passed to a callback for error handling. Unfortunately this will swallow the error as it is the third argument of assert.fail that sets the message not the first. This commit adds a new function to test/common.js that simply wraps assert.fail and calls it with the provided message. Tip of the hat to @trott for pointing me in the direction of this. PR-URL: https://github.com/nodejs/node/pull/3453 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
1 parent
7added3b39
commit
60de9f8d7b
37 files changed
+81
-77
No files matched your search
@@ -24,7 +24,7 @@ var options = {
|
||||
handshakeTimeout: 50
|
||||
};
|
||||
|
||||
var server = https.createServer(options, assert.fail);
|
||||
var server = https.createServer(options, common.fail);
|
||||
|
||||
server.on('clientError', function(err, conn) {
|
||||
// Don't hesitate to update the asserts if the internal structure of
|
||||
|
||||
Reference in new issue
Block a user