BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

dns: accept 'IPv4' and 'IPv6' for family

Browse Source 
Refs: https://github.com/nodejs/node/issues/43014

PR-URL: https://github.com/nodejs/node/pull/43054
Fixes: https://github.com/nodejs/node/issues/43014
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Antoine du Hamel authored and Michael Dawson committed 2022-06-15 18:02:01 -04:00
1 parent 74716ada2e
commit 70b516e4db
27 files changed
+88 -54
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

test/sequential/test-net-server-address.js
+2 -2
View File
@@ -26,7 +26,7 @@ const net = require('net');
// Test on IPv4 Server
{
const family = 4;
const family = 'IPv4';
const server = net.createServer();
server.on('error', common.mustNotCall());
@@ -46,7 +46,7 @@ if (!common.hasIPv6) {
return;
}
const family6 = 6;
const family6 = 'IPv6';
const anycast6 = '::';
// Test on IPv6 Server
test/sequential/test-net-server-bind.js
+1 -1
View File
@@ -24,7 +24,7 @@ const net = require('net');
const address = server.address();
assert.strictEqual(address.port, common.PORT);
if (address.family === 6)
if (address.family === 'IPv6')
assert.strictEqual(server._connectionKey, `6::::${address.port}`);
else
assert.strictEqual(server._connectionKey, `4:0.0.0.0:${address.port}`);