mirror of
https://github.com/nodejs/node.git
synced 2026-10-14 10:26:26 -04:00
test: run abort tests
Currently, tests in test/abort do not run in CI. This change configures the test runner to not write core files for abort tests and to run them. PR-URL: https://github.com/nodejs/node/pull/14013 Fixes: https://github.com/nodejs/node/issues/14012 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
1 parent
df57d8bdcc
commit
70c775a810
4 files changed
+29
-5
No files matched your search
+15
-3
@@ -492,6 +492,7 @@ class TestCase(object):
|
||||
self.arch = arch
|
||||
self.mode = mode
|
||||
self.parallel = False
|
||||
self.disable_core_files = False
|
||||
self.thread_id = 0
|
||||
|
||||
def IsNegative(self):
|
||||
@@ -516,7 +517,8 @@ class TestCase(object):
|
||||
output = Execute(full_command,
|
||||
self.context,
|
||||
self.context.GetTimeout(self.mode),
|
||||
env)
|
||||
env,
|
||||
disable_core_files = self.disable_core_files)
|
||||
self.Cleanup()
|
||||
return TestOutput(self,
|
||||
full_command,
|
||||
@@ -718,7 +720,7 @@ def CheckedUnlink(name):
|
||||
PrintError("os.unlink() " + str(e))
|
||||
break
|
||||
|
||||
def Execute(args, context, timeout=None, env={}, faketty=False):
|
||||
def Execute(args, context, timeout=None, env={}, faketty=False, disable_core_files=False):
|
||||
if faketty:
|
||||
import pty
|
||||
(out_master, fd_out) = pty.openpty()
|
||||
@@ -740,6 +742,14 @@ def Execute(args, context, timeout=None, env={}, faketty=False):
|
||||
for key, value in env.iteritems():
|
||||
env_copy[key] = value
|
||||
|
||||
preexec_fn = None
|
||||
|
||||
if disable_core_files and not utils.IsWindows():
|
||||
def disableCoreFiles():
|
||||
import resource
|
||||
resource.setrlimit(resource.RLIMIT_CORE, (0,0))
|
||||
preexec_fn = disableCoreFiles
|
||||
|
||||
(process, exit_code, timed_out, output) = RunProcess(
|
||||
context,
|
||||
timeout,
|
||||
@@ -749,7 +759,8 @@ def Execute(args, context, timeout=None, env={}, faketty=False):
|
||||
stderr = fd_err,
|
||||
env = env_copy,
|
||||
faketty = faketty,
|
||||
pty_out = pty_out
|
||||
pty_out = pty_out,
|
||||
preexec_fn = preexec_fn
|
||||
)
|
||||
if faketty:
|
||||
os.close(out_master)
|
||||
@@ -1237,6 +1248,7 @@ class ClassifiedTest(object):
|
||||
self.case = case
|
||||
self.outcomes = outcomes
|
||||
self.parallel = self.case.parallel
|
||||
self.disable_core_files = self.case.disable_core_files
|
||||
|
||||
|
||||
class Configuration(object):
|
||||
|
||||
Reference in new issue
Block a user