From 91fa83fffdbad7ab192e6c6c75fe13e91ef703e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sat, 9 Aug 2025 14:15:01 +0200 Subject: [PATCH] tools: disable nullability-completeness warnings Seems Clang-specific and doesn't only affect macOS. This is a very noisy warning from abseil-cpp. PR-URL: https://github.com/nodejs/node/pull/59392 Reviewed-By: Richard Lau Reviewed-By: Rafael Gonzaga Reviewed-By: Filip Skokan Reviewed-By: Luigi Pinca --- tools/v8_gypfiles/toolchain.gypi | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/tools/v8_gypfiles/toolchain.gypi b/tools/v8_gypfiles/toolchain.gypi index 392fc5903b5..ac6a34553d1 100644 --- a/tools/v8_gypfiles/toolchain.gypi +++ b/tools/v8_gypfiles/toolchain.gypi @@ -165,6 +165,23 @@ }, }, }], + ['clang==1', { + 'cflags_cc': [ + '-Wno-nullability-completeness', + ], + 'xcode_settings': { + 'OTHER_CFLAGS': [ + '-Wno-nullability-completeness', + ], + }, + 'msvs_settings': { + 'VCCLCompilerTool': { + 'AdditionalOptions': [ + '-Wno-nullability-completeness', + ], + }, + }, + }], ['v8_target_arch=="arm"', { 'defines': [ 'V8_TARGET_ARCH_ARM',