mirror of
https://github.com/nodejs/node.git
synced 2026-10-14 10:26:26 -04:00
inspector: update inspector_protocol to 8ec18cf
Apply 8ec18cf: "Support STRING16 in the template when converting CBOR map keys" Refs: https://chromium.googlesource.com/deps/inspector_protocol/+/8ec18cf0885bef0b5c2a922c5dc3813cbf63e962 We're over 2 years out of date in the tools/inspector_protocol directory and I have to imagine this will come back to bite us at some point. But I also don't want to do a huge update all at once, so starting with a single commit. I might bundle commits together a bit more if this goes well. PR-URL: https://github.com/nodejs/node/pull/39614 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This commit is contained in:
1 parent
cf8a235fd1
commit
9e904470f4
1 file changed
+6
-1
@@ -178,7 +178,12 @@ std::unique_ptr<DictionaryValue> parseMap(
|
||||
key = StringUtil::fromUTF8(key_span.data(), key_span.size());
|
||||
tokenizer->Next();
|
||||
} else if (tokenizer->TokenTag() == cbor::CBORTokenTag::STRING16) {
|
||||
return nullptr; // STRING16 not supported yet.
|
||||
span<uint8_t> key_span = tokenizer->GetString16WireRep();
|
||||
if (key_span.size() & 1) return nullptr; // UTF16 is 2 byte multiple.
|
||||
key = StringUtil::fromUTF16(
|
||||
reinterpret_cast<const uint16_t*>(key_span.data()),
|
||||
key_span.size() / 2);
|
||||
tokenizer->Next();
|
||||
} else {
|
||||
// Error::CBOR_INVALID_MAP_KEY
|
||||
return nullptr;
|
||||
|
||||
Reference in new issue
Block a user