From ab0d3a38db4e693eab8a107bbd482505657350ed Mon Sep 17 00:00:00 2001
From: Dario Piotrowicz <dario@cloudflare.com>
Date: Fri, 21 Mar 2025 22:08:48 +0000
Subject: [PATCH] src: improve error message for invalid child stdio type in
 spawn_sync

PR-URL: https://github.com/nodejs/node/pull/57589
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
---
 src/spawn_sync.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/spawn_sync.cc b/src/spawn_sync.cc
index 004e0ca3995..9be58f42fd4 100644
--- a/src/spawn_sync.cc
+++ b/src/spawn_sync.cc
@@ -1055,7 +1055,10 @@ Maybe<int> SyncProcessRunner::ParseStdioOption(int child_fd,
     return Just(AddStdioInheritFD(child_fd, inherit_fd));
   }
 
-  UNREACHABLE("invalid child stdio type");
+  Utf8Value stdio_type(env()->isolate(), js_type);
+  fprintf(stderr, "invalid child stdio type: %s\n", stdio_type.out());
+
+  UNREACHABLE();
 }
 
 int SyncProcessRunner::AddStdioIgnore(uint32_t child_fd) {