mirror of
https://github.com/nodejs/node.git
synced 2026-11-15 10:36:53 -05:00
test: simplify test skipping
* Make common.skip() exit. Also add common.printSkipMessage() for partial skips. * Don't make needless things before skip PR-URL: https://github.com/nodejs/node/pull/14021 Fixes: https://github.com/nodejs/node/issues/14016 Reviewed-By: Refael Ackermann <refack@gmail.com>
This commit is contained in:
1 parent
898fe6135b
commit
bc99efc973
333 files changed
+901
-1638
No files matched your search
+5
-10
@@ -1,15 +1,13 @@
|
||||
'use strict';
|
||||
|
||||
const common = require('../../common');
|
||||
const skipMessage = 'intensive toString tests due to memory confinements';
|
||||
if (!common.enoughTestMem)
|
||||
common.skip(skipMessage);
|
||||
|
||||
const binding = require(`./build/${common.buildType}/binding`);
|
||||
const assert = require('assert');
|
||||
|
||||
const skipMessage = 'intensive toString tests due to memory confinements';
|
||||
if (!common.enoughTestMem) {
|
||||
common.skip(skipMessage);
|
||||
return;
|
||||
}
|
||||
|
||||
// v8 fails silently if string length > v8::String::kMaxLength
|
||||
// v8::String::kMaxLength defined in v8.h
|
||||
const kStringMaxLength = process.binding('buffer').kStringMaxLength;
|
||||
@@ -21,14 +19,11 @@ try {
|
||||
// If the exception is not due to memory confinement then rethrow it.
|
||||
if (e.message !== 'Array buffer allocation failed') throw (e);
|
||||
common.skip(skipMessage);
|
||||
return;
|
||||
}
|
||||
|
||||
// Ensure we have enough memory available for future allocations to succeed.
|
||||
if (!binding.ensureAllocation(2 * kStringMaxLength)) {
|
||||
if (!binding.ensureAllocation(2 * kStringMaxLength))
|
||||
common.skip(skipMessage);
|
||||
return;
|
||||
}
|
||||
|
||||
assert.throws(function() {
|
||||
buf.toString('utf16le');
|
||||
|
||||
Reference in new issue
Block a user