mirror of
https://github.com/nodejs/node.git
synced 2026-10-14 10:26:26 -04:00
lib: refactor Error.captureStackTrace() usage
When using `Errors.captureStackFrames` the error's stack property is set again. This adds a helper function that wraps this functionality in a simple API that does not only set the stack including the `code` property but it also improves the performance to create the error. The helper works for thrown errors and errors returned from wrapped functions in case they are Node.js core errors. PR-URL: https://github.com/nodejs/node/pull/26738 Fixes: https://github.com/nodejs/node/issues/26669 Fixes: https://github.com/nodejs/node/issues/20253 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This commit is contained in:
15 files changed
+316
-339
No files matched your search
+17
-20
@@ -62,15 +62,18 @@ const {
|
||||
} = require('internal/util/inspect');
|
||||
|
||||
const {
|
||||
ERR_BUFFER_OUT_OF_BOUNDS,
|
||||
ERR_OUT_OF_RANGE,
|
||||
ERR_INVALID_ARG_TYPE,
|
||||
ERR_INVALID_ARG_VALUE,
|
||||
ERR_INVALID_BUFFER_SIZE,
|
||||
ERR_INVALID_OPT_VALUE,
|
||||
ERR_NO_LONGER_SUPPORTED,
|
||||
ERR_UNKNOWN_ENCODING
|
||||
} = require('internal/errors').codes;
|
||||
codes: {
|
||||
ERR_BUFFER_OUT_OF_BOUNDS,
|
||||
ERR_OUT_OF_RANGE,
|
||||
ERR_INVALID_ARG_TYPE,
|
||||
ERR_INVALID_ARG_VALUE,
|
||||
ERR_INVALID_BUFFER_SIZE,
|
||||
ERR_INVALID_OPT_VALUE,
|
||||
ERR_NO_LONGER_SUPPORTED,
|
||||
ERR_UNKNOWN_ENCODING
|
||||
},
|
||||
hideStackFrames
|
||||
} = require('internal/errors');
|
||||
const { validateString } = require('internal/validators');
|
||||
|
||||
const {
|
||||
@@ -247,20 +250,14 @@ Object.setPrototypeOf(Buffer, Uint8Array);
|
||||
// The 'assertSize' method will remove itself from the callstack when an error
|
||||
// occurs. This is done simply to keep the internal details of the
|
||||
// implementation from bleeding out to users.
|
||||
function assertSize(size) {
|
||||
let err = null;
|
||||
|
||||
const assertSize = hideStackFrames((size) => {
|
||||
if (typeof size !== 'number') {
|
||||
err = new ERR_INVALID_ARG_TYPE('size', 'number', size);
|
||||
} else if (!(size >= 0 && size <= kMaxLength)) {
|
||||
err = new ERR_INVALID_OPT_VALUE.RangeError('size', size);
|
||||
throw new ERR_INVALID_ARG_TYPE('size', 'number', size);
|
||||
}
|
||||
|
||||
if (err !== null) {
|
||||
Error.captureStackTrace(err, assertSize);
|
||||
throw err;
|
||||
if (!(size >= 0 && size <= kMaxLength)) {
|
||||
throw new ERR_INVALID_OPT_VALUE.RangeError('size', size);
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
/**
|
||||
* Creates a new filled Buffer instance.
|
||||
|
||||
Reference in new issue
Block a user