lib: always show ERR_INVALID_ARG_TYPE received part

This makes a effort to make sure all of these errors will actually
also show the received input.
On top of that it refactors a few tests for better maintainability.
It will also change the returned type to always be a simple typeof
instead of special handling null.

PR-URL: https://github.com/nodejs/node/pull/19445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Ruben Bridgewater committed 2018-03-25 01:45:37 +01:00
1 parent eeb57022e6
commit c6b6c92185
107 files changed
+746 -859

No files matched your search

+4 -3
View File
@@ -70,12 +70,13 @@ const {
}
{
[1, {}, [], null, undefined, Infinity].forEach((i) => {
common.expectsError(() => performance.timerify(i),
[1, {}, [], null, undefined, Infinity].forEach((input) => {
common.expectsError(() => performance.timerify(input),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "fn" argument must be of type Function'
message: 'The "fn" argument must be of type ' +
`Function. Received type ${typeof input}`
});
});
}