mirror of
https://github.com/nodejs/node.git
synced 2026-11-18 18:15:17 -05:00
sqlite: prevent reentrant session.close()
Reject session.close() while generating a changeset or patchset. Closing the session at that point frees it while SQLite is still using it, causing a use-after-free. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: https://github.com/nodejs/node/pull/65349 Fixes: https://github.com/nodejs/node/issues/65347 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This commit is contained in:
1 parent
882a781cfb
commit
d6bbf5799f
4 files changed
+31
-1
No files matched your search
@@ -4299,6 +4299,10 @@ void Session::Changeset(const FunctionCallbackInfo<Value>& args) {
|
||||
env, session->session_ == nullptr, "session is not open");
|
||||
THROW_AND_RETURN_IF_IN_AUTHORIZER(env, session->database_.get());
|
||||
|
||||
session->is_generating_changeset_ = true;
|
||||
auto changeset_guard =
|
||||
OnScopeLeave([&] { session->is_generating_changeset_ = false; });
|
||||
|
||||
int nChangeset;
|
||||
void* pChangeset;
|
||||
int r = sqliteChangesetFunc(session->session_, &nChangeset, &pChangeset);
|
||||
@@ -4324,6 +4328,8 @@ void Session::Close(const FunctionCallbackInfo<Value>& args) {
|
||||
env, !session->database_->IsOpen(), "database is not open");
|
||||
THROW_AND_RETURN_ON_BAD_STATE(
|
||||
env, session->session_ == nullptr, "session is not open");
|
||||
THROW_AND_RETURN_ON_BAD_STATE(
|
||||
env, session->is_generating_changeset_, "session is currently in use");
|
||||
|
||||
session->Delete();
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user