tools: remove legacy indentation linting

All linting now uses the current ESLint 4.3.0 indentation linting.
Remove legacy indentation rules.

PR-URL: https://github.com/nodejs/node/pull/14515
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

.eslintrc.yaml

@@ -101,18 +101,13 @@ rules:
   func-call-spacing: error
   func-name-matching: error
   func-style: [error, declaration, {allowArrowFunctions: true}]
-  # indent: [error, 2, {ArrayExpression: first,
+  indent: [error, 2, {ArrayExpression: first,
-  #                     CallExpression: {arguments: first},
+                      CallExpression: {arguments: first},
-  #                     FunctionDeclaration: {parameters: first},
+                      FunctionDeclaration: {parameters: first},
-  #                     FunctionExpression: {parameters: first},
+                      FunctionExpression: {parameters: first},
-  #                     MemberExpression: off,
+                      MemberExpression: off,
-  #                     ObjectExpression: first,
+                      ObjectExpression: first,
-  #                     SwitchCase: 1}]
+                      SwitchCase: 1}]
-  indent-legacy: [error, 2, {ArrayExpression: first,
-                             CallExpression: {arguments: first},
-                             MemberExpression: 1,
-                             ObjectExpression: first,
-                             SwitchCase: 1}]
   key-spacing: [error, {mode: minimum}]
   keyword-spacing: error
   linebreak-style: [error, unix]

benchmark/.eslintrc.yaml

@@ -1,13 +0,0 @@
-## Benchmarks-specific linter rules
-
-rules:
-  # Stylistic Issues
-  # http://eslint.org/docs/rules/#stylistic-issues
-  indent: [error, 2, {ArrayExpression: first,
-                      CallExpression: {arguments: first},
-                      FunctionDeclaration: {parameters: first},
-                      FunctionExpression: {parameters: first},
-                      MemberExpression: off,
-                      ObjectExpression: first,
-                      SwitchCase: 1}]
-  indent-legacy: off

doc/.eslintrc.yaml

@@ -11,13 +11,3 @@ rules:
   no-var: error
   prefer-const: error
   prefer-rest-params: error
-
-  # use stricter indent over indent-legacy
-  indent-legacy: off
-  indent: [error, 2, {ArrayExpression: first,
-                      CallExpression: {arguments: first},
-                      FunctionDeclaration: {parameters: first},
-                      FunctionExpression: {parameters: first},
-                      MemberExpression: off,
-                      ObjectExpression: first,
-                      SwitchCase: 1}]

lib/.eslintrc.yaml

@@ -1,13 +1,4 @@
 rules:
-  indent: [error, 2, {ArrayExpression: first,
-                      CallExpression: {arguments: first},
-                      FunctionDeclaration: {parameters: first},
-                      FunctionExpression: {parameters: first},
-                      MemberExpression: off,
-                      ObjectExpression: first,
-                      SwitchCase: 1}]
-  indent-legacy: off
-
   # Custom rules in tools/eslint-rules
   require-buffer: error
   buffer-constructor: error

test/.eslintrc.yaml

@@ -1,16 +1,6 @@
 ## Test-specific linter rules
 
 rules:
-  # Stylistic Issues
-  # http://eslint.org/docs/rules/#stylistic-issues
-  indent: [error, 2, {ArrayExpression: first,
-                      CallExpression: {arguments: first},
-                      FunctionDeclaration: {parameters: first},
-                      FunctionExpression: {parameters: first},
-                      MemberExpression: off,
-                      ObjectExpression: first,
-                      SwitchCase: 1}]
-  indent-legacy: off
   # ECMAScript 6
   # http://eslint.org/docs/rules/#ecmascript-6
   no-var: error

tools/.eslintrc.yaml

@@ -1,13 +0,0 @@
-## Tools-specific linter rules
-
-rules:
-  # Stylistic Issues
-  # http://eslint.org/docs/rules/#stylistic-issues
-  indent: [error, 2, {ArrayExpression: first,
-                      CallExpression: {arguments: first},
-                      FunctionDeclaration: {parameters: first},
-                      FunctionExpression: {parameters: first},
-                      MemberExpression: off,
-                      ObjectExpression: first,
-                      SwitchCase: 1}]
-  indent-legacy: off