From ea3d14eadbc90b2b0c48192efa8f51116948c999 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Wed, 19 Mar 2025 13:11:52 +0100 Subject: [PATCH] deps: remove problematic comment from v8-internal GCC emits warnings because of the trailing backslashes. PR-URL: https://github.com/nodejs/node/pull/58070 Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen Reviewed-By: Joyee Cheung Reviewed-By: Rafael Gonzaga Reviewed-By: Richard Lau Reviewed-By: Marco Ippolito Reviewed-By: Paolo Insogna Reviewed-By: Yagiz Nizipli Reviewed-By: Filip Skokan Reviewed-By: Richard Lau Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig --- common.gypi | 2 +- deps/v8/include/v8-internal.h | 13 ------------- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/common.gypi b/common.gypi index 0e330b08919..03739d7f51c 100644 --- a/common.gypi +++ b/common.gypi @@ -38,7 +38,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.2', + 'v8_embedder_string': '-node.3', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/include/v8-internal.h b/deps/v8/include/v8-internal.h index 9a39f8ede92..945c6cb61c9 100644 --- a/deps/v8/include/v8-internal.h +++ b/deps/v8/include/v8-internal.h @@ -434,19 +434,6 @@ constexpr size_t kMaxCppHeapPointers = 0; // which all subtypes of a given supertype use contiguous tags. This struct can // then be used to represent such a type range. // -// As an example, consider the following type hierarchy: -// -// A F -// / \ -// B E -// / \ -// C D -// -// A potential type id assignment for range-based type checks is -// {A: 0, B: 1, C: 2, D: 3, E: 4, F: 5}. With that, the type check for type A -// would check for the range [A, E], while the check for B would check range -// [B, D], and for F it would simply check [F, F]. -// // In addition, there is an option for performance tweaks: if the size of the // type range corresponding to a supertype is a power of two and starts at a // power of two (e.g. [0x100, 0x13f]), then the compiler can often optimize