BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
40,720 Commits 266 Branches 972 Tags
079c3460cdc72da170cc912642302855257bcda8
Commit Graph
116 Commits
Author SHA1 Message Date
Michaël Zasso 6557c1c9b1 tools: update gyp-next to v0.16.1 
PR-URL: https://github.com/nodejs/node/pull/50380
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-10-31 12:44:38 +00:00
Cheng Zhao d1ccca9d2b build: fix building when there is only python3 
PR-URL: https://github.com/nodejs/node/pull/48462
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2023-10-25 02:43:37 +00:00
Jiawen Geng bb0986f79d tools: update gyp-next to v0.13.0 
PR-URL: https://github.com/nodejs/node/pull/44605
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-09-14 07:55:11 +00:00
Antoine du Hamel 1e761654d3 doc: consolidate use of multiple-byte units 
Refs: https://en.wikipedia.org/wiki/Byte#Multiple-byte_units

PR-URL: https://github.com/nodejs/node/pull/42587
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
 2022-04-20 00:46:37 +02:00
Michaël Zasso b99bb57416 tools: update gyp-next to v0.12.1 
PR-URL: https://github.com/nodejs/node/pull/42625
Refs: https://github.com/nodejs/gyp-next/compare/v0.10.1...v0.12.1
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
 2022-04-08 15:00:56 +01:00
Michaël Zasso b3073f3737 tools: update gyp-next to v0.10.1 
PR-URL: https://github.com/nodejs/node/pull/40934
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-11-26 06:23:46 +00:00
Daniel Bevenius f4bd91b0e2 deps,build,tools: fix openssl-is-fips for ninja builds 
Currently using the --openssl-is-fips configuration option in
combination with --ninja is broken.

This commit fixes two issues, one being an issue with the linker/version
script path variable. The second is that the locations of built
artifacts that differ for ninja and make.

ninja:
$ ./configure --openssl-is-fips --ninja
$ ninja -C out/Release
$ ./node --enable-fips -p 'crypto.getFips()'
1

make:
$ ./configure --openssl-is-fips
$ make -j8
$ ./node --enable-fips -p 'crypto.getFips()'
1

PR-URL: https://github.com/nodejs/node/pull/40518
Refs: https://github.com/nodejs/node/issues/40509
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
 2021-10-21 04:16:19 +02:00
Daniel Bevenius 66da32c045 deps,test,src,doc,tools: update to OpenSSL 3.0 
This pull request updates the OpenSSL version that is statically
linked with Node.js from OpenSSl 1.1.1 to quictls OpenSSL 3.0.0+quic.

This pull request will replace the OpenSSL version that is currently
in the deps directory and when performing a normal build
OpenSSL 3.0+quic will be statically linked to the Node.js executable.
We will still be able to dynamically link to OpenSSL 1.1.1 and we have
a CI job which dynamically links to OpenSSL 1.1.1 which is run for
every pull request to make sure that we maintain backward compatibility.

PR-URL: https://github.com/nodejs/node/pull/38512
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-10-11 06:28:08 +02:00
Michaël Zasso 4595a0e5f6 tools: update gyp-next to v0.10.0 
PR-URL: https://github.com/nodejs/node/pull/39857
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-09-01 23:11:30 +02:00
Jiawen Geng 28113ed92e tools: update gyp-next to v0.9.5 
PR-URL: https://github.com/nodejs/node/pull/39818
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-08-23 07:48:13 +00:00
Jiawen Geng 80e7872f6a tools: update gyp-next to v0.9.3 
PR-URL: https://github.com/nodejs/node/pull/39291
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-07-09 02:18:16 +00:00
Jiawen Geng ffdaf475e9 tools: update gyp-next to v0.9.1 
PR-URL: https://github.com/nodejs/node/pull/38867
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-06-03 01:55:16 +00:00
Michaël Zasso 8c94aea98e tools: update gyp-next to v0.7.0 
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.7.0

PR-URL: https://github.com/nodejs/node/pull/36580
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
 2020-12-26 12:19:26 +01:00
Michaël Zasso 35a6946193 tools: update gyp-next to v0.6.2 
PR-URL: https://github.com/nodejs/node/pull/35690
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-10-17 04:18:55 -07:00
Ujjwal Sharma be80faa0c8 tools: update gyp-next to v0.6.0 
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0

PR-URL: https://github.com/nodejs/node/pull/35635
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
 2020-10-14 12:09:45 +05:30
Ujjwal Sharma f215a4d885 tools: update gyp to v0.5.0 
PR-URL: https://github.com/nodejs/node/pull/32698
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-10-04 13:29:46 +05:30
Ujjwal Sharma e73f0a00c6 tools: update gyp to v0.4.0 
PR-URL: https://github.com/nodejs/node/pull/32698
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-10-04 13:29:42 +05:30
Ujjwal Sharma 916516c8d7 tools: update gyp-next to v0.3.0 
PR-URL: https://github.com/nodejs/node/pull/32698
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-10-04 13:29:39 +05:30
Ujjwal Sharma 535859dbd8 tools: update gyp-next to v0.2.1 
PR-URL: https://github.com/nodejs/node/pull/32698
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-10-04 13:29:35 +05:30
Ujjwal Sharma a8f59173cd tools: update gyp to 0.2.0 
PR-URL: https://github.com/nodejs/node/pull/32698
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-10-04 13:29:30 +05:30
Richard Townsend 66807e995d tools,gyp: add support for MSVC cross-compilation 
This change means that GYP can now generate two sets of projects: one
exclusively for a host x64 machine and one containing a mix of x64 and
Arm targets. The names of host targets are fixed up to end with
_host.exe, and any actions involving them are fixed up. This allows
compilation of Node on an x64 server for a Windows on Arm target.

PR-URL: https://github.com/nodejs/node/pull/32867
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: João Reis <reis@janeasystems.com>
 2020-05-19 19:27:25 +01:00
forfun414 50317c38a4 build: support android build on ndk version equal or above 23 
change scripts and sources for android build, don't need standalone
toolchain after ndk 19, and use clang as default android target
compiler.

PR-URL: https://github.com/nodejs/node/pull/31521
Reviewed-By: Christian Clauss <cclauss@me.com>
 2020-03-11 16:50:52 +01:00
Michaël Zasso cf00961047 tools: sync gyp code base with node-gyp repo 
PR-URL: https://github.com/nodejs/node/pull/30563
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-02-21 10:34:20 +01:00
Giovanny Andres Gongora Granada (Gioyik) 64161f2a86 tools: replace deprecated iteritems() for items() 
This is a Built-In change in Python 3 used by compile_commands_json.py
to generate compile_commands_json.json. Node.js dropped Python 2 support
in this script, `items()` works as expected replacement.

PR-URL: https://github.com/nodejs/node/pull/31528
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2020-01-28 22:20:34 -08:00
cclauss e6a58a89cb test: fix Python unittests in ./test and ./tools 
Co-authored-by: @patrickhousley

Fixes to Python tests to ensure that the following all pass:
1. __python2 -m pytest ./test ./tools__  # 30 tests pass
2. __python3 -m pytest ./test ./tools__  # 30 tests pass
3. __python2 -m unittest discover -s ./test/tools__  # 1 test passes
4. __python3 -m unittest discover -s ./test/tools__  # 1 test passes
5. __PYTHON=python2 make tooltest__   # 1 test passes
6. __PYTHON=python3 make tooltest__   # 1 test passes

This is a subset of #30033

PR-URL: https://github.com/nodejs/node/pull/30340
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
 2019-11-11 10:44:54 +01:00
cclauss 0673dfc0d8 tools: pull xcode_emulation.py from node-gyp 
PR-URL: https://github.com/nodejs/node/pull/30272
Fixes: https://github.com/nodejs/node/issues/30129
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2019-11-06 12:39:48 +03:00
cclauss 9529c6660f tools: fix Python 3 syntax error in mac_tool.py 
PR-URL: https://github.com/nodejs/node/pull/30146
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
 2019-11-01 09:03:47 +01:00
cclauss 2d8307e199 tools: use print() function in buildbot_run.py 
PR-URL: https://github.com/nodejs/node/pull/30148
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2019-10-31 23:19:21 +01:00
Christian Clauss db1aab9df6 tools: undefined name opts -> args in gyptest.py 
```
./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts'
    extra_path = [os.path.abspath(p) for p in opts.path]
                                              ^
```
`opts.path` is an undefined name in this context while `args.path` is
used on the preceding line and is defined on line 48.  Undefined names
have the potential to raise `NameError` at runtime which will halt the
script.

PR-URL: https://github.com/nodejs/node/pull/30144
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2019-10-31 22:10:40 +01:00
Ben Noordhuis 6f814013f4 build: fix version checks in gyp files 
Make `distutils.version.StrictVersion` available as a helper to
gyp expressions so they can do proper version checks and update
the gyp files accordingly.

Caveat emptor: `StrictVersion` does *not* like empty strings so
this commit adds truthiness guards. The helper could deal with
those but I felt it better to make it explicit.

Fixes: https://github.com/nodejs/node/issues/29927

PR-URL: https://github.com/nodejs/node/pull/29931
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-10-13 16:20:22 -07:00
Michaël Zasso 8728f8660a tools: fix GYP MSVS solution generator for Python 3 
PR-URL: https://github.com/nodejs/node/pull/29897
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
 2019-10-13 20:28:19 +02:00
Michaël Zasso 66b953207d tools: port Python 3 compat patches from node-gyp to gyp 
Refs: https://github.com/nodejs/node-gyp/pull/1820
Refs: https://github.com/nodejs/node-gyp/pull/1843

PR-URL: https://github.com/nodejs/node/pull/29897
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
 2019-10-13 20:28:08 +02:00
Michaël Zasso af161f0efb tools: fix GYP ninja generator for Python 3 
PR-URL: https://github.com/nodejs/node/pull/29416
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2019-09-05 13:53:24 +02:00
Christian Clauss 40060f4e42 gyp: make StringIO work in ninja.py 
Allow both Python 2 and 3 to access StringIO.

This fixes `./configure --ninja`, which was broken by
https://github.com/nodejs/node/pull/29371.

See: https://github.com/nodejs/node/pull/29371#issuecomment-527331969

PR-URL: https://github.com/nodejs/node/pull/29414
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
 2019-09-03 09:31:14 -07:00
cclauss 020c2eaf4b tools: use 'from io import StringIO' in ninja.py 
PR-URL: https://github.com/nodejs/node/pull/29371
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2019-09-02 21:01:09 -07:00
David Carlier 8675152f0f build: integrate DragonFlyBSD into gyp build 
PR-URL: https://github.com/nodejs/node/pull/29313
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2019-08-29 06:09:05 +02:00
MattIPv4 6726f567d7 gyp: remove semicolons (Python != JavaScript) 
PR-URL: https://github.com/nodejs/node/pull/29228
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2019-08-22 21:24:39 -07:00
cclauss 99f80604ad tools: fix Python 3 issues in gyp/generator/make.py 
PR-URL: https://github.com/nodejs/node/pull/29214
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2019-08-21 15:50:09 -07:00
cclauss 3b92998918 gyp: futurize imput.py to prepare for Python 3 
PR-URL: https://github.com/nodejs/node/pull/29140
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2019-08-20 10:24:13 -07:00
Michaël Zasso 4e2d1a1433 build,tools: support building with Visual Studio 2019 
Add a `vs2019` option to `vcbuild.bat` to use VS 2019 instead of VS 2017

PR-URL: https://github.com/nodejs/node/pull/28781
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
 2019-07-27 11:48:28 +02:00
cclauss 54fcb14467 gyp: cherrypick more Python3 changes from node-gyp 
PR-URL: https://github.com/nodejs/node/pull/28563
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2019-07-16 10:40:31 -07:00
cclauss 5ebaf703aa gyp: pull Python 3 changes from node/node-gyp 
PR-URL: https://github.com/nodejs/node/pull/28573
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2019-07-11 09:33:51 -07:00
Refael Ackermann 317b712a52 tools,gyp: introduce MSVS 2019 
PR-URL: https://github.com/nodejs/node/pull/27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2019-06-01 09:55:43 -04:00
Jon Kunkee 06c10cdc4c build,win: teach GYP MSVS generator about MARMASM 
The toolchain for ARM64 Windows includes support for assembly code, but
with a very different syntax from MASM and NASM. This change teaches
GYP how to emit the right XML tags in VCXPROJ files to support
compiling assembly files with the new tool.

PR-URL: https://github.com/nodejs/node/pull/26020
Refs: https://github.com/nodejs/node/issues/25998
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-04-11 17:44:10 +01:00
Refael Ackermann fff922afee deps,build: compute torque_outputs in v8.gyp 
PR-URL: https://github.com/nodejs/node/pull/26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-03-28 16:39:00 -04:00
Bartosz Sosnowski 9920dbcaf3 build, tools, win: add .S files support to GYP 
Makes GYP properly handle .S files.

Fixes: https://github.com/nodejs/node-v8/issues/89

PR-URL: https://github.com/nodejs/node/pull/24553
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2018-11-29 11:09:03 +01:00
Sakthipriyan Vairamani (thefourtheye) 17a0cd2bab Revert "tools,gyp: don't force build actions with multiple outputs" 
This reverts commit 5d8373a498.

Fixes: https://github.com/nodejs/node/issues/23255

PR-URL: https://github.com/nodejs/node/pull/23257
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2018-10-04 08:53:49 -07:00
Refael Ackermann 5d8373a498 tools,gyp: don't force build actions with multiple outputs 
Don't add `force_append` (FORCE_DO_CMD) to the intermediate sentinal.
Adding it makes the action run alway, even when there are no changes.
(refack): AFAICT because `*.intermediate` files don't have build rules.

PR-URL: https://github.com/nodejs/node/pull/23156
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2018-10-02 17:53:14 -04:00
Refael Ackermann 731a72f387 tools,gyp: cosmetic change to GYP make generator outputs 
Puts the compilation target upfront for easy reading.

PR-URL: https://github.com/nodejs/node/pull/23156
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2018-10-02 17:53:14 -04:00
Ujjwal SharmaandGibson Fahnestock 16cffb0d48 gyp: muffle xcodebuild warnings 
Muffle xcodebuild warnings by introducing an alternative quieter
alternative to GetStdout, called GetStdoutQuiet, and call it selectively
in particularly noisy xcodebuild commands.

Co-authored-by: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/21999
Original-PR-URL: https://github.com/nodejs/node-gyp/pull/1370
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2018-08-25 04:41:56 +05:30