Keyhan Vakil
5b73da02e5
build: add configuration flag to enable Maglev
...
This adds a configuration flag to enable V8's Maglev compiler.
Unfortunately compilation fails unless you have clang-14+ or gcc-13+,
but I sent a patch for that upstream. Other than that, it builds and all
tests pass locally on my x86-64 Linux machine.
The gn scraper regexes were broken preventing the compilation from
linking. Fix them. As a drive-by, also add additional conditionals for
compilation on 32-bit arm.
Refs: https://github.com/nodejs/node/issues/50690
PR-URL: https://github.com/nodejs/node/pull/50692
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-20 04:10:40 +00:00
Chengzhong Wu
d1326e5b54
build: disable flag v8_scriptormodule_legacy_lifetime
...
Usages of `v8::ScriptOrModule` were removed in https://github.com/nodejs/node/pull/44198
so the flag can be disabled by default.
PR-URL: https://github.com/nodejs/node/pull/50616
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2023-11-17 03:55:33 +00:00
Yagiz Nizipli
4ec085b240
deps: add simdjson
...
PR-URL: https://github.com/nodejs/node/pull/50322
Reviewed-By: Jacob Smith <jacob@frende.me >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
2023-11-17 00:16:38 +00:00
Cheng Zhao
1d8483e713
tools: recognize GN files in dep_updaters
...
PR-URL: https://github.com/nodejs/node/pull/50693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2023-11-15 04:37:09 +00:00
Ulises Gascon
dfbca339b7
tools: remove unused file
...
PR-URL: https://github.com/nodejs/node/pull/50622
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2023-11-14 18:57:19 -05:00
Marco Ippolito
0304da22d3
tools: change minimatch install strategy
...
PR-URL: https://github.com/nodejs/node/pull/50476
Refs: https://github.com/nodejs/security-wg/issues/1037
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-13 08:32:30 +00:00
Node.js GitHub Bot
36e4635915
tools: update lint-md-dependencies to rollup@4.3.1
...
PR-URL: https://github.com/nodejs/node/pull/50675
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2023-11-12 11:07:19 +00:00
Ulises Gascón
ce6c9b050d
tools: add macOS notarization stapler
...
PR-URL: https://github.com/nodejs/node/pull/50625
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-11-11 19:58:27 +00:00
Cheng Zhao
32af45d241
build: add GN build files
...
PR-URL: https://github.com/nodejs/node/pull/47637
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2023-11-11 09:51:05 +00:00
Node.js GitHub Bot
33704c46e3
tools: update eslint to 8.53.0
...
PR-URL: https://github.com/nodejs/node/pull/50559
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2023-11-07 00:48:10 +00:00
Node.js GitHub Bot
15a2635c0a
tools: update lint-md-dependencies to rollup@4.3.0
...
PR-URL: https://github.com/nodejs/node/pull/50556
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2023-11-07 00:48:01 +00:00
Michaël Zasso
cde3296f5f
tools: compare ICU checksums before file changes
...
Otherwise we end up with an bad update PR when checksums don't match.
Refs: https://github.com/nodejs/node/pull/50495
PR-URL: https://github.com/nodejs/node/pull/50522
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-11-06 11:21:49 +00:00
Marco Ippolito
2a1bd660bd
tools: improve update acorn-walk script
...
PR-URL: https://github.com/nodejs/node/pull/50473
Refs: https://github.com/nodejs/security-wg/issues/1037
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
2023-11-05 09:43:08 +00:00
Node.js GitHub Bot
83736436b2
tools: update lint-md-dependencies to rollup@4.2.0
...
PR-URL: https://github.com/nodejs/node/pull/50496
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-11-03 08:24:55 +00:00
Shi Pujin
1b74aa3cb2
test: fix timeout of test-cpu-prof-dir-worker.js in LoongArch devices
...
PR-URL: https://github.com/nodejs/node/pull/50363
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2023-11-02 07:29:56 +00:00
Ulises Gascón
d2903f9df2
tools: improve macOS notarization process output readability
...
PR-URL: https://github.com/nodejs/node/pull/50389
Fixes: https://github.com/nodejs/build/issues/3529
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-01 13:40:54 +00:00
Michaël Zasso
6557c1c9b1
tools: update gyp-next to v0.16.1
...
PR-URL: https://github.com/nodejs/node/pull/50380
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2023-10-31 12:44:38 +00:00
Node.js GitHub Bot
a913b8742f
tools: update lint-md-dependencies to rollup@4.1.5 unified@11.0.4
...
PR-URL: https://github.com/nodejs/node/pull/50461
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-10-31 00:31:58 +00:00
Ulises Gascón
1392538d1b
tools: remove unused version function
...
PR-URL: https://github.com/nodejs/node/pull/50390
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-10-30 11:23:30 +01:00
Marco Ippolito
ecf0330bbe
tools: avoid npm install in deps installation
...
PR-URL: https://github.com/nodejs/node/pull/50413
Refs: https://github.com/nodejs/node/pull/49747
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-10-30 08:16:39 +00:00
Richard Lau
67b1383149
Revert "tools: update doc dependencies"
...
This reverts commit 6431c657d9 .
PR-URL: https://github.com/nodejs/node/pull/50414
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2023-10-26 20:46:58 +00:00
Node.js GitHub Bot
6431c657d9
tools: update doc dependencies
...
- hightlight.js@11.9.0
- remark-frontmatter@5.0.0
- remark-gfm@4.0.0
- remark-html@16.0.1
- remark-parse@11.0.0
- remark-rehype@11.0.0
- unified@11.0.3
PR-URL: https://github.com/nodejs/node/pull/49988
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-10-26 12:42:35 +00:00
Cheng Zhao
d1ccca9d2b
build: fix building when there is only python3
...
PR-URL: https://github.com/nodejs/node/pull/48462
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2023-10-25 02:43:37 +00:00
Node.js GitHub Bot
452de06a0f
tools: update eslint to 8.52.0
...
PR-URL: https://github.com/nodejs/node/pull/50326
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-10-24 00:40:53 +00:00
Jithil P Ponnan
9c7af51049
src: add commit hash shorthand in zlib version
...
src: add commit hash shorthand in zlib version
PR-URL: https://github.com/nodejs/node/pull/50158
Fixes: https://github.com/nodejs/node/issues/50139
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2023-10-23 17:22:16 +00:00
Node.js GitHub Bot
b00e3b300e
tools: update lint-md-dependencies
...
- @rollup/plugin-commonjs@25.0.7
- @rollup/plugin-node-resolve@15.2.3
- rollup@4.1.4
PR-URL: https://github.com/nodejs/node/pull/50190
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-10-23 17:11:15 +00:00
Ulises Gascón
fc423db0aa
tools: drop support for osx notarization with gon
...
Refs: https://github.com/nodejs/build/issues/3385#issuecomment-1729281269
PR-URL: https://github.com/nodejs/node/pull/50291
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2023-10-21 15:54:17 +00:00
Jungku Lee
f09a50c39d
tools: update comment in update-uncidi.sh and acorn_version.h
...
PR-URL: https://github.com/nodejs/node/pull/50175
Fixes: https://github.com/nodejs/node/issues/50159
Refs: https://github.com/nodejs/node/pull/50165
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2023-10-15 22:28:23 +02:00
Mohammed Keyvanzadeh
31bde06233
tools: refactor checkimports.py
...
- Use f-strings for formatting.
- Use raw strings for regexes alongside f-strings.
- Use a generator.
- Remove unnecessary `else` clause.
PR-URL: https://github.com/nodejs/node/pull/50011
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Christian Clauss <cclauss@me.com >
2023-10-15 15:14:57 +00:00
Antoine du Hamel
d1ef6aa2db
esm: use import attributes instead of import assertions
...
The old import assertions proposal has been
renamed to "import attributes" with the follwing major changes:
1. The keyword is now `with` instead of `assert`.
2. Unknown assertions cause an error rather than being ignored,
This commit updates the documentation to encourage folks to use the new
syntax, and add aliases for module customization hooks.
PR-URL: https://github.com/nodejs/node/pull/50140
Fixes: https://github.com/nodejs/node/issues/50134
Refs: https://github.com/v8/v8/commit/159c82c5e6392e78b9bba7161b1bed6e23758984
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2023-10-14 03:52:38 +00:00
Keksonoid
766198b9e1
tools: fix comments referencing dep_updaters scripts
...
PR-URL: https://github.com/nodejs/node/pull/50165
Fixes: https://github.com/nodejs/node/issues/50159
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2023-10-13 00:08:05 +02:00
Matteo Collina
7ed50e5af6
deps: update undici to v5.26.3
...
Signed-off-by: Matteo Collina <hello@matteocollina.com >
PR-URL: https://github.com/nodejs/node/pull/50153
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2023-10-12 09:42:04 +00:00
Michaël Zasso
8568de3da6
tools: add new V8 headers to distribution
...
PR-URL: https://github.com/nodejs/node/pull/49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-10-10 08:26:55 +02:00
Michaël Zasso
86cb23d09f
tools: update V8 gypfiles for 11.8
...
PR-URL: https://github.com/nodejs/node/pull/49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-10-10 08:26:53 +02:00
Michaël Zasso
9c6219c7e2
tools: update V8 gypfiles for 11.7
...
PR-URL: https://github.com/nodejs/node/pull/49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-10-10 08:26:51 +02:00
Michaël Zasso
73ddf50163
tools: update V8 gypfiles for 11.6
...
PR-URL: https://github.com/nodejs/node/pull/49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-10-10 08:26:50 +02:00
Michaël Zasso
817ef255ea
tools: update V8 gypfiles for 11.5
...
PR-URL: https://github.com/nodejs/node/pull/49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-10-10 08:26:48 +02:00
Michaël Zasso
f34a3a9861
tools: update V8 gypfiles for 11.4
...
PR-URL: https://github.com/nodejs/node/pull/49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-10-10 08:26:46 +02:00
Michaël Zasso
162a0652ab
deps: bump minimum ICU version to 73
...
Refs: https://github.com/v8/v8/commit/d9715adf895e9acfbaf17ae05b18f2b2467ca322
PR-URL: https://github.com/nodejs/node/pull/49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-10-10 08:26:43 +02:00
Node.js GitHub Bot
a0a5b751fb
tools: update lint-md-dependencies
...
- @rollup/plugin-commonjs@25.0.5
- @rollup/plugin-node-resolve@15.2.2
- rollup@4.0.2
PR-URL: https://github.com/nodejs/node/pull/50083
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-10-10 00:45:53 +00:00
Joyee Cheung
387e2929fe
src: generate default snapshot with --predictable
...
To improve determinism of snapshot generation, add --predictable
to the V8 flags used to initialize a process launched to generate
snapshot. Also add a kGeneratePredictableSnapshot flag
to ProcessInitializationFlags for this and moves the configuration
of these flags into node::InitializeOncePerProcess() so that
it can be shared by embedders.
PR-URL: https://github.com/nodejs/node/pull/48749
Refs: https://github.com/nodejs/build/issues/3043
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2023-10-09 02:53:19 +00:00
Node.js GitHub Bot
69fb55e6b9
tools: update eslint to 8.51.0
...
PR-URL: https://github.com/nodejs/node/pull/50084
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-10-08 18:51:04 +00:00
Ben Noordhuis
f73650ea52
tools: remove genv8constants.py
...
Unused after commit aa3a572e6b ("build: remove dtrace & etw support")
from last year. I had this vague notion that llnode also used it but
that is another script.
Fixes: https://github.com/nodejs/node/issues/49991
PR-URL: https://github.com/nodejs/node/pull/50023
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-10-05 21:11:10 +00:00
Node.js GitHub Bot
581434e54f
tools: update eslint to 8.50.0
...
PR-URL: https://github.com/nodejs/node/pull/49989
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2023-10-03 15:32:41 +00:00
Node.js GitHub Bot
344d3c4b7c
tools: update lint-md-dependencies
...
- remark-parse@11.0.0
- remark-preset-lint-node@5.0.0
- remark-stringify@11.0.0
- rollup@3.29 .4
PR-URL: https://github.com/nodejs/node/pull/49983
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2023-10-03 13:08:30 +00:00
Claudio W
47b2883673
doc: updated building docs for windows
...
PR-URL: https://github.com/nodejs/node/pull/49767
Reviewed-By: Jacob Smith <jacob@frende.me >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2023-10-01 14:22:58 +00:00
Daniel Lemire
2990390359
inspector: simplify dispatchProtocolMessage
...
PR-URL: https://github.com/nodejs/node/pull/49780
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2023-09-30 01:58:09 +00:00
Rich Trott
7f06c270c6
tools: add navigation ARIA landmark to generated API ToC
...
As an accessibility improvement, specify the navigation landmark for
the element of our docs that contains the table of contents generated
for the specific API page.
Ref: https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/
Ref: https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA20.html
PR-URL: https://github.com/nodejs/node/pull/49882
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Claudio Wunder <cwunder@gnome.org >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
2023-09-28 14:08:53 -07:00
Rich Trott
bc056c2426
doc: add main ARIA landmark to API docs
...
As an accessibility improvement, specify the main landmark for
the column in our docs that contains the main content.
Ref: https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/
Ref: https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA20.html
PR-URL: https://github.com/nodejs/node/pull/49882
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Claudio Wunder <cwunder@gnome.org >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
2023-09-28 14:08:52 -07:00
Ulises Gascon
e97d25687b
tools: use osx notarytool for future releases
...
Signed-off-by: Ulises Gascon <UlisesGascon@users.noreply.github.com >
Refs: https://github.com/nodejs/build/issues/3385
PR-URL: https://github.com/nodejs/node/pull/48701
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2023-09-28 16:51:37 -04:00