BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
40,720 Commits 266 Branches 972 Tags
079c3460cdc72da170cc912642302855257bcda8
Commit Graph
2422 Commits
Author SHA1 Message Date
Facundo Tuesca c0bbcd489b tools: add missing step in update-base64.sh script 
PR-URL: https://github.com/nodejs/node/pull/45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2022-11-20 12:06:24 +00:00
Vasili Skurydzin 87e69434b2 gyp: fix v8 canary build on aix 
PR-URL: https://github.com/nodejs/node/pull/45496
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2022-11-19 16:15:22 +00:00
Luigi Pinca 0b5acaabbb tools: update certdata.txt 
This is the certdata.txt[0] from NSS 3.85, released on 2022-11-10.

This is the version of NSS that will ship in Firefox 108 on
2022-12-13.

[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_85_RTM/lib/ckfw/builtins/certdata.txt

PR-URL: https://github.com/nodejs/node/pull/45490
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2022-11-18 20:12:33 +00:00
Stefan Stojanovic 1f63c953e6 Revert "build: remove precompiled header and debug information for host builds" 
This reverts commit 818284b687.

Reverted commit is a no longer needed patch for ARM64 cross-compiling.
It was increasing cross-compile time drastically (~3 times longer).

PR-URL: https://github.com/nodejs/node/pull/45432
Refs: https://github.com/nodejs/node/pull/42538
Refs: https://github.com/nodejs/node/issues/42375
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
 2022-11-18 19:41:01 +00:00
Antoine du Hamel f2ee81839a tools: include current release in the list of released versions 
PR-URL: https://github.com/nodejs/node/pull/45463
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-11-14 22:58:58 +00:00
Jiawen Geng dbce478109 build: make scripts in gyp run with right python 
PR-URL: https://github.com/nodejs/node/pull/45435
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
 2022-11-14 16:36:22 +08:00
Node.js GitHub Bot 0f2cde0785 tools: update lint-md-dependencies to rollup@3.3.0 
PR-URL: https://github.com/nodejs/node/pull/45442
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2022-11-13 04:45:57 +00:00
Khafra 916af4ef2d buffer: introduce File 
PR-URL: https://github.com/nodejs/node/pull/45139
Fixes: https://github.com/nodejs/node/issues/39015
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-11-10 20:52:45 +00:00
Facundo Tuesca f313b39d8f tools: add automation for updating acorn dependency 
Add a Github Action that checks for new versions of the `acorn` and
`acorn-walk` dependencies, and creates PRs to update them if newer
versions than the ones present in the repo are found.

Refs: https://github.com/nodejs/security-wg/issues/828
PR-URL: https://github.com/nodejs/node/pull/45357
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2022-11-10 09:27:45 +00:00
Luigi Pinca 01e673c7f6 tools: allow scripts to run from anywhere 
Make the `update-cares.sh`, `update-llhttp.sh`, `update-nghttp2.sh`,
and `update-npm.sh` scripts work even if they are run outside of the
`tools` directory.

PR-URL: https://github.com/nodejs/node/pull/45361
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-11-09 14:17:44 +00:00
Node.js GitHub Bot c5824b87a4 tools: update eslint to 8.27.0 
PR-URL: https://github.com/nodejs/node/pull/45358
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-11-08 03:02:43 +00:00
cjihrig 7c6682957b test_runner: support function mocking 
This commit allows tests in the test runner to mock functions
and methods.

PR-URL: https://github.com/nodejs/node/pull/45326
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-11-07 18:25:54 -05:00
Node.js GitHub Bot b13738a558 tools: update eslint to 8.26.0 
PR-URL: https://github.com/nodejs/node/pull/45243
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
 2022-11-07 07:04:30 +00:00
Node.js GitHub Bot b353d1b1fd tools: update lint-md-dependencies to rollup@3.2.5 
PR-URL: https://github.com/nodejs/node/pull/45332
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-11-07 05:01:38 +00:00
Antoine du Hamel 7e581c88fc tools: fix stability index generation 
PR-URL: https://github.com/nodejs/node/pull/45346
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2022-11-07 01:25:44 +00:00
Filip Skokan 4a258b2060 doc: use module names in stability overview table 
PR-URL: https://github.com/nodejs/node/pull/45312
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-11-06 09:32:28 +00:00
Facundo Tuesca 1f517130dd tools: add automation for updating base64 dependency 
Add a Github Action that checks for new versions of the `base64` C
library, and creates a PR to update it if a newer version than the one
present in the repo is found.

Refs: https://github.com/nodejs/security-wg/issues/828
PR-URL: https://github.com/nodejs/node/pull/45300
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-11-06 02:17:03 +00:00
Antoine du Hamel a3874dd637 tools: fix request-ci-failed comment 
PR-URL: https://github.com/nodejs/node/pull/45291
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2022-11-03 02:14:40 +00:00
Antoine du Hamel acd6f6c608 tools: refactor dynamic strings creation in shell scripts 
PR-URL: https://github.com/nodejs/node/pull/45240
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2022-11-01 12:36:44 +00:00
Node.js GitHub Bot 548f505c3c tools: update lint-md-dependencies 
Update @rollup/plugin-commonjs@23.0.2,
@rollup/plugin-node-resolve@15.0.1, and
rollup@3.2.3.

PR-URL: https://github.com/nodejs/node/pull/45237
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-10-31 16:25:53 +00:00
Yu Gu 186745bc0d test: fix timeout of test-heap-prof.js in riscv devices 
In riscv hardware test-heap-prof.js caused timeout in test.
Because of weak performance.
So there is a need to set TIMEOUT_SCALEFACTOR for riscv too.

Fixes: https://github.com/nodejs/node/issues/40152
PR-URL: https://github.com/nodejs/node/pull/42674
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-29 12:15:14 +00:00
Antoine du Hamel 1422e51a5b tools: fix request-ci-failed comment 
Refs: https://github.com/nodejs/node/pull/45209#issuecomment-1294239904
PR-URL: https://github.com/nodejs/node/pull/45218
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2022-10-28 11:45:35 +00:00
Rich Trott 2081082973 tools: keep Emeriti lists case-insensitive alphabetic 
The current code does not treat capital and lowercase letters as
equivalent.

PR-URL: https://github.com/nodejs/node/pull/45159
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-28 04:21:20 +00:00
Antoine du Hamel 2e2dc99115 esm: protect ESM loader from prototype pollution 
In a previous commit, the loader implementation was modified to be
protected against most prototype pollution, but was kept vulnerable to
`Array.prototype` pollution. This commit fixes that, the tradeoff is
that it modifies the `ESMLoader.prototype.import` return type from an
`Array` to an array-like object.

Refs: https://github.com/nodejs/node/pull/45044
PR-URL: https://github.com/nodejs/node/pull/45175
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2022-10-27 20:09:07 +00:00
Steven R. Loomis 8fdac2056a build: fix icu-small build with ICU 72.1 
- RTTI is needed for genrb now.

Fixes: https://github.com/nodejs/node/issues/45174
PR-URL: https://github.com/nodejs/node/pull/45195
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2022-10-27 21:04:48 +02:00
Ben Noordhuis 9c13e05a41 build: remove unused language files 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: https://github.com/nodejs/node/issues/45090
PR-URL: https://github.com/nodejs/node/pull/45138
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-27 09:02:04 -04:00
Andreas Schwab e888855ed2 tools: update V8 gypfiles for RISC-V 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

PR-URL: https://github.com/nodejs/node/pull/45149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2022-10-26 16:31:15 +00:00
Michaël Zasso 1f9b181c20 deps: update ICU to 72.1 
Refs: https://github.com/unicode-org/icu/releases/tag/release-72-1
PR-URL: https://github.com/nodejs/node/pull/45068
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2022-10-25 14:13:17 +00:00
Antoine du Hamel eb32a8443a lib: add lint rule to protect against Object.prototype.then pollution 
PR-URL: https://github.com/nodejs/node/pull/45061
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2022-10-21 03:12:03 +00:00
Bradley FariasRich TrottAntoine du Hamel
 		87cdf7d412 util: add MIME utilities (#21128) 
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/21128
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-19 04:26:16 +02:00
Node.js GitHub Bot da8f6182f9 tools: update lint-md-dependencies 
Update lint-md-dependencies to @rollup/plugin-commonjs@23.0.0
@rollup/plugin-node-resolve@15.0.0 and rollup@3.2.0.

PR-URL: https://github.com/nodejs/node/pull/45019
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2022-10-16 14:49:51 +00:00
Paolo Insogna fd36a8dadb deps: update llhttp to 8.1.0 
PR-URL: https://github.com/nodejs/node/pull/44967
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
 2022-10-12 15:36:23 +02:00
Michaël Zasso b5f1564880 test: rename always-opt flag to always-turbofan 
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/3610431
PR-URL: https://github.com/nodejs/node/pull/44741
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-11 07:27:50 +02:00
Michaël Zasso 53f73d1cfe build: enable V8's trap handler on Windows 
It can now be compiled with MSVC.

PR-URL: https://github.com/nodejs/node/pull/44741
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-11 07:27:18 +02:00
Michaël Zasso 4860ad99b9 tools: update V8 gypfiles for 10.7 
PR-URL: https://github.com/nodejs/node/pull/44741
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-11 07:27:13 +02:00
Michaël Zasso 89ecdddaab deps: bump minimum ICU version to 71 
Refs: https://github.com/v8/v8/commit/3ae42771de56d60148b2d70dd2793d6db9b43b71
PR-URL: https://github.com/nodejs/node/pull/44741
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-11 07:27:08 +02:00
Darshan Sen b5add9757d tools: remove faulty early termination logic from update-timezone.mjs 
We do not build Node.js in the workflow so
https://github.com/nodejs/node/blob/f4815fcd7691364d8139b44c1295dbc46f6ee4a8/tools/update-timezone.mjs#L18
is actually the version of `tzdata` in the Node.js in the runner instead
of what's in `main`.

The script is pretty fast even when the versions differ and there is an
update, so this optimization doesn't seem to be worth having given the
problem.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/44870
Fixes: https://github.com/nodejs/node/issues/44865
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-10-10 15:23:50 +00:00
Darshan Sen 71e9bc1108 tools: fix timezone update tool 
The spawnSync call was previously silently failing with this error:
```sh
icupkg: unable to open input file "icudt*.dat"
```
because spawnSync doesn't support globbing. This change replaces the
spawnSync call with execSync because that supports globbing.

I have tested this workflow with some minor modifications in my fork and
I can confirm that it works as expected now. The bot opened this PR -
https://github.com/RaisinTen/node/pull/2 which updates
deps/icu-small/source/data/in/icudt71l.dat.bz2.

Fixes: https://github.com/nodejs/node/issues/44865
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/44870
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-10-10 15:23:50 +00:00
Node.js GitHub Bot 6a57796b0f tools: update eslint to 8.25.0 
PR-URL: https://github.com/nodejs/node/pull/44931
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-10-09 06:02:12 +00:00
Joyee Cheung be525d7d04 src: consolidate exit codes in the code base 
Add an ExitCode enum class and use it throughout the code base
instead of hard-coding the exit codes everywhere. At the moment,
the exit codes used in many places do not actually conform to
what the documentation describes. With the new enums (which
are also available to the JS land as constants in an internal
binding) we could migrate to a more consistent usage of the
codes, and eventually expose the constants to the user land
when they are stable enough.

PR-URL: https://github.com/nodejs/node/pull/44746
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-10-06 12:41:16 +00:00
Bruno Pitrus e2ca29f673 tools: make utils.SearchFiles deterministic 
`glob.glob` on Linux returns files in the order returned by the
filesystem driver, and the output from this function is stuffed by
the Electron build process straight into the `config.gypi` header,
causing non-reproducible builds.

See this log for an example of the nondeterminism:
https://rb.zq1.de/compare.factory-20220901/diffs/nodejs-electron-compare.out

PR-URL: https://github.com/nodejs/node/pull/44496
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
 2022-10-04 15:08:36 +00:00
Keyhan Vakil 691f8d1427 build: convert V8 test JSON to JUnit XML 
This introduces some code to convert from V8's test JSON output to JUnit
XML. We need this because V8's latest refactor of their test runner has
made it difficult to float our JUnit reporter patch on top (see the
referenced issue).

I also think that there needs to be the same changes to vcbuild.bat, but
I don't know how to do test those yet. I can create a Windows VM and
test it if we decide to go with this approach.

Refs: https://github.com/nodejs/node-v8/issues/236
PR-URL: https://github.com/nodejs/node/pull/44049
Fixes: https://github.com/nodejs/node-v8/issues/236
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2022-10-03 17:45:40 +00:00
legendecas 364c0e196c perf_hooks: fix webperf idlharness 
1. Enforce receiver checks on IDL interfaces.
2. Avoid prototype manipulation on constructing IDL interfaces with
   `ReflectConstruct`.
3. `defineReplaceableAttribute` should create IDL getter/setter.
4. Corrected `PerformanceResourceTiming` to inherit the public interface
   `PerformanceEntry` instead of the internal interface
   `InternalPerformanceResourceTiming`.
5. `detail` is not a specified attribute on `PerfomanceEntry`. Node.js
   specific extensions are moved to a subclass of `PerformanceEntry` as
   `PerformanceNodeEntry`.

PR-URL: https://github.com/nodejs/node/pull/44483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-04 00:55:58 +08:00
Darshan Sen 2a4452a53a tools: fix typo in tools/update-authors.mjs 
The filename ends with an s.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/44780
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
 2022-09-30 05:49:00 +00:00
Madhuri 3d49437262 tools: refactor deprecated format in no-unescaped-regexp-dot 
PR-URL: https://github.com/nodejs/node/pull/44763
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-09-27 21:26:54 +00:00
andiemontoyeah 87b9a77290 tools: update eslint-check.js to object style 
Updated rule from deprecated function-style
format to object-style format.

Refs: https://eslint.org/docs/latest/developer-guide/working-with-rules
PR-URL: https://github.com/nodejs/node/pull/44706
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-27 02:39:39 +00:00
Node.js GitHub Bot a2fcb6c51b tools: update eslint to 8.24.0 
PR-URL: https://github.com/nodejs/node/pull/44778
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2022-09-27 01:48:42 +00:00
Node.js GitHub Bot b6d62f7fad tools: update lint-md-dependencies to rollup@2.79.1 
PR-URL: https://github.com/nodejs/node/pull/44776
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-09-26 22:25:31 +00:00
chexiongsheng 6c8c3d89b0 gyp: libnode for ios app embedding 
PR-URL: https://github.com/nodejs/node/pull/44210
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2022-09-21 18:02:40 +08:00
Paolo InsognaAntoine du HamelTobias NießenLuigi Pinca
 		66531d51e9 tools: add update-llhttp.sh 
PR-URL: https://github.com/nodejs/node/pull/44652
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Tobias Nießen <tniessen@tnie.de>
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
 2022-09-19 16:00:52 +02:00