BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
40,720 Commits 266 Branches 972 Tags
079c3460cdc72da170cc912642302855257bcda8
Commit Graph
40720 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Filip Skokan 457cedda9d crypto: remove webcrypto EdDSA key checks and properties 
As per https://github.com/WICG/webcrypto-secure-curves/pull/24

PR-URL: https://github.com/nodejs/node/pull/49408
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-09-01 12:00:16 +00:00
Tim Perry 048e0bec51 tls: ensure TLS Sockets are closed if the underlying wrap closes 
This fixes a potential segfault, among various other likely-related
issues, which all occur because TLSSockets were not informed if their
underlying stream was closed in many cases.

This also significantly modifies an existing TLS test. With this change
in place, that test no longer works, as it tries to mess with internals
to trigger a race, and those internals are now cleaned up earlier. This
test has been simplified to a more general TLS shutdown test.

PR-URL: https://github.com/nodejs/node/pull/49327
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-09-01 07:00:05 +00:00
Tobias Nießen 92fb7dd818 test: simplify test-crypto-dh-group-setters 
I can't tell why the test was written that way in the first place, but
it seems sufficient to check that setPrivateKey and setPublicKey are
both undefined.

Refs: https://github.com/nodejs/node-v0.x-archive/pull/2638
Refs: https://github.com/nodejs/node/pull/11253
PR-URL: https://github.com/nodejs/node/pull/49404
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-31 19:33:22 +00:00
Chengzhong Wu 04a3567dba test: verify dynamic import call with absolute path strings 
PR-URL: https://github.com/nodejs/node/pull/49275
Refs: https://github.com/nodejs/node/pull/48655
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-08-31 17:15:27 +00:00
Chengzhong Wu f9a182c67c doc: fix node-api call example 
The `return` statement should not be enclosed in a nested conditional
branch.

PR-URL: https://github.com/nodejs/node/pull/49395
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-08-31 16:29:19 +00:00
Adam Majer ba61c07501 deps: V8: cherry-pick eadaef581c29 
Original commit message:

    Fix usage of MulHighS64 on <= z13

    mgrk is only available with MISC_INSTR_EXT2 installed.
    A runtime call needs to be made if it's unavailable.
    We also need to make sure caller saved registers are saved
    accordingly before making a call.

    Change-Id: If7ac06eef57cc3db059c2640b77c80de3b16fced
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4521297
    Reviewed-by: Junliang Yan <junyan@redhat.com>
    Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
    Cr-Commit-Position: refs/heads/main@{#87675}

Fixes: https://github.com/nodejs/node/issues/47064
PR-URL: https://github.com/nodejs/node/pull/49401
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-08-31 14:51:17 +00:00
LiviaMedeiros 57e78bc9ef url: validate pathToFileURL(path) argument as string 
PR-URL: https://github.com/nodejs/node/pull/49161
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-08-31 20:35:04 +08:00
Tim Perry 47add7eb85 net: use asserts in JS Socket Stream to catch races in future 
PR-URL: https://github.com/nodejs/node/pull/49400
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-31 12:26:40 +00:00
Tim Perry dcf6670783 net: fix crash due to simultaneous close/shutdown on JS Stream Sockets 
A JS stream socket wraps a stream, exposing it as a socket for something
on top which needs a socket specifically (e.g. an HTTP server).

If the internal stream is closed in the same tick as the layer on top
attempts to close this stream, the race between doShutdown and doClose
results in an uncatchable exception. A similar race can happen with
doClose and doWrite.

It seems legitimate these can happen in parallel, so this resolves that
by explicitly detecting and handling that situation: if a close is in
progress, both doShutdown & doWrite allow doClose to run
finishShutdown/Write for them, cancelling the operation, without trying
to use this._handle (which will be null) in the meantime.

PR-URL: https://github.com/nodejs/node/pull/49400
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-31 12:26:39 +00:00
Yagiz Nizipli f863117ba3 url: handle unicode hostname if empty 
PR-URL: https://github.com/nodejs/node/pull/49396
Fixes: https://github.com/nodejs/node/issues/48759
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-31 10:25:31 +00:00
Joyee Cheung b781eaf430 test: reduce length in crypto keygen tests 
PR-URL: https://github.com/nodejs/node/pull/49221
Refs: https://github.com/nodejs/node/issues/49202
Refs: https://github.com/nodejs/node/issues/41206
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-31 08:50:30 +00:00
Joyee Cheung b9a6ab5c48 test: split JWK async elliptic curve keygen tests 
PR-URL: https://github.com/nodejs/node/pull/49221
Refs: https://github.com/nodejs/node/issues/49202
Refs: https://github.com/nodejs/node/issues/41206
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-31 08:50:29 +00:00
Joyee Cheung 7224940e54 test: split test-crypto-keygen.js 
To avoid timing out on ARM machines in the CI.

PR-URL: https://github.com/nodejs/node/pull/49221
Refs: https://github.com/nodejs/node/issues/49202
Refs: https://github.com/nodejs/node/issues/41206
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-31 08:50:28 +00:00
Tobias Nießen a81d5e11f3 doc,test: add known path resolution issue in permission model 
As a side effect of 205f1e643e, Node.js
now resolves some paths differently when the permission model is
enabled. While these are mostly edge cases, they are worth mentioning in
the documentation. This commit also adds a known_issues test that
demonstrates one such difference.

PR-URL: https://github.com/nodejs/node/pull/49155
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-08-31 06:58:59 +00:00
Erick Wendel c750049318 test_runner: add support for setImmediate 
PR-URL: https://github.com/nodejs/node/pull/49397
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-08-31 06:42:03 +00:00
Phil Nash 3a6a80a4e1 test_runner: report covered lines, functions and branches to reporters 
This is a breaking change for the format of test:coverage events. But
the test coverage is still experimental, so I don't believe it requires
a semver-major bump.

Fixes https://github.com/nodejs/node/issues/49303

PR-URL: https://github.com/nodejs/node/pull/49320
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-08-30 20:22:45 +00:00
Livia Medeiros fcf5de008a benchmark: use tmpdir.resolve() 
PR-URL: https://github.com/nodejs/node/pull/49137
Refs: https://github.com/nodejs/node/pull/49079
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2023-08-30 09:55:20 +00:00
Michael Graeb 9848352974 node-api: fix compiler warning in node_api.h 
Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022,
compiling C, targeting arch arm64 (on x86_64 host). I build my C
addon with -Werror and recent changes to node_api.h broke our build.

PR-URL: https://github.com/nodejs/node/pull/49103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-08-30 02:42:31 +00:00
Michael Dawson eccdbe250e doc: add news issue for Diagnostics WG 
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/49306
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
 2023-08-29 15:15:35 -04:00
Tobias Nießen 43704dd230 src: rename IsAnyByteSource to IsAnyBufferSource 
The current name is somewhat confusing. There is an internal ByteSource
class, which is entirely unrelated to what IsAnyByteSource() does, even
though both exist in the crypto subsystem of the C++ code. ByteSource
objects can also be constructed from strings, for example, for which
IsAnyByteSource() returns false.

Web IDL calls the types for which this function returns true
BufferSource. This type is commonly used across Web Crypto, for example.
Thus, rename the function to match the Web IDL naming.

Because the function also appears to accept BufferSource objects backed
by SharedArrayBuffer instances, the exact Web IDL name would be
AllowSharedBufferSource, but that seems unnecessarily long, so I decided
to stick with "any".

PR-URL: https://github.com/nodejs/node/pull/49346
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-08-29 18:52:54 +00:00
Tobias Nießen 452bae1d8e test: rename test-crypto-modp1-error 
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: https://github.com/nodejs/node/pull/40451
PR-URL: https://github.com/nodejs/node/pull/49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-29 18:44:34 +00:00
Node.js GitHub Bot 0ebd0882a8 crypto: update root certificates to NSS 3.93 
This is the certdata.txt[0] from NSS 3.93, released on 2023-06-29.

This is the version of NSS that shipped in Firefox 116 on
2023-08-01.

Certificates added:
- Sectigo Public Server Authentication Root E46
- Sectigo Public Server Authentication Root R46
- SSL.com TLS RSA Root CA 2022
- SSL.com TLS ECC Root CA 2022
- Atos TrustedRoot Root CA ECC TLS 2021
- Atos TrustedRoot Root CA RSA TLS 2021

Certificates removed:
- Hongkong Post Root CA 1
- E-Tugra Certification Authority
- E-Tugra Global Root CA RSA v3
- E-Tugra Global Root CA ECC v3

[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_93_RTM/lib/ckfw/builtins/certdata.txt

PR-URL: https://github.com/nodejs/node/pull/49341
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-08-29 15:44:57 +00:00
Yiyun Lei 9cd70f4c0e test: migrate message source map tests from Python to JS 
Migrate the remaining source map tests in the `test/message` folder
from Python to JS.

Fixes: https://github.com/nodejs/node/issues/47707

test: migrate message source map tests from Python to JS
PR-URL: https://github.com/nodejs/node/pull/49238
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-08-29 10:36:23 +00:00
Node.js GitHub Bot 7104a715e0 tools: update eslint to 8.48.0 
PR-URL: https://github.com/nodejs/node/pull/49343
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-08-29 00:33:35 +00:00
Node.js GitHub Bot 7e7aad84df tools: update lint-md-dependencies 
PR-URL: https://github.com/nodejs/node/pull/49342
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-08-29 00:33:27 +00:00
Rafael Gonzaga 9eb84febf0 doc: clarify policy expectations 
PR-URL: https://github.com/nodejs/node/pull/48947
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2023-08-28 21:41:57 +00:00
Cheng Zhao 0409cdd91c tools: remove v8_dump_build_config action 
The script has been removed in #44741.

PR-URL: https://github.com/nodejs/node/pull/49301
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-27 22:06:33 +00:00
Jungku Lee b9153af4cc doc: add print results for examples in StringDecoder 
PR-URL: https://github.com/nodejs/node/pull/49326
Refs: https://github.com/nodejs/node/pull/49143
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-27 15:32:47 +00:00
Tobias Nießen 5a0777776d crypto: do not overwrite _writableState.defaultEncoding 
This only affects the writable side of LazyTransform and should not
change the behavior of any LazyTransform streams (Cipher, Decipher,
Cipheriv, Decipheriv, Hash, Hmac).

If the user does not set defaultEncoding when creating a transform
stream, WritableState uses 'utf8' by default. Only LazyTransform
overwrites this with 'buffer' for strict backward compatibility. This
was necessary when crypto.DEFAULT_ENCODING still existed. Now that
DEFAULT_ENCODING has been removed, defaultEncoding is always 'buffer'.
The writable side of LazyTransform appears to treat 'utf8' and 'buffer'
in exactly the same way. Therefore, there seems to be no need to
overwrite _writableState.defaultEncoding at this point.

Nevertheless, because Node.js has failed to hide implementation details
such as _writableState from the ecosystem, we may want to consider this
a breaking change.

Refs: https://github.com/nodejs/node/pull/47182
Refs: https://github.com/nodejs/node/pull/8611
PR-URL: https://github.com/nodejs/node/pull/49140
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-08-27 14:12:29 +00:00
Tobias Nießen 56c3263049 doc: update outdated reference to NIST SP 800-131A 
NIST SP 800-131A Rev. 1 has been withdrawn. Replace the reference with a
link to NIST SP 800-131A Rev. 2.

PR-URL: https://github.com/nodejs/node/pull/49316
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2023-08-26 21:11:21 +00:00
Deokjin Kim fee0601674 doc: use cjs as block code's type in MockTimers 
Use `cjs` instead of `js` to show toggle button between
CJS and ESM because corresponding example using `mjs`
exists.

PR-URL: https://github.com/nodejs/node/pull/49309
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-26 14:57:18 +00:00
Yeseul Lee 76e659a103 fs: add the options param description in openAsBlob() 
PR-URL: https://github.com/nodejs/node/pull/49308
Refs: https://github.com/nodejs/node/blob/main/doc/api/fs.md#fsopenasblobpath-options
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-26 14:48:59 +00:00
Khafra 4ba7370650 stream: use Buffer.from when constructor is a Buffer 
When using BYOB streams, it's possible for the constructor in
readableByteStreamControllerConvertPullIntoDescriptor to be a node
Buffer. If it is, use `Buffer.from` over `new ctor`.

Fixes https://github.com/nodejs/node/issues/49245

PR-URL: https://github.com/nodejs/node/pull/49250
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-08-26 11:43:58 +00:00
Node.js GitHub Bot 1ca23adc35 tools: update lint-md-dependencies 
- @rollup/plugin-node-resolve@15.2.0
- unified@11.0.1
- vfile-reporter@8.1.0

PR-URL: https://github.com/nodejs/node/pull/49253
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2023-08-26 12:56:58 +02:00
Shubham Pandey 4178683a26 doc: update options.filter description for fs.cp 
PR-URL: https://github.com/nodejs/node/pull/49289
Fixes: https://github.com/nodejs/node/issues/49092
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2023-08-26 07:53:46 +02:00
Stewart X Addison 3d0a317763 doc: add riscv64 to list of architectures 
PR-URL: https://github.com/nodejs/node/pull/49284

Signed-off-by: Stewart X Addison <sxa@redhat.com>
Fixes: https://github.com/nodejs/node/issues/49278
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-26 07:48:16 +02:00
Antoine du Hamel 69f7583ee5 policy: fix path to URL conversion 
PR-URL: https://github.com/nodejs/node/pull/49133
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-08-26 05:45:13 +00:00
Tobias Nießen 460c19f226 doc: avoid "not currently recommended" 
Compromised algorithms will never again be recommended, so remove the
qualifier "currently".

PR-URL: https://github.com/nodejs/node/pull/49300
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2023-08-25 20:08:17 +00:00
Deokjin Kim c5cad08476 fs: remove redundant code in readableWebStream() 
Remove redundant code by moving it to outside of `if/else`. Plus,
make `options` optional in doc.

PR-URL: https://github.com/nodejs/node/pull/49298
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-25 15:23:15 +00:00
Geoffrey Booth 33710e7e7d doc: update module hooks docs 
PR-URL: https://github.com/nodejs/node/pull/49265
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-08-24 19:27:23 +00:00
Tobias Nießen 6117cc3bd1 test: fix compiler warning in NodeCryptoEnv 
This fixes a warning in line 26: "warning: value computed is not used"
when calling BIO_seek().

Refs: https://github.com/nodejs/node/pull/47160
PR-URL: https://github.com/nodejs/node/pull/49206
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-08-24 16:25:09 +00:00
Jungku Lee a494ef68f3 doc: modify param description for end(),write() in StringDecoder 
PR-URL: https://github.com/nodejs/node/pull/49285
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
 2023-08-24 16:00:28 +00:00
Juan José 5ff1ead6b2 build: add symlink to compile_commands.json file if needed 
Usually lsp servers needs the `compile_commands.json` file in the root
directory.

Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/49260
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-08-24 14:02:04 +00:00
Raz LuvatonandRobert Nagy b0f423390f stream: add highWaterMark for the map operator 
this is done so we don't wait for the first items to
finish before starting new ones

Fixes: https://github.com/nodejs/node/issues/46132

Co-authored-by: Robert Nagy <ronagy@icloud.com>
PR-URL: https://github.com/nodejs/node/pull/49249
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2023-08-24 12:11:21 +00:00
Node.js GitHub Bot da197d1890 deps: update zlib to 1.2.13.1-motley-f5fd0ad 
PR-URL: https://github.com/nodejs/node/pull/49252
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-08-24 11:17:43 +00:00
Robert NagyandChemi Atlow feb5b0fef8 fs: make sure to write entire buffer 
fs.write(v) is not guaranteed to write everything in a single
call. Make sure we don't assume so.

PR-URL: https://github.com/nodejs/node/pull/49211
Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2023-08-24 08:15:08 +03:00
Cheng Zhao 996f3904bc doc: use NODE_API_SUPPORTED_VERSION_MAX in release doc 
The code was changed in #48501 but the doc was missed.

PR-URL: https://github.com/nodejs/node/pull/49268
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-08-23 14:11:54 -04:00
Abdirahim Musse ee1f609a9e test: handle EUNATCH 
When IPv6 is disabled IBM i returns EUNATCH (errno 42)
instead of EADDRNOTAVAIL.

libuv 1.46.0 adds EUNATCH errno

We can now use error.code to refer to EUNATCH
in node versions that use libuv 1.46.0.

PR-URL: https://github.com/nodejs/node/pull/48050
Refs: https://github.com/nodejs/node/issues/48049
Refs: https://github.com/nodejs/node/pull/46546
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-08-23 14:00:25 -04:00
Antoine du Hamel e74d1b8db9 doc: fix typo in stream.finished documentation 
PR-URL: https://github.com/nodejs/node/pull/49271
Refs: https://nodejs.org/api/stream.html#streamfinishedstream-options
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
 2023-08-23 09:17:31 +00:00
Antoine du Hamel bca14f8518 worker: protect against user mutating well-known prototypes 
PR-URL: https://github.com/nodejs/node/pull/49270
Fixes: https://github.com/nodejs/node/issues/49259
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-08-23 09:06:51 +00:00