BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
40,720 Commits 266 Branches 972 Tags
079c3460cdc72da170cc912642302855257bcda8
Commit Graph
40720 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Livia Medeiros 7bbcb292b2 test: add tmpdir.fileURL() 
PR-URL: https://github.com/nodejs/node/pull/49040
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2023-08-10 23:07:30 +00:00
Jason 54e4f1f5e6 src: fix callback_queue.h missing header 
PR-URL: https://github.com/nodejs/node/pull/48733
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
 2023-08-10 23:07:09 +00:00
Rich Trott f1b3ade948 doc: add missing period 
PR-URL: https://github.com/nodejs/node/pull/49094
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-08-10 15:37:10 +00:00
btea 48c613e5a7 doc: add ESM examples in http.md 
PR-URL: https://github.com/nodejs/node/pull/47763
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-10 14:44:32 +02:00
Rafael Gonzaga 23d65e7281 src: revert IS_RELEASE to 0 
PR-URL: https://github.com/nodejs/node/pull/49084
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-08-10 12:17:41 +02:00
RafaelGSS b68e5e7981 policy: handle Module.constructor and main.extensions bypass 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs-private/node-private/pull/417
Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1960870
Refs: https://hackerone.com/bugs?subject=nodejs&report_id=2043807
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
CVE-ID: CVE-2023-32002,CVE-2023-32006
 2023-08-09 14:33:55 -03:00
RafaelGSS 3868ae0f4f permission: ensure to resolve path when calling mkdtemp 
PR-URL: https://github.com/nodejs-private/node-private/pull/440
Refs: https://hackerone.com/bugs?subject=nodejs&report_id=2037887
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-08-09 14:33:14 -03:00
RafaelGSS 1f64147eb6 permission: handle buffer path on fs calls 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Refs: https://hackerone.com/bugs?subject=nodejs&report_id=2038134
PR-URL: https://github.com/nodejs-private/node-private/pull/439
 2023-08-09 14:29:12 -03:00
Tobias Nießen 4aa0eff787 policy: disable process.binding() when enabled 
process.binding() can be used to trivially bypass restrictions imposed
through a policy. Since the function is deprecated already, simply
replace it with a stub when a policy is being enabled.

Fixes: https://hackerone.com/bugs?report_id=1946470
PR-URL: https://github.com/nodejs-private/node-private/pull/397
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
CVE-ID: CVE-2023-32559
 2023-08-09 14:29:06 -03:00
Node.js GitHub Bot 4fdf70f9ab deps: update archs files for openssl-3.0.10+quic1 
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/49036
 2023-08-09 14:28:59 -03:00
Node.js GitHub Bot d167837e09 deps: upgrade openssl sources to quictls/openssl-3.0.10+quic1 
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/49036
 2023-08-09 14:28:54 -03:00
RafaelGSS 7e97e908c7 permission: handle fstatfs and add pm supported list 
PR-URL: https://github.com/nodejs-private/node-private/pull/441
CVE-ID: CVE-2023-32005
 2023-08-09 14:28:48 -03:00
RafaelGSS bd7443ad0a lib,permission: restrict process.binding when pm is enabled 
PR-URL: https://github.com/nodejs-private/node-private/pull/438
Fixes: https://github.com/nodejs-private/node-private/issues/422
CVE-ID: CVE-2023-32558
 2023-08-09 14:28:39 -03:00
RafaelGSS ae25da20fa 2023-08-09, Version 20.5.1 (Current) 
This is a security release.

Notable changes:

* CVE-2023-32002: Policies can be bypassed via Module.\_load (High)
* CVE-2023-32558: process.binding() can bypass the permission model through path traversal (High)
* CVE-2023-32004: Permission model can be bypassed by specifying a path traversal sequence in a Buffer (High)
* CVE-2023-32006: Policies can be bypassed by module.constructor.createRequire (Medium)
* CVE-2023-32559: Policies can be bypassed via process.binding (Medium)
* CVE-2023-32005: fs.statfs can bypass the permission model (Low)
* CVE-2023-32003: fs.mkdtemp() and fs.mkdtempSync() can bypass the permission model (Low)
* OpenSSL Security Releases
  * https://mta.openssl.org/pipermail/openssl-announce/2023-July/000264.html
  * https://mta.openssl.org/pipermail/openssl-announce/2023-July/000265.html
  * https://mta.openssl.org/pipermail/openssl-announce/2023-July/000267.html

PR-URL: https://github.com/nodejs-private/node-private/pull/465
 2023-08-09 14:24:18 -03:00
RafaelGSS 6d46d986a4 2023-08-09, Version 18.17.1 'Hydrogen' (LTS) 
Notable changes:

Following CVEs are fixed in this release:

* CVE-2023-32002: Policies can be bypassed via Module._load (High)
* CVE-2023-32006: Policies can be bypassed by module.constructor.createRequire (Medium)
* CVE-2023-32559: Policies can be bypassed via process.binding (Medium)
* OpenSSL Security Releases
  * https://mta.openssl.org/pipermail/openssl-announce/2023-July/000264.html
  * https://mta.openssl.org/pipermail/openssl-announce/2023-July/000265.html
  * https://mta.openssl.org/pipermail/openssl-announce/2023-July/000267.html

PR-URL: https://github.com/nodejs-private/node-private/pull/463
 2023-08-09 14:02:22 -03:00
RafaelGSS eed21991fb 2023-08-09, Version 16.20.2 'Gallium' (LTS) 
This is a security release.

Notable changes:

Following CVEs are fixed in this release:

* CVE-2023-32002: Policies can be bypassed via Module._load (High)
* CVE-2023-32006: Policies can be bypassed by module.constructor.createRequire (Medium)
* CVE-2023-32559: Policies can be bypassed via process.binding (Medium)
* OpenSSL Security Releases
  * https://mta.openssl.org/pipermail/openssl-announce/2023-July/000264.html
  * https://mta.openssl.org/pipermail/openssl-announce/2023-July/000265.html
  * https://mta.openssl.org/pipermail/openssl-announce/2023-July/000267.html

PR-URL: https://github.com/nodejs-private/node-private/pull/458
 2023-08-09 13:36:10 -03:00
Ray 6432060c7c doc: detailed description of keystrokes Ctrl-Y and Meta-Y 
PR-URL: https://github.com/nodejs/node/pull/43529
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-08-08 19:51:43 +00:00
Phil Nash 1cfd61b632 doc: add "type" to test runner event details 
In version 20.0.0 (and backported to 19.9.0 and 18.7.0) the test runner
started reporting on whether a test was a suite. This was exposed to
reporters in the `details` object of a `test:pass` or `test:fail` event
but this hasn't been documented. This adds the `type` property to both
event's `details` object.

PR-URL: https://github.com/nodejs/node/pull/49014
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-08-08 18:43:42 +00:00
Node.js GitHub Bot e1265cd473 tools: update lint-md-dependencies to rollup@3.27.2 
PR-URL: https://github.com/nodejs/node/pull/49035
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-08-08 18:36:25 +00:00
David Sanders 718fc0d011 doc: reserve 118 for Electron 27 
Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
PR-URL: https://github.com/nodejs/node/pull/49023
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-08-08 18:36:13 +00:00
Antoine du Hamel cc80513551 tools: limit the number of auto start CIs 
PR-URL: https://github.com/nodejs/node/pull/49067
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2023-08-08 13:26:07 +00:00
LiviaMedeiros aed2b21ac0 typings: update JSDoc for cwd in child_process 
PR-URL: https://github.com/nodejs/node/pull/49029
Refs: https://github.com/nodejs/node/pull/38862
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-08 15:32:31 +08:00
Daeyeon Jeong d150316a8e doc: clarify use of process.env in worker threads on Windows 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/49008
Fixes: https://github.com/nodejs/node/issues/48955
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-08-05 15:26:19 +00:00
Rafael Gonzaga 107600923d doc: remove v14 mention 
PR-URL: https://github.com/nodejs/node/pull/49005
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-05 13:30:58 +00:00
Antoine du Hamel a973446b91 test: use spawn and spawnPromisified instead of exec 
PR-URL: https://github.com/nodejs/node/pull/48991
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-08-05 07:29:53 +00:00
rogertyang 556b1ca900 tls: fix bugs of double TLS 
Fixs two issues in `TLSWrap`, one of them is reported in
https://github.com/nodejs/node/issues/30896.

1. `TLSWrap` has exactly one `StreamListener`, however,
that `StreamListener` can be replaced. We have not been
rigorous enough here: if an active write has not been
finished before the transition, the finish callback of it
will be wrongly fired the successor `StreamListener`.

2. A `TLSWrap` does not allow more than one active write,
as checked in the assertion about current_write in
`TLSWrap::DoWrite()`.

However, when users make use of an existing `tls.TLSSocket`
to establish double TLS, by
either
  tls.connect({socket: tlssock})
or
  tlsServer.emit('connection', tlssock)
we have both of the user provided `tls.TLSSocket`, tlssock and
a brand new created `TLSWrap` writing to the `TLSWrap` bound to
tlssock, which easily violates the constranint because two writers
have no idea of each other.

The design of the fix is:
when a `TLSWrap` is created on top of a user provided socket,
do not send any data to the socket until all existing writes
of the socket are done and ensure registered callbacks of
those writes can be fired.

PR-URL: https://github.com/nodejs/node/pull/48969
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
 2023-08-04 10:14:18 -04:00
Antoine du Hamel 3af7cfe7d4 test: refactor test-node-output-errors 
The main reason is to not have the test fail if the CWD contains some
special URL chars.

PR-URL: https://github.com/nodejs/node/pull/48992
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-08-03 21:52:30 +00:00
Antoine du Hamel a061781da3 test: use fixtures.fileURL when appropriate 
PR-URL: https://github.com/nodejs/node/pull/48990
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-03 21:36:13 +00:00
Raz Luvaton 1353681edf test: remove --no-warnings flag in test_runner fixtures 
no longer needed after #48915 fix

PR-URL: https://github.com/nodejs/node/pull/48989
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-08-03 19:41:20 +00:00
dependabot[bot] f214155c26 meta: bump github/codeql-action from 2.20.1 to 2.21.2 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.20.1 to 2.21.2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/f6e388ebf0efc915c6c5b165b019ee61a6746a38...0ba4244466797eb048eb91a6cd43d5c03ca8bd05)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/48986
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2023-08-03 18:58:14 +00:00
dependabot[bot] f43a38547e meta: bump step-security/harden-runner from 2.4.1 to 2.5.0 
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.4.1 to 2.5.0.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](https://github.com/step-security/harden-runner/compare/55d479fb1c5bcad5a4f9099a5d9f37c8857b2845...cba0d00b1fc9a034e1e642ea0f1103c282990604)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/48985
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2023-08-03 18:58:03 +00:00
dependabot[bot] 293cc9569d meta: bump actions/setup-node from 3.6.0 to 3.7.0 
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.6.0 to 3.7.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c...e33196f7422957bea03ed53f6fbb155025ffc7b8)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/48984
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-08-03 18:57:52 +00:00
dependabot[bot] 6a45055f4f meta: bump actions/setup-python from 4.6.1 to 4.7.0 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.6.1 to 4.7.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/bd6b4b6205c4dbad673328db7b31b7fab9e241c0...61a6322f88396a6271a6ee3565807d608ecaddd1)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/48983
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-08-03 18:57:41 +00:00
Izaak Schroeder 6ad8318373 esm: add initialize hook, integrate with register 
Follows @giltayar's proposed API:

> `register` can pass any data it wants to the loader, which will be
passed to the exported `initialize` function of the loader.
Additionally, if the user of `register` wants to communicate with the
loader, it can just create a `MessageChannel` and pass the port to the
loader as data.

The `register` API is now:

```ts
interface Options {
  parentUrl?: string;
  data?: any;
  transferList?: any[];
}

function register(loader: string, parentUrl?: string): any;
function register(loader: string, options?: Options): any;
```

This API is backwards compatible with the old one (new arguments are
optional and at the end) and allows for passing data into the new
`initialize` hook. If this hook returns data it is passed back to
`register`:

```ts
function initialize(data: any): Promise<any>;
```

**NOTE**: Currently there is no mechanism for a loader to exchange
ownership of something back to the caller.

Refs: https://github.com/nodejs/loaders/issues/147
PR-URL: https://github.com/nodejs/node/pull/48842
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2023-08-03 05:10:59 +00:00
Antoine du Hamel 5c65565108 esm: fix typo parentUrl -> parentURL 
PR-URL: https://github.com/nodejs/node/pull/48999
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-08-02 20:27:39 +00:00
Raz Luvaton c58e8fc31f test_runner: fix global after not failing the tests 
PR-URL: https://github.com/nodejs/node/pull/48913
Fixes: https://github.com/nodejs/node/issues/48867
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-08-02 20:06:25 +00:00
Rafael Gonzaga fb47afc335 doc: drop github actions check in sec release process 
PR-URL: https://github.com/nodejs/node/pull/48978
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-08-02 13:14:28 +00:00
Joyee Cheung 5f2539cd9a src: cast v8::Object::GetInternalField() return value to v8::Value 
In preparation of https://chromium-review.googlesource.com/c/v8/v8/+/4707972
which changes the return value to v8::Data.

PR-URL: https://github.com/nodejs/node/pull/48943
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2023-08-02 02:14:35 +00:00
Antoine du Hamel af4cdcde15 src: do not pass user input to format string 
PR-URL: https://github.com/nodejs/node/pull/48973
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-01 20:05:51 +00:00
Antoine du Hamel ce958d2d78 test: validate error code rather than message 
PR-URL: https://github.com/nodejs/node/pull/48972
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-08-01 19:40:06 +00:00
Node.js GitHub Bot d396a041f7 tools: update eslint to 8.46.0 
PR-URL: https://github.com/nodejs/node/pull/48966
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-08-01 00:45:18 +00:00
Node.js GitHub Bot f169f791a0 tools: update lint-md-dependencies to rollup@3.27.0 
PR-URL: https://github.com/nodejs/node/pull/48965
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-08-01 00:45:06 +00:00
Node.js GitHub Bot 1fea67cbed deps: update googletest to c875c4e 
PR-URL: https://github.com/nodejs/node/pull/48964
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-08-01 00:30:05 +00:00
Raz Luvaton 88094bba3c test_runner: fix timeout in *Each hook failing further tests 
PR-URL: https://github.com/nodejs/node/pull/48925
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-07-31 22:13:02 +00:00
Antoine du Hamel 217abd475f test: fix snapshot tests when cwd contains spaces or backslashes 
Both are valid characters for file names on non-Windows systems.

PR-URL: https://github.com/nodejs/node/pull/48959
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-07-31 21:54:28 +00:00
Gabriel Schulhof eb504c9406 diagnostics_channel: fix last subscriber removal 
When iterating over diagnostics channel subscribers, assume their count
is zero if the list of subscribers becomes undefined, because there may
be only one subscriber which may unsubscribe itself as part of its
onMessage handler.

Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/48933
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
 2023-07-31 10:13:59 -07:00
Antoine du Hamel 97ca9a8961 test: order common.mjs in ASCII order 
PR-URL: https://github.com/nodejs/node/pull/48960
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-07-31 13:09:15 +00:00
Antoine du Hamel 384f5d44a8 test: fix some assumptions in tests 
Some tests are assuming they will be run from a directory that do not
contain any quote or special character in its path. That assumption is
not necessary, using `JSON.stringify` or `pathToFileURL` ensures the
test can be run whatever the path looks like.

PR-URL: https://github.com/nodejs/node/pull/48958
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-07-31 13:09:07 +00:00
Yoshiki Kurihara 1dcfc65097 test: improve internal/worker/io.js coverage 
PR-URL: https://github.com/nodejs/node/pull/42387
Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-07-31 10:01:45 +00:00
Raz Luvaton 7a33f2b88d test_runner: cleanup test timeout abort listener 
fix #48475

PR-URL: https://github.com/nodejs/node/pull/48915
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-07-31 08:10:36 +00:00