Michael Dawson
ac6f594c97
quic: address new coverity warning
...
- address coverity warning about unitialized variable
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/48384
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
2023-06-12 16:01:22 -04:00
Richard Lau
8d651ce81e
crypto: remove OPENSSL_FIPS guard for OpenSSL 3
...
The OPENSSL_FIPS guard is only needed for versions of OpenSSL earlier
than 3.0.
Removing the guard for OpenSSL 3 fixes `parallel/test-crypto-fips`
when run with a FIPS enabled OpenSSL 3 configuration.
PR-URL: https://github.com/nodejs/node/pull/48392
Refs: https://github.com/nodejs/node/issues/48379
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2023-06-12 19:43:22 +00:00
Michael Dawson
1da9099ac9
doc: add additional info on TSFN dispatch
...
Refs: https://github.com/nodejs/node/issues/48356
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/48367
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2023-06-12 14:30:37 -04:00
Michael Dawson
5f32914797
doc: add link for news from security wg
...
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/48396
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2023-06-12 14:18:11 -04:00
Darshan Sen
4e0066eaf8
doc: fix typo in events.md
...
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/48436
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-06-12 16:15:04 +00:00
Congcong Cai
ed92b1fdaf
src: handle wasm out of bound in osx will raise SIGBUS correctly
...
fix : #46559
OSX will raise both SIGBUS and SIGSEGV when out of bound memory visit,
This commit set sigaction in OSX for two signals to handle this.
PR-URL: https://github.com/nodejs/node/pull/46561
Fixes: https://github.com/nodejs/node/issues/46559
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2023-06-12 14:50:21 +00:00
linkgoron
bd7a8087a5
https: fix connection checking interval not clearing on server close
...
The connection interval should close when httpsServer.close is called
similarly to how it gets cleared when httpServer.close is called.
fixes: https://github.com/nodejs/node/issues/48373
PR-URL: https://github.com/nodejs/node/pull/48383
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
2023-06-12 07:47:25 +00:00
João Lenon
a40a6c890a
module: implement register utility
...
PR-URL: https://github.com/nodejs/node/pull/46826
Reviewed-By: Jacob Smith <jacob@frende.me >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-06-12 00:00:46 +00:00
Antoine du Hamel
d2d4a310f1
typings: fix JSDoc in ESM loader modules
...
PR-URL: https://github.com/nodejs/node/pull/48424
Reviewed-By: Jacob Smith <jacob@frende.me >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
2023-06-11 21:09:21 +02:00
Moshe Atlow
c21fe3ad87
test_runner: make --test-name-pattern recursive
...
PR-URL: https://github.com/nodejs/node/pull/48382
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2023-06-11 15:02:18 +00:00
Tobias Nießen
4ee8ef269b
quic: prevent copying ngtcp2_cid_token
...
PR-URL: https://github.com/nodejs/node/pull/48370
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-06-11 10:07:59 +00:00
Debadree Chatterjee
8cc14387a2
lib: fix blob.stream() causing hanging promises
...
Refs: https://github.com/nodejs/node/issues/47993#issuecomment-1546901936
PR-URL: https://github.com/nodejs/node/pull/48232
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2023-06-11 09:24:39 +00:00
Antoine du Hamel
2c6698b4db
lib: add support for inherited custom inspection methods
...
PR-URL: https://github.com/nodejs/node/pull/48306
Fixes: https://github.com/nodejs/node/issues/48207
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-06-11 08:10:47 +00:00
Hemanth HM
0c875bbfc8
repl: display dynamic import variant in static import error messages
...
Enhance the REPL message for static import error message.
```
> import {foo, bar} from 'moo';
import {foo, bar} from 'moo';
^^^^^^
Uncaught:
SyntaxError: .* dynamic import: const {foo,bar} = await import('moo');
```
PR-URL: https://github.com/nodejs/node/pull/48129
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-06-11 08:10:39 +00:00
Joyee Cheung
718f62bfcf
bootstrap: unify snapshot builder and embedder entry points
...
- Run the embedder entry point directly through
runEmbedderEntryPoint(), instead of going through another
JS -> C++ trip through the function returned by
getEmbedderEntryFunction()
- For --build-snapshot, read the snapshot script code directly in C++
and pass it to SnapshotBuilder::Generate(), this makes the entry point
more explicit instead of hiding it in JS land, and also makes it
possible to invoke SnapshotBuilder::Generate() internally to create
a custom snapshot.
- Previously we used process.execPath for the embedder to create
__filename and __dirname in the snapshot builder script while using
process.argv[1] for --build-snapshot (where it's always set) which
results in inconsistencies. We now require the embedder to also set
args[1] when creating the Environment if they intend to run snapshot
scripts with a context that contains __filename and __dirname, which
would be derived from args[1]. If they prefer not to include
build-time paths in the snapshot, we now provide
node::GetAnonymousMainPath() as an alternative.
PR-URL: https://github.com/nodejs/node/pull/48242
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-06-11 00:34:19 +02:00
Sam James
ad0bbaf34a
test: add missing <algorithm> include for std::find
...
GCC 14 drops some transitive includes within libstdc++.
Explicitly include <algorithm> for std::find.
Signed-off-by: Sam James <sam@gentoo.org >
PR-URL: https://github.com/nodejs/node/pull/48380
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com >
2023-06-09 17:29:00 +00:00
Joyee Cheung
4ff55ec2e1
bootstrap: simplify initialization of source map handlers
...
- Move the initialization of process.setSourceMapsEnabled
and the maybeCacheGeneratedSourceMap callback to
bootstrap/node.js so they are included in the snapshot.
- Simplify the handling of --enable-source-maps by explicitly
calling setSourceMapsEnabled() during pre-execution.
PR-URL: https://github.com/nodejs/node/pull/48304
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2023-06-09 15:45:37 +02:00
Joyee Cheung
d102f18957
src: implement constants binding directly
...
Instead of adding a special case for it in the internal binding
loader, just implement it as usual using a per-context property
initializer.
PR-URL: https://github.com/nodejs/node/pull/48186
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2023-06-09 15:32:56 +02:00
Joyee Cheung
e1fa85133f
src: implement natives binding without special casing
...
This patch removes special case in the internal binding loader
for natives, and implements it using the builtins internal
binding. Internally we do not actually need the natives binding,
so implement it as a legacy wrapper instead.
PR-URL: https://github.com/nodejs/node/pull/48186
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2023-06-09 15:32:55 +02:00
Richard Lau
6a3403cded
tools: update create-or-update-pull-request-action
...
Use the same commit SHA for this action as used in our other workflows.
Refs: https://github.com/nodejs/node/pull/46169
Refs: https://github.com/nodejs/node/pull/45022#issuecomment-1290397901
PR-URL: https://github.com/nodejs/node/pull/48398
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2023-06-09 11:54:02 +00:00
Richard Lau
da1c9e3ecb
tools: update eslint-plugin-jsdoc
...
Run a subset of `tools/dep_updaters/update-eslint.sh` to update
`eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when
running the linter.
PR-URL: https://github.com/nodejs/node/pull/48393
Fixes: https://github.com/nodejs/node/issues/48374
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2023-06-09 03:40:02 +00:00
Michaël Zasso
5a58972207
2023-06-08, Version 20.3.0 (Current)
...
Notable changes:
deps:
* upgrade to libuv 1.45.0, including significant performance
improvements to file system operations on Linux (Santiago Gimeno) https://github.com/nodejs/node/pull/48078
doc:
* add Ruy Adorno to list of TSC members (Michael Dawson) https://github.com/nodejs/node/pull/48172
* mark Node.js 14 as End-of-Life (Richard Lau) https://github.com/nodejs/node/pull/48023
lib:
* (SEMVER-MINOR) implement AbortSignal.any() (Chemi Atlow) https://github.com/nodejs/node/pull/47821
module:
* change default resolver to not throw on unknown scheme (Gil Tayar) https://github.com/nodejs/node/pull/47824
node-api:
* (SEMVER-MINOR) define version 9 (Chengzhong Wu) https://github.com/nodejs/node/pull/48151
stream:
* deprecate asIndexedPairs (Chemi Atlow) https://github.com/nodejs/node/pull/48102
PR-URL: https://github.com/nodejs/node/pull/48332
2023-06-08 13:00:26 -03:00
npm CLI robot
8c8e7e9e2c
deps: upgrade npm to 9.7.1
...
PR-URL: https://github.com/nodejs/node/pull/48378
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Luke Karrys <luke@lukekarrys.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2023-06-08 12:24:49 +00:00
Moshe Atlow
9dc2d1b964
test: fix flaky test-watch-mode
...
PR-URL: https://github.com/nodejs/node/pull/48147
Fixes: https://github.com/nodejs/node/issues/44898
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2023-06-08 11:35:14 +00:00
Daniel Lemire
077fd7d83d
src: add missing to_ascii method in dns queries
...
PR-URL: https://github.com/nodejs/node/pull/48354
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
2023-06-07 23:31:22 +00:00
Livia Medeiros
9c5efdd5e2
test: fix test-net-autoselectfamily for kernel without IPv6 support
...
PR-URL: https://github.com/nodejs/node/pull/48265
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-06-07 17:56:28 +00:00
Node.js GitHub Bot
1d1685e6fd
deps: update simdutf to 3.2.14
...
PR-URL: https://github.com/nodejs/node/pull/48344
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2023-06-07 13:39:02 +00:00
Yagiz Nizipli
f2670a61e0
url: conform to origin getter spec changes
...
PR-URL: https://github.com/nodejs/node/pull/48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2023-06-07 11:42:02 +00:00
Yagiz Nizipli
e6e011097e
test: update url web-platform tests
...
PR-URL: https://github.com/nodejs/node/pull/48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2023-06-07 11:42:01 +00:00
Node.js GitHub Bot
11bd9f9224
deps: update ada to 2.5.1
...
PR-URL: https://github.com/nodejs/node/pull/48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2023-06-07 11:42:00 +00:00
Damien Seguin
23c7f65ead
test_runner: refactor coverage report output for readability
...
Add a "table" parameter to getCoverageReport.
Keep the tap coverage output intact.
Change the output by adding padding and truncating the tables' cells.
Add separation lines for table head/body/foot.
Group uncovered lines as ranges.
Add yellow color for coverage between 50 and 90.
Refs: https://github.com/nodejs/node/pull/46674
PR-URL: https://github.com/nodejs/node/pull/47791
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2023-06-07 09:08:27 +00:00
Yagiz Nizipli
72ba09905a
lib: reduce URL invocations on http2 origins
...
PR-URL: https://github.com/nodejs/node/pull/48338
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2023-06-07 02:15:43 +00:00
Yagiz Nizipli
9d936fa250
module: reduce url invocations in esm/load.js
...
PR-URL: https://github.com/nodejs/node/pull/48337
Refs: https://github.com/nodejs/performance/issues/92
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
2023-06-07 01:33:59 +00:00
github-actions[bot]
f100732575
doc: run license-builder
...
PR-URL: https://github.com/nodejs/node/pull/48336
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-06-07 00:29:18 +00:00
Node.js GitHub Bot
a929522375
deps: update zlib to 982b036
...
PR-URL: https://github.com/nodejs/node/pull/48327
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2023-06-06 16:33:41 +00:00
Luigi Pinca
d15652e959
test: ignore the copied entry_point.c
...
Add `test_cannot_run_js/entry_point.c` to
`test/js-native-api/.gitignore`.
PR-URL: https://github.com/nodejs/node/pull/48297
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-06-06 16:22:18 +00:00
Luigi Pinca
f351c8a6c1
test: refactor test-gc-http-client-timeout
...
Due to server response delay, all possible requests are created anyway.
Instead of doing `36 * os.availableParallelism()` requests, use a fixed
number.
Refs: https://github.com/nodejs/node/pull/48078#issuecomment-1568183115
PR-URL: https://github.com/nodejs/node/pull/48292
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
2023-06-06 15:42:42 +00:00
Andrea Fassina
c54115391f
tools: add version update to external dependencies
...
Refs: nodejs/security-wg#973
Most of the duplicated code in all the dependencies updaters
has been moved in the `utils.sh` file
PR-URL: https://github.com/nodejs/node/pull/48081
Refs: https://github.com/nodejs/security-wg/issues/973
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2023-06-06 09:07:34 +00:00
Node.js GitHub Bot
1b4ce6981d
tools: update eslint to 8.42.0
...
PR-URL: https://github.com/nodejs/node/pull/48328
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2023-06-06 02:04:58 +00:00
Luigi Pinca
0919b5e277
tools: disable jsdoc/no-defaults rule
...
PR-URL: https://github.com/nodejs/node/pull/48328
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2023-06-06 02:04:57 +00:00
Yagiz Nizipli
e30e71665c
test: update encoding web-platform tests
...
PR-URL: https://github.com/nodejs/node/pull/48320
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-06-05 22:52:02 +00:00
Yagiz Nizipli
3323528542
test: update FileAPI web-platform tests
...
PR-URL: https://github.com/nodejs/node/pull/48322
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-06-05 19:44:00 +00:00
Filip Skokan
0e92bf1b66
benchmark: refactor crypto oneshot
...
PR-URL: https://github.com/nodejs/node/pull/48267
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2023-06-05 19:00:41 +00:00
Michael Dawson
41f8abc6b5
build: update action to close stale PRs
...
My original plan of adding a lable to limit those initially
process as outlined in https://github.com/nodejs/node/pull/48051
does not work I think because adding a lable updates the last
update time.
- Removing the need for the lable
- Remove the cron scheduling so that it only runs when I run it manually
- Fix the display name for the action as I missed updating that after
cut and paste from existing action
The plan will be to find stop dates that should only affect a reasonable
number of PRs at a time and then run in batches using that instead.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/48196
Reviewed-By: Mestery <mestery@protonmail.com >
2023-06-05 14:54:00 -04:00
Yagiz Nizipli
7f9fd76f25
test: update user-timing web-platform tests
...
PR-URL: https://github.com/nodejs/node/pull/48321
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2023-06-05 18:04:35 +00:00
Filip Skokan
6327d4582a
benchmark: add crypto.create*Key
...
PR-URL: https://github.com/nodejs/node/pull/48284
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-06-05 16:45:47 +00:00
Antoine du Hamel
9f3466bcb6
esm: remove support for arrays in import internal method
...
This avoids initializing arrays that we never use, and simplifies the
implementation overall.
PR-URL: https://github.com/nodejs/node/pull/48296
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-06-05 08:32:33 +00:00
Moshe Atlow
5c27cc2afb
test_runner: apply runOnly on suites
...
PR-URL: https://github.com/nodejs/node/pull/48279
Fixes: https://github.com/nodejs/node/issues/47937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2023-06-05 00:05:34 +03:00
Moshe Atlow
c6e7e42733
test: mark test-child-process-pipe-dataflow as flaky
...
PR-URL: https://github.com/nodejs/node/pull/48334
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-06-04 20:58:45 +00:00
Node.js GitHub Bot
cd6bd3f0fb
tools: update rollup lint-md-dependencies
...
- @rollup/plugin-node-resolve@15.1.0
- rollup@3.23 .0
PR-URL: https://github.com/nodejs/node/pull/48329
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-06-04 10:46:29 +02:00