BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
40,720 Commits 266 Branches 972 Tags
079c3460cdc72da170cc912642302855257bcda8
Commit Graph
40720 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Marco Ippolito f858dc5b5b tools: add debug logs 
PR-URL: https://github.com/nodejs/node/pull/48060
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-22 08:22:10 +00:00
Rich Trott c7fe303eaf doc: update SEA source link 
The code was moved in 3803b028d so the current source link is broken
in our docs.

PR-URL: https://github.com/nodejs/node/pull/48080
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-05-21 18:10:07 +00:00
Luigi Pinca 95d24292ed tools: fix zconf.h path 
Use the `DEPS_DIR` variable to build the path instead of hardcoding it.

PR-URL: https://github.com/nodejs/node/pull/48089
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2023-05-21 16:58:01 +00:00
Roberto Vidal cd7e4e8e66 doc: clarify tty.isRaw 
PR-URL: https://github.com/nodejs/node/pull/48055
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-05-21 16:41:28 +00:00
Alex Schwartz e49bb6851c doc: correct line break for Windows terminals 
PR-URL: https://github.com/nodejs/node/pull/48083
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
 2023-05-21 09:05:16 -07:00
Filip Skokan 6439f683ee test: ignore helper files in WPTs 
PR-URL: https://github.com/nodejs/node/pull/48079
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-21 13:55:33 +00:00
Antoine du Hamel 30870d126b doc: fix Windows code snippet tags 
Those were wrongly marked as `bash`, when the text around it was
referencing PowerShell or Command Prompt.

PR-URL: https://github.com/nodejs/node/pull/48100
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
 2023-05-21 11:27:16 +00:00
Antoine du Hamel 260092eca3 doc: harmonize fenced code snippet flags 
We had a few code snippets that were using a non-descriptive tag (e.g.
`console` or `text`), whereas the actual language it's using describes
it better, and improves the syntax highlighting. This commit also
removes non-necessary leading chars (e.g. `$`, `>`, or `%`) to make it
easier for readers to copy and paste to try the command themselves.

PR-URL: https://github.com/nodejs/node/pull/48082
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-21 09:36:57 +02:00
Node.js GitHub Bot 66fbe7fb23 deps,test: update postject to 1.0.0-alpha.6 
PR-URL: https://github.com/nodejs/node/pull/48072
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-05-21 07:26:36 +00:00
Gabriel Schulhof 19fa9f1bc4 node-api: add status napi_cannot_run_js 
Add the new status in order to distinguish a state wherein an exception
is pending from one wherein the engine is unable to execute JS. We take
advantage of the new runtime add-on version reporting in order to remain
forward compatible with add-ons that do not expect the new status code.

PR-URL: https://github.com/nodejs/node/pull/47986
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
 2023-05-20 07:39:12 -07:00
Tobias Nießen 85ac915045 doc: use secure key length for HMAC generateKey 
The examples for generateKey() and generateKeySync() generate 64-bit
HMAC keys. That is inadequate for virtually any HMAC instance. As per
common NIST recommendations, the minimum should be roughly 112 bits, or
more commonly 128 bits.

Due to the design of HMAC itself, it is not unreasonable to choose the
underlying hash function's block size as the key length. For many
popular hash functions (SHA-256, SHA-224, SHA-1, MD5, ...) this happens
to be 64 bytes (bytes, not bits!). This is consistent with the HMAC
implementation in .NET, for example, even though it provides virtually
no benefit over a 256-bit key.

PR-URL: https://github.com/nodejs/node/pull/48052
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-19 23:58:58 +00:00
Node.js GitHub Bot 9772065231 deps: update uvwasi to 0.0.18 
PR-URL: https://github.com/nodejs/node/pull/47866
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2023-05-19 21:26:26 +00:00
Node.js GitHub Bot c1d496a662 deps: update uvwasi to 0.0.17 
PR-URL: https://github.com/nodejs/node/pull/47866
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2023-05-19 21:26:25 +00:00
Rich Trott 39595513c5 doc: update broken EVP_BytesToKey link 
PR-URL: https://github.com/nodejs/node/pull/48064
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2023-05-19 17:19:07 +00:00
Rich Trott 273c4227dc doc: update broken spkac link 
PR-URL: https://github.com/nodejs/node/pull/48063
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-05-19 17:18:58 +00:00
Gil Tayar ccada8bccc module: change default resolver to not throw on unknown scheme 
Fixes https://github.com/nodejs/loaders/issues/138

PR-URL: https://github.com/nodejs/node/pull/47824
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-05-19 15:50:50 +00:00
npm CLI robot adcbfcec60 deps: upgrade npm to 9.6.7 
PR-URL: https://github.com/nodejs/node/pull/48062
Reviewed-By: Luke Karrys <luke@lukekarrys.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-19 13:45:02 +00:00
Chengzhong Wu 1918241190 doc: document node-api version process 
PR-URL: https://github.com/nodejs/node/pull/47972
Fixes: https://github.com/nodejs/node/issues/47664
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
 2023-05-19 02:21:10 +00:00
Robin Ury 67b892ef9e url: clean vertical alignment of docs 
PR-URL: https://github.com/nodejs/node/pull/48037
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-18 20:03:27 +00:00
Vladimir Morozov 0063669cce node-api: napi_ref on all types is experimental 
PR-URL: https://github.com/nodejs/node/pull/47975
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-05-18 15:51:59 -04:00
Yagiz Nizipli 8b6947fac1 url: call ada::can_parse directly 
PR-URL: https://github.com/nodejs/node/pull/47919
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-05-18 17:49:02 +00:00
GauriSpears 10b21e5685 crypto: use openssl's own memory BIOs in crypto_context.cc 
NodeBIO's memory buffer structure does not support BIO_C_FILE_SEEK and B
IO_C_FILE_TELL. This prevents OpenSSL PEM_read_bio_PrivateKey from readi
ng some private keys. So I switched to OpenSSL'w own protected memory bu
ffers.

Fixes: https://github.com/nodejs/node/issues/47008
PR-URL: https://github.com/nodejs/node/pull/47160
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2023-05-18 16:28:44 +00:00
Node.js GitHub Bot 3538e1bcde deps: update nghttp2 to 1.53.0 
PR-URL: https://github.com/nodejs/node/pull/47997
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2023-05-18 13:59:03 +00:00
Moshe Atlow 05693acb15 lib: support FORCE_COLOR for non TTY streams 
PR-URL: https://github.com/nodejs/node/pull/48034
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-05-18 12:36:38 +00:00
Shrujal Shah c18a455542 meta: remove dont-land-on-v14 auto labeling 
PR-URL: https://github.com/nodejs/node/pull/48031
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-18 10:31:01 +00:00
Chemi Atlow cd016a08c1 lib: implement AbortSignal.any() 
PR-URL: https://github.com/nodejs/node/pull/47821
Fixes: https://github.com/nodejs/node/issues/47811
Refs: https://github.com/whatwg/dom/pull/1152
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-05-18 08:11:07 +00:00
Yagiz Nizipli 62fd6bc4aa test: move test-cluster-primary-error flaky test 
PR-URL: https://github.com/nodejs/node/pull/48039
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
 2023-05-17 13:26:05 +00:00
Saba Kharanauli 1fdcb1c8c1 doc: update process.versions properties 
Fixes: https://github.com/nodejs/node/issues/48016
PR-URL: https://github.com/nodejs/node/pull/48019
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-17 12:53:32 +00:00
Benjamin Gruenbaum 3cf05be50e test: fix suite signal 
PR-URL: https://github.com/nodejs/node/pull/47800
Fixes: https://github.com/nodejs/node/issues/47882
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-05-17 08:57:21 +00:00
Daeyeon Jeong 5cb5422b6f test: fix parsing test flags 
This removes replacing `_` with `-` in the flags defined.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/48012
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-17 06:24:07 +00:00
Deokjin Kim ca096563e0 benchmark: use cluster.isPrimary instead of cluster.isMaster 
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary`
for benchmark.

Refs: https://github.com/nodejs/node/pull/47981
PR-URL: https://github.com/nodejs/node/pull/48002
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-17 05:51:53 +00:00
Node.js GitHub Bot 6774144404 tools: update remark-preset-lint-node to 4.0.0 
PR-URL: https://github.com/nodejs/node/pull/47995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-05-17 05:05:53 +00:00
Node.js GitHub Bot 326c30f27c meta: move one or more collaborators to emeritus 
PR-URL: https://github.com/nodejs/node/pull/48010
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-17 04:23:04 +00:00
Node.js GitHub Bot 506888dc41 deps: update ada to 2.4.1 
PR-URL: https://github.com/nodejs/node/pull/48036
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-05-17 00:28:24 +00:00
Shi Pujin a51491ab24 deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64 
PR-URL: https://github.com/nodejs/node/pull/46401
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-05-16 14:37:03 -04:00
Node.js GitHub Bot 7a57d1fb94 deps: update undici to 5.22.1 
PR-URL: https://github.com/nodejs/node/pull/47994
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
 2023-05-16 16:36:34 +00:00
Deokjin Kim d2c4518ce6 doc: fix typo in binding functions 
According to usage(node::util::RegisterExternalReferences) of
below line, namespace has to be `util`(not `utils`).

PR-URL: https://github.com/nodejs/node/pull/48003
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-16 14:26:17 +00:00
Michaël Zasso c2ca4290f6 2023-05-16, Version 20.2.0 (Current) 
Notable changes:

doc:
  * add ovflowd to collaborators (Claudio Wunder) https://github.com/nodejs/node/pull/47844
http:
  * (SEMVER-MINOR) prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) https://github.com/nodejs/node/pull/47732
sea:
  * (SEMVER-MINOR) add option to disable the experimental SEA warning (Darshan Sen) https://github.com/nodejs/node/pull/47588
test_runner:
  * (SEMVER-MINOR) add `skip`, `todo`, and `only` shorthands to `test` (Chemi Atlow) https://github.com/nodejs/node/pull/47909
url:
  * (SEMVER-MINOR) add value argument to `URLSearchParams` `has` and `delete` methods (Sankalp Shubham) https://github.com/nodejs/node/pull/47885

PR-URL: https://github.com/nodejs/node/pull/48020
 2023-05-16 14:40:46 +02:00
Richard Lau fb6afb5c67 doc: mark Node.js 14 as End-of-Life 
PR-URL: https://github.com/nodejs/node/pull/48023
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-05-16 11:20:08 +00:00
Tobias Nießen 32691bdf7d doc: clarify CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED 
The error is not necessarily due to a client certificate engine. For
example, the `privateKeyEngine` option might just as well cause this
error and is independent of the client certificate.

Also mention that this is likely due to a compile-time option of OpenSSL
itself and not due to any particular engine.

PR-URL: https://github.com/nodejs/node/pull/47976
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2023-05-16 09:32:17 +00:00
Tobias Nießen f36461dc6a crypto: remove default encoding from cipher 
Refs: https://github.com/nodejs/node/pull/47182
PR-URL: https://github.com/nodejs/node/pull/47998
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-16 01:22:33 +00:00
Tobias Nießen 29780bd666 doc: add heading for permission model limitations 
These limitations are not specific to the file system, so they should
not be listed in the "File System Permissions" section.

PR-URL: https://github.com/nodejs/node/pull/47989
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-05-15 17:41:29 +00:00
Tobias Nießen 5b4c7bd78f crypto: fix setEngine() when OPENSSL_NO_ENGINE set 
When OpenSSL is configured with OPENSSL_NO_ENGINE, setEngine() currently
throws an internal error because the C++ binding does not export the
relevant function, which causes _setEngine() to be undefined within JS.

Instead, match the behavior of tls/secure-context.js and throw the
existing error code ERR_CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED when OpenSSL
has been configured with OPENSSL_NO_ENGINE.

PR-URL: https://github.com/nodejs/node/pull/47977
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-05-15 15:39:11 +00:00
Moshe Atlow 7116bc08d7 test_runner: use v8.serialize instead of TAP 
PR-URL: https://github.com/nodejs/node/pull/47867
Fixes: https://github.com/nodejs/node/issues/44656
Fixes: https://github.com/nodejs/node/issues/47955
Fixes: https://github.com/nodejs/node/issues/47481
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-05-15 14:27:45 +00:00
Deokjin Kim 8cbc307c44 permission: remove unused function declaration 
RestrictAccess() is declared, but it's not used.

PR-URL: https://github.com/nodejs/node/pull/47957
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
 2023-05-15 14:18:07 +00:00
Tobias Nießen 93a19961a6 src: deduplicate X509Certificate::Fingerprint* 
All three functions do the same, except using different cryptographic
hash functions. Move the common logic into a new template and use it
directly.

PR-URL: https://github.com/nodejs/node/pull/47978
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2023-05-15 12:49:00 +00:00
Tobias Nießen 92d3611fca test: mark test-esm-loader-http-imports as flaky 
This test has been failing occasionally for weeks.

Refs: https://github.com/nodejs/node/issues/47836
Refs: https://github.com/nodejs/reliability/issues/564
PR-URL: https://github.com/nodejs/node/pull/47987
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-05-15 10:54:20 +00:00
Feng Yu 6bbf2a57fc vm: fix crash when setting __proto__ on context's globalThis 
PR-URL: https://github.com/nodejs/node/pull/47939
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2023-05-15 09:24:15 +00:00
Chemi Atlow 8b3777d0c8 test_runner: add shorthands to test 
PR-URL: https://github.com/nodejs/node/pull/47909
Fixes: https://github.com/nodejs/node/issues/47897
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-05-15 05:23:22 +00:00
Keyhan Vakil 3ef17b6356 src: stop copying code cache, part 2 
This removes more copies of the code cache data.

First: for the builtin snapshot, we were copying the code cache to
create a `std::vector<uint8_t>`. This was slowing down static
intialization. Change it to use a good old `uint8_t*` and `size_t`
rather than a vector. For the case of embedder provided snapshots, we
also add an `owning_ptr` so that we can properly cleanup owned values
created from the snapshot.

Second: whenever the code cache was hit, we would remove the bytecode
from the code cache, and then reserialize it from the compiled function.
This was pretty slow. Change the code so that we can reuse the same code
cache multiple times. If the code cache is rejected (say, because the
user added V8 options), then we need to generate the bytecode, in which
case we again use `owning_ptr` to ensure that the underlying code cache
is freed.

Combined, these changes improve the misc/startup.js benchmarks
significantly (p < 0.001):

* process,benchmark/fixtures/require-builtins: 22.15%
* process,test/fixtures/semicolon: 8.55%
* worker,benchmark/fixtures/require-builtins: 26.52%
* worker,test/fixtures/semicolon: 21.52%

PR-URL: https://github.com/nodejs/node/pull/47958
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2023-05-15 04:37:24 +00:00