Mohammed Keyvanzadeh
d2156f1bf0
build: use pathlib for paths
...
Use Python's `pathlib` library for paths and related operations
instead of `os.path`.
Refs: https://github.com/nodejs/node/pull/47323#discussion_r1163799518 https://github.com/nodejs/node/pull/47323#issuecomment-1510350194
PR-URL: https://github.com/nodejs/node/pull/47581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Christian Clauss <cclauss@me.com >
2023-05-02 19:20:22 +00:00
Marco Ippolito
109ab0a89c
doc: create maintaining folder for deps
...
PR-URL: https://github.com/nodejs/node/pull/47589
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2023-05-02 17:03:23 +00:00
Mestery
ab434d2327
meta: fix dependabot commit message
...
PR-URL: https://github.com/nodejs/node/pull/47810
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2023-05-02 11:52:52 +00:00
Node.js GitHub Bot
32778b8d0e
tools: update eslint to 8.39.0
...
PR-URL: https://github.com/nodejs/node/pull/47789
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2023-05-02 00:48:22 +00:00
Moshe Atlow
9658d84ddd
tools: fix jsdoc lint
...
PR-URL: https://github.com/nodejs/node/pull/47789
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2023-05-02 00:48:20 +00:00
Node.js GitHub Bot
8587e3b369
tools: update doc to highlight.js@11.8.0
...
PR-URL: https://github.com/nodejs/node/pull/47786
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2023-05-02 00:48:08 +00:00
Tobias Nießen
798db3c92a
doc: fix --allow-* CLI flag references
...
PR-URL: https://github.com/nodejs/node/pull/47804
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2023-05-01 22:24:33 +00:00
Tobias Nießen
3a3672ba6c
doc: clarify fs permissions only affect fs module
...
As far as I can tell, the permission model implementation currently
does not restrict all file system operations but only those through
the fs module. WASI, for example, bypasses the permission model
entirely.
PR-URL: https://github.com/nodejs/node/pull/47782
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2023-05-01 16:19:48 +00:00
Tobias Nießen
609d2b0ff2
test: add and use tmpdir.hasEnoughSpace()
...
In general, we assume that the tmpdir will provide sufficient space for
most tests. Some tests, however, require hundreds of megabytes or even
gigabytes of space, which often causes them to fail, especially on our
macOS infrastructure. The most recent reliability report contains more
than 20 related CI failures.
This change adds a new function hasEnoughSpace() to the tmpdir module
that uses statfsSync() to guess whether allocating a certain amount of
space within the temporary directory will succeed.
This change also updates the most frequently failing tests to use the
new function such that the relevant parts of the tests are skipped if
tmpdir has insufficient space.
Refs: https://github.com/nodejs/reliability/issues/549
PR-URL: https://github.com/nodejs/node/pull/47767
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Richard Lau <rlau@redhat.com >
2023-05-01 15:23:49 +00:00
XLor
d225d95758
doc: add copy node executable guide on windows
...
PR-URL: https://github.com/nodejs/node/pull/47781
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
2023-05-01 17:41:02 +05:30
Sun Haiyong
aa6600df58
tools: add the missing LoongArch64 definition in the v8.gyp file
...
PR-URL: https://github.com/nodejs/node/pull/47641
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2023-05-01 13:26:23 +02:00
Michaël Zasso
2a165505b7
deps: disable V8 concurrent sparkplug compilation
...
It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.
Refs: https://github.com/nodejs/node/issues/47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: https://github.com/nodejs/node/pull/47450
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-05-01 12:40:30 +02:00
Mohammed Keyvanzadeh
a4cf6b204f
build: refactor configure.py
...
- Explicitly specify the encoding when opening files.
- Use f-strings to format strings.
- Use `isinstance()` for type checks instead of `type()`.
- Use the `with` keyword for resource-allocating operations.
- Avoid using multiple statements in a single line.
- Remove unnecessary `else` clauses after `return`.
- Iterate with the `items()` method of dictionaries when both the key
and value are used.
- Remove unnecessary parentheses.
- Rename unused unpacked variables to `_`, `_1`, etc etc.
- Rename the `list` variable to avoid conflict with the global
`list()` function.
PR-URL: https://github.com/nodejs/node/pull/47667
Reviewed-By: Christian Clauss <cclauss@me.com >
2023-05-01 09:13:16 +00:00
Rafael Gonzaga
b5fe45fb9a
benchmark: add eventtarget creation bench
...
PR-URL: https://github.com/nodejs/node/pull/47774
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2023-04-30 21:09:56 +00:00
Moshe Atlow
33c71be8a3
doc: remove MoLow from Triagers
...
PR-URL: https://github.com/nodejs/node/pull/47792
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2023-04-30 19:31:58 +00:00
Joyee Cheung
9c17b903c6
meta: ping nodejs/startup for startup test changes
...
PR-URL: https://github.com/nodejs/node/pull/47771
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2023-04-30 17:35:21 +00:00
Yagiz Nizipli
6827dbbfde
url: reduce revokeObjectURL cpp calls
...
PR-URL: https://github.com/nodejs/node/pull/47728
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
2023-04-30 12:38:32 +00:00
Node.js GitHub Bot
0a3f6a9d07
tools: update lint-md-dependencies to rollup@3.21.1
...
PR-URL: https://github.com/nodejs/node/pull/47787
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2023-04-30 04:20:45 +00:00
Moshe Atlow
1300ed0b16
test_runner: fix --require with --experimental-loader
...
PR-URL: https://github.com/nodejs/node/pull/47751
Reviewed-By: Jacob Smith <jacob@frende.me >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-04-29 23:02:03 +00:00
Chengzhong Wu
bddf341774
v8: fix ERR_NOT_BUILDING_SNAPSHOT is not a constructor
...
PR-URL: https://github.com/nodejs/node/pull/47721
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2023-04-29 16:50:42 +00:00
Yagiz Nizipli
4c62042774
src: avoid copying string in fs_permission
...
PR-URL: https://github.com/nodejs/node/pull/47746
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2023-04-29 14:04:57 +00:00
Moshe Atlow
adf332be32
assert: deprecate callTracker
...
PR-URL: https://github.com/nodejs/node/pull/47740
Fixes: https://github.com/nodejs/node/issues/47492
Reviewed-By: Erick Wendel <erick.workspace@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-04-29 06:57:08 +00:00
Christian Takle
c968361829
doc: fix typo in webstreams.md
...
PR-URL: https://github.com/nodejs/node/pull/47766
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2023-04-28 22:53:28 +00:00
Rich Trott
22ec1ddb86
doc: move BethGriggs to regular member
...
PR-URL: https://github.com/nodejs/node/pull/47776
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com >
2023-04-28 22:45:33 +00:00
Richard Lau
212821afdd
deps: V8: cherry-pick c5ab3e4f0c5a
...
Original commit message:
libstdc++: fix incomplete type in v8::internal::is_subtype<T, U>
Using std::convertible with incomplete types is UB. However, till
GCC 12 it was accepted and std::convertible returned false.
This fails now for e.g. v8::internal::WasmArray. Use
std::disjunction and std::conjunction instead which are short-
circuiting, because std::is_base_of<T, T> is already true.
Bug: chromium:957519
Change-Id: Ia26643dbdf0fb00d5586c71ae6b18e8d0f3cf96e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4394663
Commit-Queue: Stephan Hartmann <stha09@googlemail.com >
Reviewed-by: Clemens Backes <clemensb@chromium.org >
Cr-Commit-Position: refs/heads/main@{#86904}
Refs: https://github.com/v8/v8/commit/c5ab3e4f0c5a3ce880941184ef8447c27cd19a93
PR-URL: https://github.com/nodejs/node/pull/47736
Fixes: https://github.com/nodejs/node/issues/47623
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2023-04-28 19:58:09 +00:00
Yagiz Nizipli and Daniel Lemire
1123377791
src: replace idna functions with ada::idna
...
Co-authored-by: Daniel Lemire <daniel@lemire.me >
PR-URL: https://github.com/nodejs/node/pull/47735
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
2023-04-28 18:48:38 +00:00
Tobias Nießen
1baf96aeb8
doc,test: fix concurrency option of test()
...
The documentation appears to still be wrong w.r.t. the meaning of the
concurrency option of the test() function. The implementation appears to
default to Infinity when the option is set to true. Is that intended or
a good idea? I don't know. It certainly makes more sense than what the
documentation says (which is basing the number of concurrent tasks
within a single thread on the number of CPU cores).
This changes the documentation to hopefully match the implementation and
adds a test that rules out the (rather arbitrary) behavior described in
the documentation.
Refs: https://github.com/nodejs/node/issues/47365
Refs: https://github.com/nodejs/node/pull/47642
PR-URL: https://github.com/nodejs/node/pull/47734
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-04-28 18:32:08 +00:00
cjihrig
b31d587dc8
test_runner: support combining coverage reports
...
This commit adds support for combining code coverage reports
in the test runner. This allows coverage to be collected for
child processes, and by extension, the test runner CLI.
PR-URL: https://github.com/nodejs/node/pull/47686
Fixes: https://github.com/nodejs/node/issues/47669
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2023-04-28 13:13:53 +00:00
Xuguang Mei
a75959b1bc
doc: mark signing the binary is macOS and Windows only in SEA
...
PR-URL: https://github.com/nodejs/node/pull/47722
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Qingyu Deng <i@ayase-lab.com >
2023-04-28 09:02:55 +00:00
Anna Henningsen
e47d5723ff
doc: move addaleax to TSC emeriti
...
PR-URL: https://github.com/nodejs/node/pull/47752
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-04-27 23:15:30 -07:00
Tobias Nießen
7ae1360358
src: fix typo in comment in quic/sessionticket.cc
...
PR-URL: https://github.com/nodejs/node/pull/47754
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com >
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com >
2023-04-28 04:28:55 +00:00
Michael Dawson
e8cfa95a17
doc: add link to news for Node.js core
...
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/47704
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2023-04-27 16:22:18 +00:00
Tobias Nießen
36e4e3d86b
test: remove spaces from test runner test names
...
PR-URL: https://github.com/nodejs/node/pull/47733
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com >
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com >
2023-04-27 08:58:01 +00:00
Chengzhong Wu
6700aac615
src: mark fatal error functions as noreturn
...
OnFatalError and OOMErrorHandler will not return control flow to the
calling function.
node::FatalError is an alias of node::OnFatalError. Replace all the
callsites with node::OnFatalError instead.
PR-URL: https://github.com/nodejs/node/pull/47695
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
2023-04-27 08:57:52 +00:00
Debadree Chatterjee
f34a07d3a7
stream: prevent pipeline hang with generator functions
...
Fixes: https://github.com/nodejs/node/issues/47708
PR-URL: https://github.com/nodejs/node/pull/47712
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Feng Yu <F3n67u@outlook.com >
2023-04-27 07:44:39 +00:00
Moshe Atlow
b6738c1af0
test: migrate message tests to use assertSnapshot
...
PR-URL: https://github.com/nodejs/node/pull/47498
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2023-04-27 06:41:58 +00:00
Node.js GitHub Bot
8b66dc6ea9
deps: update ada to 2.3.0
...
PR-URL: https://github.com/nodejs/node/pull/47737
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-04-27 02:56:12 +00:00
Daeyeon Jeong
ece3565893
doc: fix a typo in permissions.md
...
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/47730
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-04-26 18:34:52 +00:00
Marco Ippolito
e2e3f5c9da
tools: move update-npm to dep updaters
...
PR-URL: https://github.com/nodejs/node/pull/47619
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2023-04-26 14:10:29 +00:00
Marco Ippolito
ad5a0d1366
tools: fix update-v8-patch cache
...
PR-URL: https://github.com/nodejs/node/pull/47725
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2023-04-26 13:43:16 +00:00
James M Snell
76044c4e2b
quic: add additional QUIC implementation
...
Adds most of the Endpoint implementation with a few tweaks to
other bits.
PR-URL: https://github.com/nodejs/node/pull/47603
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2023-04-26 13:27:04 +00:00
btea
2ac5e9889a
dns: expose getDefaultResultOrder
...
PR-URL: https://github.com/nodejs/node/pull/46973
Fixes: https://github.com/nodejs/node/issues/46919
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
2023-04-26 08:56:04 +00:00
Marco Ippolito
71a776b928
tools: automate v8 patch update
...
PR-URL: https://github.com/nodejs/node/pull/47594
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2023-04-26 08:20:23 +00:00
HinataKah0
b54504c1d5
tls: accept SecureContext object in server.addContext()
...
Do not call tls.createSecureContext() if the context provided
is already an instance of tls.SecureContext.
Fixes: https://github.com/nodejs/node/issues/47408
PR-URL: https://github.com/nodejs/node/pull/47570
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-04-26 06:39:00 +00:00
Gabriel Schulhof
11f97d4603
node-api: test passing NULL to napi_define_class
...
PR-URL: https://github.com/nodejs/node/pull/47567
Reviewed-By: Michael Dawson <midawson@redhat.com >
2023-04-26 06:38:51 +00:00
btea
2fa721f088
doc: async_hooks asynchronous content example add mjs code
...
PR-URL: https://github.com/nodejs/node/pull/47401
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-04-26 06:18:42 +00:00
Joyee Cheung
2e44a14cfb
src: split BlobSerializer/BlobDeserializer
...
This patch splits BlobSerializer and BlobDeserializer out of
SnapshotSerializer and SnapshotDeserializer. The child classes
can implement serialization methods for custom types on top
of BlobSerializer/BlobDeserializer for conversions between
native types and binary blobs. This allows us to reuse the
classes for other cases (e.g. SEA blobs).
PR-URL: https://github.com/nodejs/node/pull/47458
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2023-04-26 00:34:49 +02:00
cjihrig
ab3a54f2ee
test_runner: remove no-op validation
...
The code already checks if testNamePatterns is an
array, and converts it to an array if it is not.
PR-URL: https://github.com/nodejs/node/pull/47687
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com >
2023-04-25 16:03:51 +00:00
Filip Skokan
a5ce18f9e0
test: refactor WPTRunner and enable parallel WPT execution
...
PR-URL: https://github.com/nodejs/node/pull/47635
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-04-25 11:45:54 +00:00
Shelley Vohr
146b613941
src: prevent changing FunctionTemplateInfo after publish
...
Refs https://chromium-review.googlesource.com/c/v8/v8/+/2718147
Fixes an issue where Node.js tries to call SetClassName on a
FunctionTemplate twice in some cases. The above CL made it so that
V8 CHECKs when this occurs. It is fixed by ensuring SetClassName
is only called once.
PR-URL: https://github.com/nodejs/node/pull/46979
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-04-25 09:12:45 +00:00