Commit Graph
40720 Commits
Author SHA1 Message Date
Joyee Cheung 77561d0e41 bootstrap: support namespaced builtins in snapshot scripts
PR-URL: https://github.com/nodejs/node/pull/47467
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2023-04-11 17:55:41 +00:00
Khafra 70d81bb8f7 doc: add KhafraDev to collaborators
Fixes: https://github.com/nodejs/node/issues/47388
PR-URL: https://github.com/nodejs/node/pull/47510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
2023-04-11 10:29:27 -04:00
Marco Ippolito 4899998d0d tools: move update-undici.sh to dep_updaters and create maintain md
PR-URL: https://github.com/nodejs/node/pull/47380
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-04-11 13:19:14 +00:00
Marco Ippolito 76dfb77816 doc: create maintaining-brotli.md
PR-URL: https://github.com/nodejs/node/pull/47380
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-04-11 13:19:14 +00:00
Michaël Zasso 25ad49bb07 src: use correct variable in node_builtins.cc
PR-URL: https://github.com/nodejs/node/pull/47343
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2023-04-11 10:33:49 +00:00
lilsweetcaligula 97d3912eb8 src: slim down stream_base-inl.h
PR-URL: https://github.com/nodejs/node/pull/46972
Refs: https://github.com/nodejs/node/issues/43712
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
2023-04-11 05:52:27 +00:00
Node.js GitHub Bot 17d024ba69 deps: update undici to 5.21.1
PR-URL: https://github.com/nodejs/node/pull/47488
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-04-11 02:03:42 +00:00
RafaelGSS c8f6f851f9 2023-04-10, Version 19.9.0 (Current)
Notable changes:

events:
  * (SEMVER-MINOR) add getMaxListeners method (Khafra) https://github.com/nodejs/node/pull/47039
lib:
  * (SEMVER-MINOR) add tracing channel to diagnostics\_channel (Stephen Belanger)
msi:
  * (SEMVER-MINOR) migrate to WiX4 (Stefan Stojanovic) https://github.com/nodejs/node/pull/45943
node-api:
  * (SEMVER-MINOR) deprecate napi\_module\_register (Vladimir Morozov) https://github.com/nodejs/node/pull/46319
stream:
  * (SEMVER-MINOR) add setter & getter for default highWaterMark (Robert Nagy) https://github.com/nodejs/node/pull/46929
url:
  * (SEMVER-MINOR) implement URL.canParse (Khafra) https://github.com/nodejs/node/pull/47179
test_runner:
  * (SEMVER-MINOR) expose reporter for use in run api (Chemi Atlow) https://github.com/nodejs/node/pull/47238

PR-URL: https://github.com/nodejs/node/pull/47441
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
2023-04-10 21:10:55 -03:00
Cheng Zhao 3a98dd338f tools: make js2c.py usable for other build systems
PR-URL: https://github.com/nodejs/node/pull/46930
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2023-04-10 22:11:22 +02:00
Marco Ippolito c2b54fb900 tools: move update-acorn.sh to dep_updaters and create maintaining md
PR-URL: https://github.com/nodejs/node/pull/47382
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-04-10 19:38:08 +00:00
Rafael Gonzaga 9d9cf11a4b meta: ping security-wg team on permission model changes
PR-URL: https://github.com/nodejs/node/pull/47483
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2023-04-10 17:59:15 +00:00
Node.js GitHub Bot fdee40e686 deps: update simdutf to 3.2.7
PR-URL: https://github.com/nodejs/node/pull/47473
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-04-10 17:57:10 +00:00
Yagiz Nizipli 08e1564474 test: mark test/parallel/test-file-write-stream4 as flaky
PR-URL: https://github.com/nodejs/node/pull/47423
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-04-10 17:46:07 +00:00
angellovc e301ba40d0 test: remove unused callback variables
Unused variables were removed from stream-exception test.

PR-URL: https://github.com/nodejs/node/pull/47167
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
2023-04-10 10:41:26 -07:00
Joyee Cheung 209c803569 bootstrap: do not expand process.argv[1] for snapshot entry points
In applications with entry points deserialized from snapshots,
they don't need an additional CLI argument for the entry point script
so process.argv[1] is going to be other user-defiend arguments.
We could consider copying process.argv[0] as process.argv[1] like
what we do for single executable applications, but for now just
don't exapnd it so it's easier to backport to previous releases.

PR-URL: https://github.com/nodejs/node/pull/47466
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2023-04-10 16:15:03 +00:00
Debadree Chatterjee a9c3d9244f fs: implement byob mode for readableWebStream()
Fixes: https://github.com/nodejs/node/issues/45853
PR-URL: https://github.com/nodejs/node/pull/46933
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2023-04-10 07:19:19 +00:00
Node.js GitHub Bot a57b8ddd9a tools: update eslint to 8.38.0
PR-URL: https://github.com/nodejs/node/pull/47475
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2023-04-10 06:11:49 +00:00
Node.js GitHub Bot 270e24f0f7 tools: update eslint to 8.38.0
PR-URL: https://github.com/nodejs/node/pull/47475
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2023-04-10 06:11:48 +00:00
James M Snell 2d1934aa96 quic: add more QUIC impl
* add BindingData
* add LogStream
* add TransportParams

PR-URL: https://github.com/nodejs/node/pull/47348
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
2023-04-09 19:37:33 -07:00
Moshe Atlow 57508fb411 test: migrate test runner message tests to snapshot
PR-URL: https://github.com/nodejs/node/pull/47392
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2023-04-10 03:06:22 +03:00
Rafael Gonzaga 4b80a7b0c4 permission: support fs.mkdtemp
PR-URL: https://github.com/nodejs/node/pull/47470
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
2023-04-09 21:35:16 +00:00
Daniel Lemire 63ee335eb0 src: allow simdutf::convert_* functions to return zero
PR-URL: https://github.com/nodejs/node/pull/47471
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-04-09 20:06:33 +00:00
Michael Dawson 6c76d7eaa1 doc: info on handling unintended breaking changes
Fixes: https://github.com/nodejs/TSC/issues/1156
PR-URL: https://github.com/nodejs/node/pull/47426
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2023-04-09 18:47:44 +00:00
Joyee Cheung 491a5c968f sea: use JSON configuration and blob content for SEA
PR-URL: https://github.com/nodejs/node/pull/47125
Refs: https://github.com/nodejs/single-executable/discussions/58
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2023-04-09 18:31:15 +00:00
Marco Ippolito cfb654cc31 tools: automate cjs-module-lexer dependency update
PR-URL: https://github.com/nodejs/node/pull/47446
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-04-09 18:23:04 +00:00
Jiawen Geng 8e9cab7168 build: add node-core-utils to setup
PR-URL: https://github.com/nodejs/node/pull/47442
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-04-09 18:22:50 +00:00
Tobias Nießen 1cda3f36d0 crypto: replace THROW with CHECK for scrypt keylen
The JS layer already uses validateInt32(keylen, 'keylen', 0) to ensure
that the keylen argument fits into a signed 32-bit integer, thus, the
THROW statement in C++ is unreachable (unless the binding is accessed
directly, of course).

PR-URL: https://github.com/nodejs/node/pull/47407
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-04-09 09:22:51 +00:00
Node.js GitHub Bot c311dc43cd deps: update corepack to 0.17.2
PR-URL: https://github.com/nodejs/node/pull/47474
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-04-09 01:56:06 +00:00
Joyee Cheung 284e6ac20c meta: ping startup and realm team on src/node_realm* changes
PR-URL: https://github.com/nodejs/node/pull/47448
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2023-04-08 22:09:27 +02:00
Richard Lau 5ae2bcec45 test: remove stale entry from known_issues.status
The `test-crypto-authenticated-stream` test was moved out of
`test/known_issues` and now lives in `test/parallel`

PR-URL: https://github.com/nodejs/node/pull/47454
Refs: https://github.com/nodejs/node/pull/33981
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-04-08 16:22:35 +00:00
Antoine du Hamel 57caf13562 tools: fix notify-on-push Slack messages
PR-URL: https://github.com/nodejs/node/pull/47453
Refs: https://api.slack.com/reference/surfaces/formatting#special-mentions
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2023-04-08 15:17:50 +00:00
Node.js GitHub Bot 7ef5c60e80 tools: update lint-md-dependencies to @rollup/plugin-node-resolve@15.0.2
PR-URL: https://github.com/nodejs/node/pull/47431
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2023-04-07 23:58:25 +00:00
Richard Lau a75871a36e tools: add root certificate update script
Automates the steps from `doc/contributing/maintaining-root-certs.md`.
Extend "Tools and deps update" workflow to use the new script to update
the root certificates.

PR-URL: https://github.com/nodejs/node/pull/47425
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-04-07 19:10:56 +00:00
Timothy Gu 4b448c8aef url: more sophisticated brand check for URLSearchParams
Use private properties and static {} blocks.

PR-URL: https://github.com/nodejs/node/pull/47414
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-04-07 11:55:59 -07:00
npm CLI robot fe3c96bf4f deps: upgrade npm to 9.6.4
PR-URL: https://github.com/nodejs/node/pull/47432
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-04-07 18:52:14 +00:00
Joyee Cheung 7ece9f3c28 test: move more inspector sequential tests to parallel
This moves sequential inspector tests that can be run in
parallel (using random ports) to parallel.

Before:

```
❯ tools/test.py "test/sequential/test-inspector-*"
[00:07|% 100|+  28|-   0]: Done

All tests passed.
❯ tools/test.py "test/parallel/test-inspector-*"
[00:01|% 100|+  26|-   0]: Done

All tests passed.
```

After:

```
❯ tools/test.py "test/sequential/test-inspector-*"
[00:00|% 100|+   1|-   0]: Done

All tests passed.
❯ tools/test.py "test/parallel/test-inspector-*"
[00:01|% 100|+  53|-   0]: Done

All tests passed.
```

PR-URL: https://github.com/nodejs/node/pull/47412
Refs: https://github.com/nodejs/node/issues/47146
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-04-07 17:47:47 +00:00
Joyee Cheung 13fd068474 test: use random port in test-inspector-enabled
Which makes it possible to run it in parallel.

PR-URL: https://github.com/nodejs/node/pull/47412
Refs: https://github.com/nodejs/node/issues/47146
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-04-07 17:47:46 +00:00
Joyee Cheung e3621c1a09 test: use random port in test-inspector-debug-brk-flag
Which makes it possible to run it in parallel.

PR-URL: https://github.com/nodejs/node/pull/47412
Refs: https://github.com/nodejs/node/issues/47146
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-04-07 17:47:45 +00:00
Joyee Cheung 5cc12c75c0 test: use random port in NodeInstance.startViaSignal()
Which makes it possible to run the tests that use this in parallel.

PR-URL: https://github.com/nodejs/node/pull/47412
Refs: https://github.com/nodejs/node/issues/47146
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-04-07 17:47:44 +00:00
Yagiz Nizipli 217830da9a doc: add performance initiative
PR-URL: https://github.com/nodejs/node/pull/47424
Refs: https://github.com/nodejs/TSC/issues/1343
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2023-04-07 16:14:40 +00:00
Timothy Gu 0c769227ea url: do not use object as hashmap
Fixes cases like new URLSearchParams({ hasOwnProperty: 1 }).

PR-URL: https://github.com/nodejs/node/pull/47415
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2023-04-07 03:32:26 +00:00
Michael Dawson 7efae9341f wasi: make version non-optional
- remove default for version
- updates tests to specify version
- add test for when version is not specified

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/47391
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2023-04-06 17:46:58 -04:00
Luigi Pinca 509b1eb3aa doc: do not create a backup file
The `sed -i -- 's_^#include "chromeconf.h"_//#include "chromeconf.h"_' deps/zlib/zconf.h`
command creates a `zconf.h--` backup file on macOS. Replace it with an
equivalent perl one-liner so that it works on both Linux and macOS.

PR-URL: https://github.com/nodejs/node/pull/47151
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2023-04-06 16:42:34 +02:00
Luigi Pinca be2791b512 deps: update zlib to upstream 5edb52d4
Updated as described in doc/contributing/maintaining-zlib.md.

Refs: https://github.com/nodejs/node/pull/45387#issuecomment-1462728879
PR-URL: https://github.com/nodejs/node/pull/47151
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2023-04-06 16:42:26 +02:00
Jiawen Geng 0e79635c4e build: sync cares source change
PR-URL: https://github.com/nodejs/node/pull/47359
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-04-06 01:14:25 +00:00
Joyee Cheung 583dcca226 src: track ShadowRealm native objects correctly in the heap snapshot
Previously the native ShadowRealm objects were never actually tracked
in the heap snapshot - the tracking starts with the Environment,
we don't call the tracking methods unless it's reachable natively from
the Environment. This patch adds a set in the Environment for tracking
shadow realms in the heap snapshot.

Drive-by: remove redundant MemoryInfo() overrides from the derived
classes of Realm and remove the tracking of `env` from
`Realm::MemoryInfo()` because the realms don't hold the Environment
alive (even for the principal realm, it's the other way around).

PR-URL: https://github.com/nodejs/node/pull/47389
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2023-04-06 00:25:09 +00:00
Konstantin Demin c3cd75d10b build, deps, tools: avoid excessive LTO
Don't link intermediate executables with LTO in order to speed up
overall build time.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/47313
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2023-04-06 00:24:58 +00:00
Joyee Cheung 5c86f223ae src: use the internal field to determine if an object is a BaseObject
Instead of storing the function template of BaseObject for checking
if an object is BaseObject by calling HasInstance, simply checks
the first internal field of the object, which is always set in the
BaseObject constructor. This is simpler and faster
(there is now no need to iterate over the inheritance for the check).

PR-URL: https://github.com/nodejs/node/pull/47217
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2023-04-06 00:24:48 +00:00
Colin Ihrig d1eaeecc8b doc: add MoLow to the TSC
Refs: https://github.com/nodejs/TSC/issues/1364
PR-URL: https://github.com/nodejs/node/pull/47436
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-04-05 21:38:46 +00:00
Yagiz Nizipli ead407915e url: drop ICU requirement for parsing hostnames
PR-URL: https://github.com/nodejs/node/pull/47339
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-04-05 09:05:29 -07:00