BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
45,217 Commits 266 Branches 972 Tags
170848bc1831ea9be665b527e2131c81263dfd2c
Commit Graph
588 Commits
Author SHA1 Message Date
Michaël Zasso 5623194a6b doc,src,test: replace use of deprecated GetIsolate 
`Isolate::GetCurrent()` should be used instead as it returns the same
thing.

Refs: https://github.com/v8/v8/commit/5c4a937aafff2ca21257387510101737afbf10ab
PR-URL: https://github.com/nodejs/node/pull/59805
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2025-10-04 18:48:35 +02:00
Anna Henningsen 2e2f4cd095 src: remove unnecessary std::string error messages 
If we can just use the classic `THROW_...()` methods directly,
without needing to allocate an `std::string` for the message/format
parameter, let's just do so.

PR-URL: https://github.com/nodejs/node/pull/60057
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-09-30 15:39:00 +02:00
Gerhard Stöbich f6ea5bf3b0 fs,win: do not add a second trailing slash in readdir 
Do not add a trailing slash if it was not removed by resolve in
ToNamespacedPath.

PR-URL: https://github.com/nodejs/node/pull/59847
Fixes: https://github.com/nodejs/node/issues/58223
Refs: https://github.com/nodejs/node/pull/56110
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
 2025-09-17 11:15:51 +00:00
Nicholas Paun f855cda2a2 fs: fix wrong order of file names in cpSync error message 
PR-URL: https://github.com/nodejs/node/pull/59775
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-09-07 18:15:13 +00:00
Nicholas Paun fe1a2e33f5 fs: fix dereference: false on cpSync 
PR-URL: https://github.com/nodejs/node/pull/59681
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-08-31 17:30:53 +00:00
Tobias Nießen 7c9c981d27 src: fix order of CHECK_NOT_NULL/dereference 
`ASYNC_THROW_IF_INSUFFICIENT_PERMISSIONS` may dereference
`req_wrap_async`, so `CHECK_NOT_NULL(req_wrap_async)` should be used
before and not after.

PR-URL: https://github.com/nodejs/node/pull/59487
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2025-08-18 12:17:47 +00:00
F3lixTheCat 5d3efaa3c8 src: added CHECK_NOT_NULL check for multiple eq_wrap_async 
PR-URL: https://github.com/nodejs/node/pull/59267
Fixes: https://github.com/nodejs/node/issues/59266
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-07-31 01:55:11 +00:00
theanarkh bf2384f224 fs: fix return value of fs APIs 
PR-URL: https://github.com/nodejs/node/pull/58996
Fixes: https://github.com/nodejs/node/issues/58747
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
 2025-07-20 06:51:26 +00:00
RafaelGSS aad9030f5e src: cleanup uv_fs_req before uv_fs_stat on existSync 
Refs: https://hackerone.com/reports/3184178

Calling uv_fs_stat() without first calling
uv_fs_req_cleanup() overwrites the pointer to the
previously allocated buffer leading to a memory
leak on windows

PR-URL: https://github.com/nodejs/node/pull/58915
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
 2025-07-03 13:38:59 -03:00
Alex Yang 8b199eef3d fs: special input -1 on chown, lchown and fchown 
PR-URL: https://github.com/nodejs/node/pull/58836
Fixes: https://github.com/nodejs/node/issues/58826
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-06-29 21:47:02 +00:00
James M Snell 2bb7667475 fs: move FileHandle close on GC to EOL 
Automatically closing a FileHandle on garbage collection
has been deprecated for some time now. We've said that
it will eventually be removed and become and error.

PR-URL: https://github.com/nodejs/node/pull/58536
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
 2025-06-25 17:00:25 +01:00
Aditi faada65d16 src: add FromV8Value<T>() for integral and enum types 
Add a template utility method FromV8Value<T>() to replace the
repetitive static_cast<...>(value.As<>()‑>Value()) pattern.
It also additionally adds compile‑time range checks for
integers.

Refs: https://github.com/nodejs/node/pull/57146#discussion_r1963799600
PR-URL: https://github.com/nodejs/node/pull/57931
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2025-06-24 04:16:09 +00:00
Jacky Zhao 908f9f1dc6 fs: add UV_ENOSPC to list of things to pass to err directly 
PR-URL: https://github.com/nodejs/node/pull/56918
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2025-06-16 18:56:41 +00:00
Dario Piotrowicz bce60abdb1 src: add new CopyUtimes function to reduce code duplication 
PR-URL: https://github.com/nodejs/node/pull/58625
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2025-06-09 23:35:36 +00:00
Dario Piotrowicz 3c351c272f fs: improve cpSync no-filter copyDir performance 
move the logic in `cpSync` that copies a directory from
src to dest from JavaScript to C++ increasing its performance

Note: this improvement is not applied if the filter option is
      provided, such optimization will be looked into separately
PR-URL: https://github.com/nodejs/node/pull/58461
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2025-06-07 14:44:25 +00:00
Joyee Cheung 3d22cdb713 src: remove fast API for InternalModuleStat 
There are several motivation for removing this:

1. The implementation does not align with InternalModuleStat,
   most noticably it does not namespace the path or convert
   it to UTF-16 before using it with std::filesystem::path
   on Windows which could crash on non-English locale.
2. It needs the Environment - if not for decoding the string,
   at least for env->exec_path() to resolve the path for
   namespacing - and therefore needs a handle to the Context
   which requires a handle scope which actually makes the
   fast API version slower than the normal binding.

For simplicity this just removes the fast API to fix the bug and
improve the performance.

PR-URL: https://github.com/nodejs/node/pull/58489
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-06-03 10:15:39 +00:00
Dario Piotrowicz 1a5ab963b8 fs: improve cpSync dest overriding performance 
move the logic in `cpSync` that overrides existing
dest files from JavaScript to C++ increasing its performance

PR-URL: https://github.com/nodejs/node/pull/58160
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2025-05-23 12:26:04 +00:00
Yagiz Nizipli 5ed1bcbd9b src: fix internalModuleStat v8 fast path 
PR-URL: https://github.com/nodejs/node/pull/58054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2025-04-29 17:53:12 +00:00
Justin Nietzel 6a7b005a07 fs: add missing call to uv_fs_req_cleanup 
Always call uv_fs_req_cleanup after calling uv_fs_open instead of just
when uv_fs_open returns a negative result. I referenced ReadFileSync
from node:js2c when making this change.

https://github.com/bnoordhuis made the same suggestion based on the
PR https://github.com/nodejs/node/pull/49691.

Fixes: https://github.com/nodejs/node/issues/57800
PR-URL: https://github.com/nodejs/node/pull/57811
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-04-12 13:08:10 -07:00
James M Snell 93644d5126 src: improve StringBytes error handling 
PR-URL: https://github.com/nodejs/node/pull/57706
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-04-06 17:19:44 +00:00
James M Snell 538c813fa3 src: fixup fs SyncCall to propagate errors correctly 
Propagate errors correctly in the SyncCall utility.

Previously the test case would trigger a crash.

PR-URL: https://github.com/nodejs/node/pull/57711
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2025-04-03 13:42:20 -07:00
James M Snell 157b36b91b src: make even more improvements to error handling 
PR-URL: https://github.com/nodejs/node/pull/57264
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2025-03-05 07:34:37 -08:00
Paul Schwabauer f52a358217 fs: fix rmSync error code 
Return the correct error code, when a directory_not_empty error
occurred.

Fixes: https://github.com/nodejs/node/issues/57095
PR-URL: https://github.com/nodejs/node/pull/57103
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-02-25 21:13:03 +00:00
Juan José Arboleda 409e28d5aa fs: handle UV_ENOTDIR in fs.statSync with throwIfNoEntry provided 
Fixes: https://github.com/nodejs/node/issues/56993
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/56996
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-02-15 11:47:31 -08:00
yamachu 1760024008 src: fix to generate path from wchar_t via wstring 
Take a similar approach to node_file and allow the creation of paths
code point must be specified to convert from wchar_t to utf8.

PR-URL: https://github.com/nodejs/node/pull/56696
Fixes: https://github.com/nodejs/node/issues/56650
Refs: https://github.com/nodejs/node/pull/56657
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-01-25 08:32:34 +01:00
Michaël Zasso 322056dc32 src: initialize FSReqWrapSync in path that uses it 
PR-URL: https://github.com/nodejs/node/pull/56613
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-01-19 16:47:50 +00:00
James M Snell 8d9dac4877 src: fixup more ToLocalChecked uses in node_file 
PR-URL: https://github.com/nodejs/node/pull/56484
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2025-01-07 14:03:18 -08:00
James M Snell 98d4ebc6d4 src: use v8::LocalVector consistently with other minor cleanups 
V8 introduced `v8::LocalVector` somewhat recently as an alternative
to using `std::vector<v8::Local<T>>` to help ensure that Local handles
are handled correctly. This updates most (but not all) of our uses
of `std::vector<v8::Local<T>>` to use `v8::LocalVector<T>` with a few
other minor cleanups encountered along the way.

PR-URL: https://github.com/nodejs/node/pull/56417
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-01-01 16:27:39 -08:00
Hüseyin Açacak f184a0aca0 fs,win: fix readdir for named pipe 
PR-URL: https://github.com/nodejs/node/pull/56110
Fixes: https://github.com/nodejs/node/issues/56002
Refs: https://github.com/nodejs/node/pull/55623
Refs: https://github.com/nodejs/node/pull/56088
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-12-10 13:31:21 +00:00
Rafael Gonzaga 3a0968db43 permission: ignore internalModuleStat on module loading 
This improves Permission Model usage when allowing read access to
specifi modules. To achieve that, the permission model check on
internalModuleStat has been removed meaning that on module loading,
uv_fs_stat is performed on files and folders even when the permission
model is enabled. Although a uv_fs_stat is performed, reading/executing
the module will still pass by the permission model check.

Without this PR when an app tries to --allow-fs-read=./a.js
--allow-fs-read=./b.js where `a` attempt to load b, it will fails as
it reads $pwd and no permission has been given to this path.

PR-URL: https://github.com/nodejs/node/pull/55797
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2024-11-11 17:31:44 +00:00
jazellyandAntoine du Hamel 56e5bd8d2a fs: use wstring on Windows paths 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/55171
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2024-10-18 09:07:57 +02:00
Jason Zhang 7fe5bcd29e fs: check subdir correctly in cpSync 
PR-URL: https://github.com/nodejs/node/pull/55033
Fixes: https://github.com/nodejs/node/issues/54285
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2024-09-28 13:50:53 +00:00
Carlos Espa f5d454ac7e src: add receiver to fast api callback methods 
When creating an fast api the callback might use the receiver. In that
case if the internal binding is destructured the method won't have
access to the reciver and it will throw. Passing the receiver as second
argument ensures the receiver is available.

PR-URL: https://github.com/nodejs/node/pull/54408
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
 2024-09-28 09:46:03 +00:00
Antoine du Hamel fb852798dc esm: do not interpret "main" as a URL 
As documented, its value is a path.

PR-URL: https://github.com/nodejs/node/pull/55003
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2024-09-27 10:05:50 +00:00
Yagiz Nizipli 5a966714c1 src: revert filesystem::path changes 
PR-URL: https://github.com/nodejs/node/pull/55015
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2024-09-21 17:22:21 +00:00
Jason Zhang 77ca5ca075 fs: convert to u8 string for filesystem path 
PR-URL: https://github.com/nodejs/node/pull/54653
Fixes: https://github.com/nodejs/node/issues/54476
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-09-21 09:13:19 -07:00
Jason ZhangandJake Yuesong Li c1afd2c8e3 fs: translate error code properly in cpSync 
UV error code needs to be negative integer so it can be mapped
correctly. The filesystem error are positive integer, so we need to
handle it before throwing.

Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/54906
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2024-09-16 12:41:55 +00:00
Jason ZhangandJake Yuesong Li a48852be17 fs: respect dereference when copy symlink directory 
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/54732
Fixes: https://github.com/nodejs/node/issues/54730
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-09-05 13:54:49 +00:00
Andreas Haas f0134fa6c3 src: stop using deprecated fields of v8::FastApiCallbackOptions 
Two fields on the `v8::FastApiCallbackOptions` struct were deprecated
recently: `fallback` and `wasm_memory`. This PR removes uses of these
two fields in node.js.

PR-URL: https://github.com/nodejs/node/pull/54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2024-08-16 16:05:31 +02:00
Hüseyin Açacak 37f9eca5b5 module,win: fix long path resolve 
PR-URL: https://github.com/nodejs/node/pull/53294
Fixes: https://github.com/nodejs/node/issues/50753
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2024-08-10 14:12:53 +00:00
Yagiz Nizipli cf2bce6386 fs: fix regression on rmsync 
PR-URL: https://github.com/nodejs/node/pull/53982
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-07-23 16:53:02 +00:00
Yagiz Nizipli 88027e84d8 fs: optimize fs.cpSync js calls 
PR-URL: https://github.com/nodejs/node/pull/53614
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-07-22 16:00:39 +00:00
Cheng 097a52848e src: do not save c_str of a temp string 
PR-URL: https://github.com/nodejs/node/pull/53941
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-07-22 07:15:03 +00:00
Vinicius Lourenço cf8e5356d9 lib: improve error message when index not found on cjs 
PR-URL: https://github.com/nodejs/node/pull/53859
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2024-07-20 00:22:24 +00:00
James M Snell 8f8f2a482f src: replace ToLocalChecked uses with ToLocal in node-file 
PR-URL: https://github.com/nodejs/node/pull/53869
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2024-07-18 21:13:10 -07:00
Aviv Keller c0c7e866dc Revert "fs: add v8 fast api to closeSync" 
This reverts commit ed6f45bef8.

PR-URL: https://github.com/nodejs/node/pull/53904
Refs: https://github.com/yarnpkg/berry/issues/6398
Refs: https://github.com/npm/cli/issues/7657
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2024-07-18 22:25:20 +00:00
Yagiz Nizipli 7168295e7a fs: move rmSync implementation to c++ 
PR-URL: https://github.com/nodejs/node/pull/53617
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2024-07-18 20:02:49 +00:00
Yagiz Nizipli ed6f45bef8 fs: add v8 fast api to closeSync 
PR-URL: https://github.com/nodejs/node/pull/53627
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-07-15 00:28:45 +00:00
Yagiz Nizipli 14e9119302 lib: move ToNamespacedPath call to c++ 
PR-URL: https://github.com/nodejs/node/pull/53654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2024-07-04 16:41:24 +00:00
Yagiz Nizipli c1dc307221 src: replace kPathSeparator with std::filesystem 
PR-URL: https://github.com/nodejs/node/pull/53063
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2024-06-30 20:11:14 +00:00