Ruben Bridgewater
4bb1a3a8ac
lib: fix typos
...
Original-PR-URL: https://github.com/nodejs/node/pull/13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Original-Reviewed-By: Roman Reiss <me@silverwind.io >
Original-Reviewed-By: James M Snell <jasnell@gmail.com >
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/14044
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2017-07-18 19:57:20 +02:00
James M Snell
88c3f57cc3
lib: refactor internal/socket_list
...
PR-URL: https://github.com/nodejs/node/pull/11406
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2017-02-22 08:56:01 -08:00
Benjamin Gruenbaum
a6b9b554eb
child_process: refactor self=this in socket_list
...
The socket list module (used by child_process) currently uses the
`var self = this;` pattern for context in several places, this PR
replaces this with arrow functions or passing a parameter in where
appropriate.
Note that the `var self = this` in the _request is intentioanlly
left in place since it is not trivial to refactor it and the current
pattern isn't bad given the use case.
PR-URL: https://github.com/nodejs/node/pull/5860
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
2016-03-27 12:51:33 +03:00
Sakthipriyan Vairamani
f32a606e37
lib,src: remove usage of events.EventEmitter
...
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.
Refer: https://github.com/nodejs/node/pull/2896
PR-URL: https://github.com/nodejs/node/pull/2921
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
2015-09-23 00:23:08 +05:30
Evan Lucas
a77c330c32
child_process: expose ChildProcess constructor
...
Creates two new internal modules (child_process and socket_list) for
better readability.
Exposes the ChildProcess constructor from the child_process module so
one can now `require(‘child_process’).ChildProcess`
Fixes: https://github.com/nodejs/io.js/issues/1751
PR-URL: https://github.com/nodejs/io.js/pull/1760
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com >
2015-05-28 09:38:29 -05:00
Ruben Bridgewater