Chengzhong Wu
cff8bfd865
test: unify assertSnapshot stacktrace transform
...
The snapshotted stack frames should hide node internal stack frames so
that general node core development does not need updating the snapshot.
For userland stack frames, they are highly fixture related and any
fixture change should reflect in a change of the snapshot. Additionally,
the line and column number are highly relevant to the correctness of the
snapshot, these should not be redacted. A change in node core that
affects userland stack frames should be alarming and be reflected in the
snapshots.
Features like test runner and source map support both should snapshot
userland stack frames to ensure that userland code locations are
computed correctly.
PR-URL: https://github.com/nodejs/node/pull/61665
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com >
2026-02-11 14:36:49 +00:00
Chengzhong Wu
bdceaa2117
test: unify assertSnapshot common patterns
...
Unifes assertSnapshot common patterns like platform specific path
separators, line ending, line trailing spaces, Node.js version strings,
and pids in warning messages.
PR-URL: https://github.com/nodejs/node/pull/61590
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day >
2026-02-02 23:04:33 +00:00
Antoine du Hamel
633ba0079e
tools: enable linter in test/fixtures/eval
...
PR-URL: https://github.com/nodejs/node/pull/57699
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-04-04 10:39:36 +02:00
Marco Ippolito
1c2d98d380
module: improve typescript error message format
...
PR-URL: https://github.com/nodejs/node/pull/57687
Fixes: https://github.com/nodejs/node/issues/56830
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2025-04-01 11:16:48 +00:00
Shelley Vohr
ee8939c82f
test: make eval snapshot comparison more flexible
...
PR-URL: https://github.com/nodejs/node/pull/57020
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-02-23 19:40:51 +00:00
Marco Ippolito
048a17a9b1
test: update snapshots for amaro v0.3.2
...
PR-URL: https://github.com/nodejs/node/pull/56916
Reviewed-By: Jacob Smith <jacob@frende.me >
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com >
2025-02-07 10:34:19 +00:00
Marco Ippolito
e52440bc3b
test: update ts eval snapshots
...
PR-URL: https://github.com/nodejs/node/pull/56568
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
2025-01-15 10:03:03 +00:00
Marco Ippolito
b3f82febf1
test: add ts eval snapshots
...
PR-URL: https://github.com/nodejs/node/pull/56358
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
2024-12-30 16:49:49 +00:00
Marco Ippolito
0e04aea54f
test: remove empty lines from snapshots
...
PR-URL: https://github.com/nodejs/node/pull/56358
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
2024-12-30 16:49:48 +00:00
Marco Ippolito
ecc9fb2f8e
lib: add typescript support to STDIN eval
...
PR-URL: https://github.com/nodejs/node/pull/56359
Reviewed-By: Jordan Harband <ljharb@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com >
2024-12-29 22:42:51 +00:00
Marco Ippolito
ba5992831b
module: unflag --experimental-strip-types
...
PR-URL: https://github.com/nodejs/node/pull/56350
Fixes: https://github.com/nodejs/typescript/issues/17
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com >
2024-12-26 18:46:06 +00:00
Marco Ippolito
da3f388c14
module: support eval with ts syntax detection
...
PR-URL: https://github.com/nodejs/node/pull/56285
Refs: https://github.com/nodejs/typescript/issues/17
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
2024-12-24 16:48:02 +00:00
Yiyun Lei
a9e65f61d4
test: migrate message eval tests from Python to JS
...
Migrate the eval tests in the `test/message` folder from Python to JS.
PR-URL: https://github.com/nodejs/node/pull/50482
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2024-12-24 09:03:50 +01:00