BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
47,759 Commits 266 Branches 972 Tags
330f7b550372f45ede4543ea96bb9e70e166ccbd
Commit Graph
139 Commits
Author SHA1 Message Date
avivkeller 4f844f4380 repl: use inspector over vm 
Signed-off-by: Aviv Keller <me@aviv.sh>
PR-URL: https://github.com/nodejs/node/pull/64034
Fixes: https://github.com/nodejs/node/issues/64523
Closes: https://github.com/nodejs/node/pull/64534
Fixes: https://github.com/nodejs/node/issues/39387
Closes: https://github.com/nodejs/node/pull/39392
Fixes: https://github.com/nodejs/node/issues/61390
Fixes: https://github.com/nodejs/node/issues/63126
Fixes: https://github.com/nodejs/node/issues/38503
Fixes: https://github.com/nodejs/node/issues/37445
Fixes: https://github.com/nodejs/node/issues/38145
Fixes: https://github.com/nodejs/node/issues/33369
Fixes: https://github.com/nodejs/node/issues/48131
Fixes: https://github.com/nodejs/node/issues/8309
Fixes: https://github.com/nodejs/node/issues/39689
Fixes: https://github.com/nodejs/node/issues/18931
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2026-07-18 12:59:37 -07:00
Archkon 7c53fb51dc src: fix some typo errors and rename some variables 
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64301
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2026-07-12 06:16:34 +00:00
TseIan 3518af036c process: improve process.cwd() error message 
PR-URL: https://github.com/nodejs/node/pull/61164
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2026-01-02 11:40:16 +00:00
Antoine du Hamel 0457bfee2c test: forbid use of named imports for fixtures 
PR-URL: https://github.com/nodejs/node/pull/61228
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
 2026-01-01 23:48:26 +00:00
Antoine du Hamel 53e325ffd0 test: ensure assertions are reachable in more folders 
PR-URL: https://github.com/nodejs/node/pull/60411
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2025-10-29 15:16:59 +00:00
Nicholas Paun fe1a2e33f5 fs: fix dereference: false on cpSync 
PR-URL: https://github.com/nodejs/node/pull/59681
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-08-31 17:30:53 +00:00
James M Snell 4a06d470ef test: add known issue test for fs.cpSync dereference bug 
Refs: https://github.com/nodejs/node/issues/58939
PR-URL: https://github.com/nodejs/node/pull/58941
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-08-02 14:23:15 +00:00
Dario Piotrowicz 8d11399a98 test: add known issue tests for recursive readdir calls with Buffer path 
PR-URL: https://github.com/nodejs/node/pull/58893
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-07-01 21:48:33 +00:00
James M Snell 2022f832a9 test: add known issue tests for fs.cp 
PR-URL: https://github.com/nodejs/node/pull/58883
Refs: https://github.com/nodejs/node/issues/58634
Refs: https://github.com/nodejs/node/issues/58869
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-07-01 04:35:06 +00:00
Pietro Marchini 7e24ebc780 test_runner: unify --require and --import behavior when isolation none 
PR-URL: https://github.com/nodejs/node/pull/57924
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2025-05-06 06:28:29 +00:00
Jacob Smith 5a2614fd03 test: fix dangling promise in test_runner no isolation test setup 
PR-URL: https://github.com/nodejs/node/pull/57595
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
 2025-04-02 19:30:53 +00:00
Yagiz Nizipli 72aa2ea841 deps: update ada to v3.2.1 
PR-URL: https://github.com/nodejs/node/pull/57429
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-03-14 23:59:48 +00:00
Node.js GitHub Bot 7443a28c28 test: update WPT for url to 6fa3fe8a92 
PR-URL: https://github.com/nodejs/node/pull/56136
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-12-10 00:36:23 +00:00
Chengzhong Wu d2479fa020 vm: return all own names and symbols in property enumerator interceptor 
Property enumerator methods like `Object.getOwnPropertyNames`,
`Object.getOwnPropertySymbols`, and `Object.keys` all invokes the
named property enumerator interceptor. V8 will filter the result based
on the invoked enumerator variant. Fix the enumerator interceptor to
return all potential properties.

PR-URL: https://github.com/nodejs/node/pull/54522
Refs: https://github.com/jsdom/jsdom/issues/3688
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2024-08-30 11:22:58 +00:00
Konstantin Ulitin 291c1211f2 test: add Debugger.setInstrumentationBreakpoint known issue 
PR-URL: https://github.com/nodejs/node/pull/31137
Refs: https://github.com/nodejs/node/issues/31138
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-05-12 22:33:07 +02:00
Austin WrightLenvin GonsalvesAntoine du Hamel
 		d4e365f606 test: verify request payload is uploaded consistently 
Node.js seems to change how it is uploaded based on the method,
but HTTP doesn't make any distinction.

Co-authored-by: Austin Wright <aaa@bzfx.net>
Co-authored-by: Lenvin Gonsalves <lenvingonsalves@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/34066
Refs: https://github.com/nodejs/node/issues/27880
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-05-12 21:15:30 +02:00
Rafael Gonzaga 15456e4e57 src,permission: resolve path on fs_permission 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/52761
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2024-05-03 03:40:49 +00:00
Michael Lumish 93c4efeb25 http2: allow streams to complete gracefully after goaway 
A detailed analysis of the cause of this bug is in my linked comment on
the corresponding issue. The primary fix is the new setImmediate call in
Http2Stream#_destroy, which prevents a re-entrant call into
Http2Session::SendPendingData when sending trailers after the
Http2Session has been shut down, allowing the trailer data to be flushed
properly before the socket is closed.

As a result of this change, writes can be initiated later in the
lifetime of the Http2Session. So, when a JSStreamSocket is used as the
underlying socket reference for an Http2Session, it needs to be able to
accept write calls after it is closed.

In addition, now that outgoing data can be flushed differently after a
session is closed, in two tests clients receive errors that they
previously did not receive. I believe the new errors are more correct,
so I changed the tests to match.

Fixes: https://github.com/nodejs/node/issues/42713
Refs: https://github.com/nodejs/node/issues/42713#issuecomment-1756140062
PR-URL: https://github.com/nodejs/node/pull/50202
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-10-20 13:28:18 +00:00
Richard Lau 035e06317a test: disambiguate AIX and IBM i 
When built with Python 3.9 on IBM i, `process.platform` will return
`os400` instead of `aix`. In preparation for this, make `common.isAIX`
only return true for AIX and update the tests to add checks for
`common.isIBMi` where they were missing.

PR-URL: https://github.com/nodejs/node/pull/48056
Refs: https://github.com/nodejs/node/pull/46739
Refs: https://github.com/nodejs/build/pull/3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-29 18:26:27 +00:00
Tobias Nießen a81d5e11f3 doc,test: add known path resolution issue in permission model 
As a side effect of 205f1e643e, Node.js
now resolves some paths differently when the permission model is
enabled. While these are mostly edge cases, they are worth mentioning in
the documentation. This commit also adds a known_issues test that
demonstrates one such difference.

PR-URL: https://github.com/nodejs/node/pull/49155
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-08-31 06:58:59 +00:00
legendecas ac0853c4ee src: make realm binding data store weak 
The binding data must be weak so that it won't keep the realm reachable
from strong GC roots indefinitely. The wrapper object of binding data
should be referenced from JavaScript, thus the binding data should be
reachable throughout the lifetime of the realm.

PR-URL: https://github.com/nodejs/node/pull/47688
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2023-06-14 02:05:00 +00:00
Santiago Gimeno 1620626fa8 test: unflake test-vm-timeout-escape-nexttick 
This wasn't failing on arm boxes, increase the `runInNewContext()`
timeout a bit to make sure the code it's allowed to fail.

PR-URL: https://github.com/nodejs/node/pull/48078
Fixes: https://github.com/nodejs/node/issues/43931
Fixes: https://github.com/nodejs/node/issues/42496
Fixes: https://github.com/nodejs/node/issues/47715
Fixes: https://github.com/nodejs/node/issues/47259
Fixes: https://github.com/nodejs/node/issues/47241
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2023-05-24 11:07:06 +00:00
Richard Lau 5ae2bcec45 test: remove stale entry from known_issues.status 
The `test-crypto-authenticated-stream` test was moved out of
`test/known_issues` and now lives in `test/parallel`

PR-URL: https://github.com/nodejs/node/pull/47454
Refs: https://github.com/nodejs/node/pull/33981
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2023-04-08 16:22:35 +00:00
Joyee Cheung 036197879b test: move test-shadow-realm-gc.js to known_issues 
There is actually a leak. The test doesn't exercise the right
path to create a substantial enough object graph (e.g.
accessing something that results in the loading of a binding).
This does something more complicated in the test and moves it
to known_issues until we find a fix.

PR-URL: https://github.com/nodejs/node/pull/47355
Refs: https://github.com/nodejs/node/issues/47353
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-04-04 03:19:02 +00:00
Rich Trott d1b29b4661 Revert "src: let http2 streams end after session close" 
This reverts commit dee882e94f.
Moved the test that demonstrated what this commit was fixing to the
`known_issues` folder.

Fixes: https://github.com/nodejs/node/issues/46234
PR-URL: https://github.com/nodejs/node/pull/46721
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-02-21 12:46:21 +00:00
Antoine du Hamel 6d92cc736d test: add trailing commas in test/known_issues 
PR-URL: https://github.com/nodejs/node/pull/46408
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2023-02-01 10:46:55 +01:00
Antoine du Hamel e8d40154d8 readline: fix detection of carriage return 
Fixes: https://github.com/nodejs/node/issues/45992
PR-URL: https://github.com/nodejs/node/pull/46306
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-01-24 12:10:11 +00:00
Alec Mev de6c0e6779 test: add failing test for readline with carriage return 
PR-URL: https://github.com/nodejs/node/pull/46075
Refs: https://github.com/nodejs/node/issues/45992
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-01-22 10:21:48 +01:00
Antoine du Hamel 2c1b9f506a test: remove unnecessary noop function args to mustCall() 
RefsL https://github.com/nodejs/node/pull/45027

PR-URL: https://github.com/nodejs/node/pull/45047
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
 2022-10-20 13:13:32 +00:00
Antoine du Hamel 6de2673a9f lib: enable global WebCrypto by default 
Enables `--experimental-global-webcrypto` by default, and ensures that
the classic `node:crypto` core module is still available in `--eval` or
`--print` contexts.

PR-URL: https://github.com/nodejs/node/pull/42083
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2022-09-17 15:54:33 +02:00
Rich Trott 16a9ab142c debugger: prevent simultaneous heap snapshots 
Fixes: https://github.com/nodejs/node/issues/39555

PR-URL: https://github.com/nodejs/node/pull/39638
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-08-05 11:52:55 +00:00
Rich Trott 7db86e7cce test: add known issues test for debugger heap snapshot race 
Refs: https://github.com/nodejs/node/issues/39555

PR-URL: https://github.com/nodejs/node/pull/39557
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-08-01 13:09:47 +00:00
Rich Trott a518e4b871 debugger: indicate server is ending 
Currently, we say "listening" when we are ending the server. Change it
to "ending".

Fixes: https://github.com/nodejs/node/issues/39272

PR-URL: https://github.com/nodejs/node/pull/39334
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
 2021-07-12 06:29:01 -07:00
Rich Trott b2fa795159 test: add test for debugger restart message issue 
Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: https://github.com/nodejs/node/issues/39272

PR-URL: https://github.com/nodejs/node/pull/39273
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-07 20:57:15 -07:00
Rich Trott b0d5e036d8 path: fix posix.relative() on Windows 
Fixes: https://github.com/nodejs/node/issues/13683

PR-URL: https://github.com/nodejs/node/pull/37747
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-04-02 19:30:43 -07:00
Rich Trott 55f0955864 test: add known_issues test for #13683 
Add a known_issues test for a known Windows issue.

Refs: https://github.com/nodejs/node/issues/13683

PR-URL: https://github.com/nodejs/node/pull/37744
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-03-17 21:56:52 -07:00
Michael Dawson 15164cebce lib,src: update cluster to use Parent 
Doc deprecate isMaster and setupMaster in favor
of isPrimary and setupPrimary.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/36478
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
 2021-01-05 15:41:45 -05:00
bcoe 7d6672226b fs: rimraf should not recurse on failure 
PR-URL: https://github.com/nodejs/node/pull/35566
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-10-13 15:04:57 -07:00
ExE Boss 9ae8491204 vm: add tests for function declarations using [[DefineOwnProperty]] 
Refs: https://github.com/nodejs/node/issues/31808

PR-URL: https://github.com/nodejs/node/pull/34032
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
 2020-07-16 00:24:36 +02:00
Rich Trott a98426a771 test: add issue ref for known_issues test 
PR-URL: https://github.com/nodejs/node/pull/34267
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-07-11 20:53:39 -07:00
Rich Trott 6ae1b9c457 test: add known issue for fs.open() keeping event loop open 
PR-URL: https://github.com/nodejs/node/pull/34228
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2020-07-08 18:10:42 -07:00
Anna Henningsen f63436d190 vm: add run-after-evaluate microtask mode 
This allows timeouts to apply to e.g. `Promise`s and `async function`s
from code running inside of `vm.Context`s, by giving the Context its
own microtasks queue.

Fixes: https://github.com/nodejs/node/issues/3020

PR-URL: https://github.com/nodejs/node/pull/34023
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
 2020-06-26 11:41:33 -07:00
Robert Nagy db0e991d52 fs: remove custom Buffer pool for streams 
The performance benefit of using a custom pool are negligable.
Furthermore, it causes problems with Workers and transferrable.
Rather than further adding complexity for compat with Workers,
just remove the pooling logic.

Refs: https://github.com/nodejs/node/issues/33880#issuecomment-644430693
Fixes: https://github.com/nodejs/node/issues/31733

PR-URL: https://github.com/nodejs/node/pull/33981
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2020-06-23 13:27:01 +02:00
Ben Noordhuis 251b08d4e8 test: skip crypto test on arm buildbots 
The Raspberry Pis are too slow to run this computationally expensive
test in a timely manner, it times out after 240 seconds.

PR-URL: https://github.com/nodejs/node/pull/32636
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-04-04 07:09:51 -07:00
Ben Noordhuis 6f94221884 test: add known issues test for #31733 
Authenticated decryption works for file streams up to 32768 bytes but
not beyond. Other streams and direct decryption are not affected.

Refs: https://github.com/nodejs/node/issues/31733

PR-URL: https://github.com/nodejs/node/pull/31734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2020-04-02 18:00:07 +02:00
Denys Otrishko 30bbeb7680 test: always skip vm-timeout-escape-queuemicrotask 
This issue is unfixable with the current implementations of V8 and
Node.js. Changes to make this fixable are unlikely to happen in the
foreseeable future. The test itself is flaky and skipped.  It
serves as a demonstration of the issue only.

PR-URL: https://github.com/nodejs/node/pull/31980
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2020-03-10 11:49:09 -07:00
Denys Otrishko 468bfd3487 test: increase timeout in vm-timeout-escape-queuemicrotask 
It looks like under high load the loop isn't even started and therefore
successfully finishes without 'escaping'. After increasing the timeout
during parallel run of the test failure rate decreased from 15/1000 to
0/1000.

PR-URL: https://github.com/nodejs/node/pull/31966
Refs: https://github.com/nodejs/node/issues/25529
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-02-26 22:18:08 -08:00
James M Snell 5bef2ccf20 test: add known issue test for sync writable callback 
If the write callbacks are invoked synchronously with an
error, onwriteError would cause the error event to be
emitted synchronously, making it impossible to attach
an error handler after the call that triggered it.

PR-URL: https://github.com/nodejs/node/pull/31756
Refs: https://github.com/nodejs/quic/commit/b0d469c69c49c9186c1a581a7cebce4c5d398947
Refs: https://github.com/nodejs/quic/pull/341
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2020-02-17 08:09:29 -08:00
Rich Trott b6e301a9e0 test: add test-fs-writeFileSync-invalid-windows 
Add a known_issues test for the Windows returning ENOTFOUND where EINVAL
is more appropriate. This happens with various functions in the `fs`
module when an invalid path is used.

Refs: https://github.com/nodejs/node/issues/8987

PR-URL: https://github.com/nodejs/node/pull/28569
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2019-07-11 10:27:42 -07:00
Rich Trott e008ca8b93 test: fix flaky test-vm-timeout-escape-nexttick 
PR-URL: https://github.com/nodejs/node/pull/28461
Fixes: https://github.com/nodejs/node/issues/24120
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-07-02 06:49:40 +02:00