Antoine du Hamel
441027af47
tools: enforce trailing commas in test/sequential
...
PR-URL: https://github.com/nodejs/node/pull/60892
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
2025-12-03 14:17:37 +01:00
Joyee Cheung
be3fc1f729
test: spin longer on flaky platforms for test-worker-prof
...
Try spinning longer to get more ticks on flaky platforms
and reduce flakiness.
PR-URL: https://github.com/nodejs/node/pull/60492
Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-10-29.md
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-11-03 21:43:30 +00:00
Joyee Cheung
8429d9a40b
test: make test-worker-prof more tolerant
...
It seems after the recent V8 upgrade, it's no longer safe to assume
there'll be 15 ticks per 1500ms. Lower it to 10 ticks.
PR-URL: https://github.com/nodejs/node/pull/60272
Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-10-15.md
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2025-10-17 22:40:23 +00:00
Michaël Zasso
7dd49d7da4
test: spin longer for sequential/test-worker-prof
...
On Windows with V8 14.1, we are just below the current threshold.
PR-URL: https://github.com/nodejs/node/pull/59805
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Richard Lau <richard.lau@ibm.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2025-10-04 18:48:41 +02:00
Nathan Baulch
28c7394319
test: fix typos
...
PR-URL: https://github.com/nodejs/node/pull/55063
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2024-09-28 13:58:55 +00:00
Antoine du Hamel
c714cda9a7
test: add spawnSyncAndAssert util
...
PR-URL: https://github.com/nodejs/node/pull/52132
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2024-03-20 19:44:14 +01:00
Joyee Cheung
7f001c2299
test: make test-worker-prof more robust
...
Use a JS workload instead of repeating FS operations and use a
timer to make it less flaky on machines with little resources.
PR-URL: https://github.com/nodejs/node/pull/49274
Refs: https://github.com/nodejs/node/issues/26401
Refs: https://github.com/nodejs/reliability/issues/640
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2023-09-04 21:53:59 +00:00
Livia Medeiros
052434a0c1
test: use tmpdir.resolve()
...
PR-URL: https://github.com/nodejs/node/pull/49136
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-08-21 16:41:53 +00:00
Rich Trott and Gireesh Punathil
04fb597996
test: fix flaky test-worker-prof
...
Fixes: https://github.com/nodejs/node/issues/26401
Co-authored-by: Gireesh Punathil <gpunathi@in.ibm.com >
PR-URL: https://github.com/nodejs/node/pull/37372
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2021-02-20 10:40:49 -08:00
Harshitha KP
bffc9324a1
test: harden the tick sampling logic
...
Under peculiar system load conditions, the profiler thread
does not get enough CPU slices to perform the sampling.
Improve the interaction between worker and parent thread
by performing a large disc read, which is a better blend of
CPU and I/O bound work, than earlier versions.
This produces x10 more samples than the existing one,
in 10 iterations, as opposed to 1024.
Also capture worker error situations to improve debugging
Refs: https://github.com/nodejs/node/issues/26401#issuecomment-597438516
PR-URL: https://github.com/nodejs/node/pull/32190
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-03-30 10:24:19 +02:00
Rich Trott
ebb177ee22
test: move test-worker-prof to sequential
...
Refs: https://github.com/nodejs/node/issues/26401#issuecomment-557899953
PR-URL: https://github.com/nodejs/node/pull/30628
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2019-11-26 10:17:04 -08:00
Antoine du Hamel