Commit Graph
119 Commits
Author SHA1 Message Date
Stefan Stojanovic 262dee503a build,win: enable x64 PGO
PR-URL: https://github.com/nodejs/node/pull/62761
Refs: https://github.com/nodejs/node/issues/61964
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2026-04-23 12:43:51 +00:00
Node.js GitHub Bot 7547e795ef deps: update icu to 78.3
PR-URL: https://github.com/nodejs/node/pull/62324
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2026-03-20 17:25:46 +00:00
Mike McCready 680ee6ee66 doc: remove v prefix for version references
PR-URL: https://github.com/nodejs/node/pull/61488
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2026-01-25 10:38:06 +01:00
Node.js GitHub Bot 1bd7f62d13 deps: update icu to 78.2
PR-URL: https://github.com/nodejs/node/pull/60523
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
2026-01-11 18:05:01 +00:00
Christian Clauss 0fb040603b build: upgrade Python linter ruff, add rules ASYNC,PERF
PR-URL: https://github.com/nodejs/node/pull/59984
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2025-10-08 07:37:31 +00:00
Yagiz Nizipli 0fd1ecded6 meta: enable jsdoc/check-tag-names rule
PR-URL: https://github.com/nodejs/node/pull/58521
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-07-18 09:28:21 +00:00
Node.js GitHub Bot ab9660b55a deps: update icu to 77.1
PR-URL: https://github.com/nodejs/node/pull/57455
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2025-03-16 20:10:32 +00:00
Livia Medeiros a364ec1d1c test: move localizationd data from test-icu-env to external file
PR-URL: https://github.com/nodejs/node/pull/55618
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-12-10 23:44:07 +00:00
Node.js GitHub Bot 34dc8e37bf deps: update icu to 76.1
PR-URL: https://github.com/nodejs/node/pull/55551
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-11-07 10:21:22 +00:00
Aviv Keller c6ae161237 meta: remove unneeded ignore rules from ruff
PR-URL: https://github.com/nodejs/node/pull/54360
Reviewed-By: Christian Clauss <cclauss@me.com>
2024-09-18 17:07:37 +02:00
Stefan Stojanovic 79a33a7433 build,win: enable clang-cl compilation
This uses the backported ICU fix needed for compiling with ClangCL.

Refs: https://github.com/nodejs/node/pull/54502
Fixes: https://github.com/nodejs/node/issues/34201
PR-URL: https://github.com/nodejs/node/pull/54655
Refs: https://github.com/nodejs/node/issues/52809
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
2024-09-09 10:26:00 +00:00
Stefan Stojanovic ebaabf6a0a deps: backport ICU-22787 to fix ClangCL on Windows
- Floating patch for ICU 75.x

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-22787
Backport of: https://github.com/unicode-org/icu/pull/3023

PR-URL: https://github.com/nodejs/node/pull/54502
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-08-27 18:44:05 +00:00
Node.js GitHub Bot 3f74b68e39 deps: update icu to 75.1
PR-URL: https://github.com/nodejs/node/pull/52573
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-04-21 00:44:40 +00:00
Michaël Zasso 3f4f642ede deps: update icu to 74.2
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
PR-URL: https://github.com/nodejs/node/pull/51723
Refs: https://github.com/nodejs/node/pull/51721
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-02-15 19:46:30 +00:00
Node.js GitHub Bot 7c726f742a deps: update icu to 74.1
PR-URL: https://github.com/nodejs/node/pull/50515
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
2023-11-21 16:55:15 -05:00
Michaël Zasso 162a0652ab deps: bump minimum ICU version to 73
Refs: https://github.com/v8/v8/commit/d9715adf895e9acfbaf17ae05b18f2b2467ca322
PR-URL: https://github.com/nodejs/node/pull/49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2023-10-10 08:26:43 +02:00
Node.js GitHub Bot cd28ebbcb7 deps: update icu to 73.2
PR-URL: https://github.com/nodejs/node/pull/48502
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2023-06-23 13:50:48 +00:00
Marco Ippolito 1b177932a1 tools: automate icu-small update
PR-URL: https://github.com/nodejs/node/pull/47727
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2023-05-09 21:01:08 +00:00
Marco Ippolito 109ab0a89c doc: create maintaining folder for deps
PR-URL: https://github.com/nodejs/node/pull/47589
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2023-05-02 17:03:23 +00:00
Steven R. Loomis e050cecad1 deps: update ICU to 73.1 release
- Details: https://icu.unicode.org/download/73

PR-URL: https://github.com/nodejs/node/pull/47456
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2023-04-17 09:48:26 -05:00
Konstantin Demin c3cd75d10b build, deps, tools: avoid excessive LTO
Don't link intermediate executables with LTO in order to speed up
overall build time.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/47313
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2023-04-06 00:24:58 +00:00
Michael Dawson 7ea2fc8cc4 tools: allow icutrim.py to run on python2
Refs: https://github.com/nodejs/build/issues/2998

Small icu seems broken from 14.x since it uses
python2. Although main no longer supports python2
landing and backporting this change to the 14.x line would
allow us to simplify future backports as currently
the files are the same across lines.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: https://github.com/nodejs/node/pull/46263
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2023-01-21 20:05:17 +00:00
Michaël Zasso b4c2004311 build: avoid redefined macro
It's already defined in `common.gypi`.

PR-URL: https://github.com/nodejs/node/pull/45544
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2022-11-22 14:54:19 +00:00
Steven R. Loomis 8fdac2056a build: fix icu-small build with ICU 72.1
- RTTI is needed for genrb now.

Fixes: https://github.com/nodejs/node/issues/45174
PR-URL: https://github.com/nodejs/node/pull/45195
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2022-10-27 21:04:48 +02:00
Michaël Zasso 1f9b181c20 deps: update ICU to 72.1
Refs: https://github.com/unicode-org/icu/releases/tag/release-72-1
PR-URL: https://github.com/nodejs/node/pull/45068
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2022-10-25 14:13:17 +00:00
Michaël Zasso 89ecdddaab deps: bump minimum ICU version to 71
Refs: https://github.com/v8/v8/commit/3ae42771de56d60148b2d70dd2793d6db9b43b71
PR-URL: https://github.com/nodejs/node/pull/44741
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2022-10-11 07:27:08 +02:00
Feng Yu 6ac55fa337 doc: update link of ICU data slicer
PR-URL: https://github.com/nodejs/node/pull/43483
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-06-20 11:20:57 +02:00
Michaël Zasso 6d4b01774b deps: update ICU to 71.1
Refs: https://github.com/unicode-org/icu/releases/tag/release-71-1

PR-URL: https://github.com/nodejs/node/pull/42655
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2022-04-10 10:13:52 +01:00
Michael Dawson a199387f04 doc: make contributing info more discoverable
There are been several discussions in recent PRs about
the docs related to contributing not being very discoverable.
Move these docs from doc/guides/ to doc/contributing.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41408
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
2022-01-18 14:24:30 -05:00
Michaël Zasso de6399c0c0 deps: update ICU to 70.1
Refs: https://github.com/unicode-org/icu/releases/tag/release-70-1

PR-URL: https://github.com/nodejs/node/pull/40658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2021-11-09 17:26:53 +01:00
Cheng Zhao 92090d3435 build: make scripts in gyp run with right python
PR-URL: https://github.com/nodejs/node/pull/39730
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2021-10-09 22:16:05 +00:00
Rich Trott 0c95dead55 doc: update tools .md files for upcoming lint/formatting
Looks like only one .md file in `tools` needs to be changed.

PR-URL: https://github.com/nodejs/node/pull/40155
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-09-21 16:58:58 -07:00
Michaël Zasso 630f968290 deps: bump minimum ICU version to 69
Refs: https://github.com/v8/v8/commit/edac49681843447cc483b164a26d00755870b08c

PR-URL: https://github.com/nodejs/node/pull/38990
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2021-07-20 15:27:41 +02:00
Michaël Zasso ee669a0d29 deps: update ICU to 69.1
Refs: https://github.com/unicode-org/icu/releases/tag/release-69-1

PR-URL: https://github.com/nodejs/node/pull/38178
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-04-14 09:07:29 +00:00
Michaël Zasso 43cc8e4b2e deps: bump minimum ICU version to 68
Refs: https://github.com/v8/v8/commit/1e69cdd95bad505ec5de1ddca9e58eee8cd9383f

PR-URL: https://github.com/nodejs/node/pull/37330
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2021-02-25 00:16:30 +01:00
Michaël Zasso 900c9f5041 tools: cleanup old ICU version-specific fixes
Our current minimum ICU is 67, so we don't need to support those anymore

PR-URL: https://github.com/nodejs/node/pull/36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2021-01-20 16:32:50 +01:00
Michaël Zasso 5faffd8d3f deps: update ICU to 68.2
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-2

PR-URL: https://github.com/nodejs/node/pull/36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2021-01-20 16:32:45 +01:00
Richard Lau fcf62269df tools: fix md5 hash for ICU 68.1 src
Correct md5sum hash for the tarball version of the ICU 68.1 source.
The previously recorded md5sum hash was for the zip version.

PR-URL: https://github.com/nodejs/node/pull/36777
Fixes: https://github.com/nodejs/node/issues/36776
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
2021-01-05 20:47:34 -08:00
Antoine du Hamel 299984561e tools: fix undeclared identifier FALSE
PR-URL: https://github.com/nodejs/node/pull/36276
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-11-28 05:48:30 -08:00
Michaël Zasso f3821cd8d7 deps: update ICU to 68.1
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-1

PR-URL: https://github.com/nodejs/node/pull/36187
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2020-11-22 20:58:08 +00:00
Antoine du Hamel 7794d36a37 tools,doc: enforce alphabetical order for md refs
PR-URL: https://github.com/nodejs/node/pull/35244
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
2020-09-22 10:25:43 -07:00
Michaël Zasso b1a0efacf2 deps: bump minimum icu version to 67
Bump minimum version of ICU needed to build node to 67.

Refs: https://github.com/v8/v8/commit/611e412768a7bc87a20d0315635b0bf76a5bab46

PR-URL: https://github.com/nodejs/node/pull/33579
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
2020-07-13 14:42:43 +02:00
Richard Townsend 8833551257 build,win: add support for MSVC cross-compilation
* Fixes cases in icutools where commands were issued without .exe
* Changes to build scripts
* Add /fp:strict flag so that MSVC's floating point behaves correctly
* Enables marmasm

PR-URL: https://github.com/nodejs/node/pull/32867
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: João Reis <reis@janeasystems.com>
2020-05-19 19:30:40 +01:00
Michaël Zasso cfec30fef3 deps: update to ICU 67.1
Refs: https://github.com/unicode-org/icu/releases/tag/release-67-1

PR-URL: https://github.com/nodejs/node/pull/33324
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
2020-05-12 08:19:43 +02:00
Nick Schonning 7183d70273 doc: add angle brackets around implicit links
PR-URL: https://github.com/nodejs/node/pull/32676
Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-04-23 21:48:17 -07:00
Steven R. Loomis 74e7e72768 deps: update to ICU 66.1
- ICU 66.1 http://site.icu-project.org/download/66
- Unicode 13
- CLDR 36.1
- Updated ./LICENSE

PR-URL: https://github.com/nodejs/node/pull/32348
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
2020-03-20 17:27:04 -07:00
Steven R. LoomisandChristian Clauss b8a794d72b deps: minor ICU fixes: maint docs/tool, downloader
- Docs used the word "copy" when it really meant a tool is needed.
- README-FULL-ICU.txt was generated in binary mode, but it's a
text file. This breaks on Python3 for maintaining ICU
- The ICU downloader was broken (also probably python3). It's
basically dead code since 1a25e901b7
landed (full icu in repo), unless someone deleted the deps/icu-small
directory from their repo.

Co-Authored-By: Christian Clauss <cclauss@me.com>
PR-URL: https://github.com/nodejs/node/pull/32347

Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
2020-03-20 17:21:50 -07:00
Michaël Zasso 0220c298c5 deps: bump minimum icu version to 65
Bump minimum version of ICU needed to build node to 65.

Refs: https://github.com/v8/v8/commit/74bf96e508e3cb8f9991c48b421d48eb0bf4dbff

PR-URL: https://github.com/nodejs/node/pull/32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2020-03-18 16:35:41 -07:00
Jonathan MERCIER 5f0af2af2a tools: fixup icutrim.py use of string and bytes objects
PR-URL: https://github.com/nodejs/node/pull/31659
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2020-03-18 16:18:27 -07:00
Rich Trott 2a7d66200b doc: revise tools/icu/README.md
* Simplify introductory sentence.
* Remove some passive voice.
* Make style in bulleted list a little more consistent.
* Remove superfluous list entry.

PR-URL: https://github.com/nodejs/node/pull/32136
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2020-03-09 07:17:48 -07:00