James M Snell
411cc42d22
worker: move terminate callback to end-of-life
...
Passing a callback to worker.terminate() has been deprecated
for about six years now. It's time to remove it.
PR-URL: https://github.com/nodejs/node/pull/58528
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2025-06-02 11:16:49 -07:00
James M Snell
d33f4b539a
assert: move assert.fail with multiple arguments to eol
...
Calling `assert.fail` with multiple arguments has been deprecated
for years. Remove it finally.
PR-URL: https://github.com/nodejs/node/pull/58532
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-06-02 18:09:22 +00:00
James M Snell
4e06a648ff
perf_hooks: move deprecated accessors to EOF
...
Additional accessors on PerformanceEntry objects
have been deprecated in favor of the detail property
for a number of years now. This removes them.
PR-URL: https://github.com/nodejs/node/pull/58531
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-06-02 17:29:27 +00:00
James M Snell
a273674dee
fs: move fs stream open method to eol
...
The `open()` method on fs read and write streams has been
deprecated for many years. It's time to remove it while
still allowing the open method to be monkeypatched since
that's still apparently a thing.
PR-URL: https://github.com/nodejs/node/pull/58529
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jason Zhang <xzha4350@gmail.com >
2025-06-02 16:54:31 +00:00
James M Snell
df16f0fd8d
child_process: move _channel to end-of-life
...
The `._channel` property has been deprecated for many years
now. It's time to remove it.
PR-URL: https://github.com/nodejs/node/pull/58527
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2025-06-02 16:25:50 +00:00
Ethan Arrowood
2be863be08
dns: fix dns query cache implementation
...
PR-URL: https://github.com/nodejs/node/pull/58404
Refs: https://github.com/nodejs/node/pull/57640
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Tim Perry <pimterry@gmail.com >
2025-06-02 15:29:36 +00:00
Michaël Zasso
eb159a8cfd
test: remove duplicated allocUnsafeSlow test
...
PR-URL: https://github.com/nodejs/node/pull/58524
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2025-06-02 11:32:58 +00:00
Darshan Sen
d89657c29e
http2: add diagnostics channel 'http2.server.stream.error'
...
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/58512
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2025-06-01 13:08:20 +00:00
Jelle Licht
4513e9c50f
test: make sqlite-database-sync tests work with system sqlite
...
PR-URL: https://github.com/nodejs/node/pull/58507
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-06-01 10:56:00 +00:00
James M Snell
968e2f47c8
dgram: move deprecated APIs to EOL
...
Seven years is long enough to be deprecated.
PR-URL: https://github.com/nodejs/node/pull/58474
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-05-31 02:59:40 +00:00
James M Snell
62ba6196d4
sqlite: cleanup ERM support and export Session class
...
Update sqlite Session to support Symbol.dispose and
move the definition of the dispose methods to c++ to
close the open TODO
PR-URL: https://github.com/nodejs/node/pull/58378
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2025-05-30 17:21:30 -07:00
Jacopo Martinelli
95249083ea
test_runner: emit event when file changes in watch mode
...
PR-URL: https://github.com/nodejs/node/pull/57903
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
2025-05-30 19:32:11 +00:00
Tobias Nießen
7622f0d050
src: fix FIPS init error handling
...
If `--enable-fips` or `--force-fips` fails to be applied during
`ProcessFipsOptions()`, the node process might exit with
`ExitCode::kNoFailure` because `ERR_GET_REASON(ERR_peek_error())` can
return `0` since `ncrypto::testFipsEnabled()` does not populate the
OpenSSL error queue.
You can likely test this locally by running
node --enable-fips && echo $?
with the current `node` binary from the main branch if compiled without
support for FIPS.
As confirmed by the `XXX` comment here, which was added three years ago
in commit b697160256 , even if the error
queue was populated properly, the OpenSSL reason codes are not really
related to the Node.js `ExitCode` enumeration.
PR-URL: https://github.com/nodejs/node/pull/58379
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2025-05-30 11:23:57 +00:00
Chengzhong Wu
7ffa029750
src,lib: obtain sourceURL in magic comments from V8
...
Obtain sourceURL magic comments via V8 API to avoid a second round of
extraction of magic comments.
Updates source map snapshot normalization to allow testing full path
names inside the test outputs.
PR-URL: https://github.com/nodejs/node/pull/58389
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2025-05-30 09:47:20 +00:00
Darshan Sen
fd46569a50
http2: add diagnostics channel 'http2.server.stream.start'
...
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/58449
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2025-05-29 11:11:46 +00:00
Richard Lau
8e2fb67bd9
test: mark test-http2-debug as flaky on LinuxONE
...
PR-URL: https://github.com/nodejs/node/pull/58494
Refs: https://github.com/nodejs/node/issues/58353
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com >
2025-05-28 14:09:03 -07:00
Shima Ryuhei
a4c7c9f6d7
inspector: add mimeType and charset support to Network.Response
...
Refs: https://github.com/nodejs/node/issues/53946
PR-URL: https://github.com/nodejs/node/pull/58192
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-05-28 10:15:37 +00:00
Giovanni Bucci
5a23443104
repl: extract and standardize history from both repl and interface
...
PR-URL: https://github.com/nodejs/node/pull/58225
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com >
2025-05-28 07:38:39 +00:00
Tobias Nießen
affec481e8
test: remove --no-warnings flag
...
This change should have no effect since the test does not appear to
emit any warnings. If there are warnings, we probably should handle
them properly instead of passing this flag to the runtime.
Refs: https://github.com/nodejs/node/pull/35093
PR-URL: https://github.com/nodejs/node/pull/58424
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2025-05-27 08:36:59 +00:00
Joe
e7255b6bab
test: add tests ensuring worker threads cannot access internals
...
Refs: https://github.com/nodejs/node/pull/57804#discussion_r2079257457
Refs: https://github.com/nodejs/node/pull/57804#issuecomment-2863740780
PR-URL: https://github.com/nodejs/node/pull/58332
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com >
2025-05-26 22:18:34 +00:00
Dario Piotrowicz
d5abfbf582
lib: add module to use in module deprecation warnings
...
PR-URL: https://github.com/nodejs/node/pull/58442
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2025-05-26 14:39:25 +00:00
James M Snell
19e0d47272
test: add disposable histogram test
...
PR-URL: https://github.com/nodejs/node/pull/58384
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2025-05-25 18:15:13 -07:00
James M Snell
73471bdb6a
util: add 'none' style to styleText
...
For cases where the style is not needed but code still calls styleText
unconditionally, this adds a `none` style that not not apply any styling
to the text.
PR-URL: https://github.com/nodejs/node/pull/58437
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2025-05-25 18:13:34 -07:00
James M Snell
d968227050
test: add test for async disposable worker thread
...
PR-URL: https://github.com/nodejs/node/pull/58385
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2025-05-25 18:06:54 -07:00
0hm☘️
62855f3b8c
stream: making DecompressionStream spec compilent for trailing junk
...
Introduce `ERR_TRAILING_JUNK_AFTER_STREAM_END`
error to handle unexpected data after the end of
a compressed stream. This ensures proper error
reporting when decompressing deflate or gzip
streams with trailing junk. Added tests to
verify the behavior.
Fixes: https://github.com/nodejs/node/issues/58247
PR-URL: https://github.com/nodejs/node/pull/58316
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com >
2025-05-26 00:38:39 +00:00
Colin Ihrig
e201299011
sqlite: handle thrown errors in result callback
...
This commit updates the aggregate function 'result' callback
handling to not crash when an exception is thrown.
Fixes: https://github.com/nodejs/node/issues/58425
PR-URL: https://github.com/nodejs/node/pull/58426
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com >
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2025-05-25 21:49:37 +00:00
Darshan Sen
c3b580d9f0
http2: add diagnostics channel 'http2.server.stream.created'
...
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/58390
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-05-25 13:22:05 +00:00
Shelley Vohr
cf5cbffbbc
test: leverage process.features.openssl_is_boringssl in test
...
PR-URL: https://github.com/nodejs/node/pull/58421
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2025-05-24 13:58:11 +00:00
Joyee Cheung
e9c6004a2d
test: fix test-buffer-tostring-range on allocation failure
...
If the test cannot allocate a buffer over 4GB, there is no point
continue testing toString() on it.
This also split the test case to a different file for clarity and
reduce interference with other cases.
PR-URL: https://github.com/nodejs/node/pull/58416
Fixes: https://github.com/nodejs/node/issues/56726
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com >
2025-05-23 21:13:39 +00:00
Joyee Cheung
996a774eba
test: skip in test-buffer-tostring-rangeerror on allocation failure
...
If the buffer allocation fails due to insufficient memory, there is no
point continue testing toString().
PR-URL: https://github.com/nodejs/node/pull/58415
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-05-23 21:02:37 +00:00
Dario Piotrowicz
cd68e35704
lib: deprecate _stream_* modules
...
PR-URL: https://github.com/nodejs/node/pull/58337
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Mattias Buelens <mattias@buelens.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2025-05-23 13:48:24 +00:00
Shelley Vohr
5ffcf6bca1
test: make crypto tests work with BoringSSL
...
PR-URL: https://github.com/nodejs/node/pull/58117
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2025-05-22 11:26:56 +00:00
Shelley Vohr
2b425345fe
crypto: expose crypto.constants.OPENSSL_IS_BORINGSSL
...
PR-URL: https://github.com/nodejs/node/pull/58387
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-05-22 11:04:16 +00:00
Tobias Nießen
53944c4462
test: test reordering of setAAD and setAuthTag
...
This test, so far, has been ensuring that `setAuthTag()` can be called
either before or after `update()`. This commit expands the test to
ensure that `setAuthTag()` can be called before, between, or after calls
to `setAAD()` and `update()`, and it also covers scenarios in which
`update()` is never called (e.g., in case of GMAC).
PR-URL: https://github.com/nodejs/node/pull/58396
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2025-05-21 21:36:37 +00:00
Tobias Nießen
283ed5357f
test: do not skip OCB decryption in FIPS mode
...
I believe that OCB should work in FIPS mode, and only CCM should be
skipped here.
PR-URL: https://github.com/nodejs/node/pull/58382
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-05-21 00:38:15 +00:00
Joyee Cheung
0bbe5d34e7
test: show more information in test-http2-debug upon failure
...
Use spawnSyncAndAssert() so that the stderr is logged when it
doesn't match expectations.
PR-URL: https://github.com/nodejs/node/pull/58391
Refs: https://github.com/nodejs/node/issues/58353
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-05-20 19:00:50 +00:00
Chengzhong Wu
b395420a99
inspector: add protocol method Network.dataReceived
...
PR-URL: https://github.com/nodejs/node/pull/58001
Refs: https://github.com/nodejs/node/issues/53946
Refs: https://github.com/nodejs/undici/issues/4166
Reviewed-By: James M Snell <jasnell@gmail.com >
2025-05-19 14:57:27 +00:00
Tobias Nießen
eab4ccfade
test: remove loop over single element
...
This loop used to iterate over two elements, but since commit
215f4d04b7 , it only iterates over
a single element. Therefore, move the test out of the loop body
and remove the loop itself.
Refs: https://github.com/nodejs/node/pull/50973
PR-URL: https://github.com/nodejs/node/pull/58368
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2025-05-19 13:24:07 +00:00
Ruben Bridgewater
35180bafd7
path: improve path.resolve() performance when used as process.cwd()
...
`path.resolve()` and `path.resolve('.')` is frequently called as
alternative to process.cwd(). This minimized overhead for these
specific cases.
PR-URL: https://github.com/nodejs/node/pull/58362
Reviewed-By: Jordan Harband <ljharb@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com >
2025-05-19 13:23:57 +00:00
Tobias Nießen
1ef99237f5
test: add chacha20-poly1305 to auth tag order test
...
Add ChaCha20-Poly1305 to the algorithms for which we ensure that the
authentication tag can be set either before or after calling `update()`.
PR-URL: https://github.com/nodejs/node/pull/58367
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2025-05-19 11:21:08 +00:00
Jacopo Martinelli
38757c906d
test_runner: add level parameter to reporter.diagnostic
...
Added a parameter to allow severity-based formatting for
diagnostic messages. Defaults to 'info'.
This update enables better control over message presentation
(e.g., coloring) based on severity levels such as 'info', 'warn',
and 'error'.
Refs: https://github.com/nodejs/node/issues/55922
PR-URL: https://github.com/nodejs/node/pull/57923
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2025-05-19 08:28:05 +00:00
Darshan Sen
7c74205aa7
http2: add diagnostics channel 'http2.client.stream.close'
...
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/58329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2025-05-19 08:12:41 +00:00
Tobias Nießen
61aecf2e58
test: remove references to create(De|C)ipher
...
Both `createCipher()` and `createDecipher()` were removed in Node.js 22.
PR-URL: https://github.com/nodejs/node/pull/58363
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-05-18 22:34:16 +00:00
Dario Piotrowicz
39ab68b2c1
readline: add stricter validation for functions called after closed
...
PR-URL: https://github.com/nodejs/node/pull/58283
Fixes: https://github.com/nodejs/node/issues/57678
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-05-18 19:46:38 +00:00
Darshan Sen
9eb9c26b26
net: always publish to 'net.client.socket' diagnostics channel
...
Previously, the 'net.client.socket' diagnostics channel was only
published to when `net.connect()` was called. This change ensures the
message is also published for the following calls:
- net.createConnection()
- net.Socket#connect()
- tls.connect()
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/58349
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: theanarkh <theratliter@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
2025-05-18 09:05:17 +00:00
Darshan Sen
ccf227eac8
http2: add diagnostics channel 'http2.client.stream.finish'
...
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/58317
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-05-18 13:04:59 +05:30
LiviaMedeiros
c7b18412a0
stream: test explicit resource management implicitly
...
PR-URL: https://github.com/nodejs/node/pull/58296
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-05-17 04:41:15 +00:00
Chengzhong Wu
a436f7b492
fs: unexpose internal constants
...
`EXTENSIONLESS_FORMAT_JAVASCRIPT` and `EXTENSIONLESS_FORMAT_WASM` are
only used internally through binding `getFormatOfExtensionlessFile`.
They should not be exposed publicly.
PR-URL: https://github.com/nodejs/node/pull/58327
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2025-05-16 19:40:17 +00:00
Darshan Sen
8053a5c1c7
http2: add diagnostics channel 'http2.client.stream.error'
...
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/58306
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
2025-05-16 12:15:50 +00:00
Chengzhong Wu
1d0b4e8b91
vm: import call should return a promise in the current context
...
A `import` call should returns a promise created in the context where
the `import` was called, not the context of `importModuleDynamically`
callback.
PR-URL: https://github.com/nodejs/node/pull/58309
Fixes: https://github.com/nodejs/node/issues/53575
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2025-05-16 07:43:48 +00:00