Roman Reiss
82b0783519
src,doc,test: Fix common misspellings
...
PR-URL: https://github.com/nodejs/node/pull/18151
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2018-01-16 23:44:27 +01:00
Andreas Madsen
07a4fa3dbe
async_hooks: deprecate undocumented API
...
PR-URL: https://github.com/nodejs/node/pull/16972
Refs: https://github.com/nodejs/node/issues/14328
Refs: https://github.com/nodejs/node/issues/15572
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2017-11-20 12:03:06 +01:00
Jared Kantrowitz
80ebb4282d
src: adjust windows abort behavior
...
Raising SIGABRT is handled in the CRT in windows, calling _exit()
with ambiguous code "3" by default.
This adjustment to the abort behavior gives a more sane exit code
on abort, by calling _exit directly with code 134.
PR-URL: https://github.com/nodejs/node/pull/13947
Fixes: https://github.com/nodejs/node/issues/12271
Refs: https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/abort
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2017-08-07 22:46:01 -04:00
Andreas Madsen
4e27aa9603
async_hooks: use common emitBefore and emitAfter
...
Timers and nextTick have special emitBefore and emitAfter functions for
historic reasons. These function are not needed any more, thus the
public emitBefore and emitAfter function can be used.
PR-URL: https://github.com/nodejs/node/pull/14050
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2017-07-06 23:50:08 +02:00
Refael Ackermann
32c7f114c5
test: improve async-hooks/test-callback-error
...
PR-URL: https://github.com/nodejs/node/pull/13559
Fixes: https://github.com/nodejs/node/issues/13527
Reviewed-By: Andreas Madsen <amwebdk@gmail.com >
2017-06-21 06:13:04 -04:00
Andreas Madsen
de762b71f2
async_hooks: rename currentId and triggerId
...
currentId is renamed to executionAsyncId
triggerId is renamed to triggerAsyncId
AsyncResource.triggerId is renamed to AsyncResource.triggerAsyncId
AsyncHooksGetCurrentId is renamed to AsyncHooksGetExecutionAsyncId
AsyncHooksGetTriggerId is renamed to AsyncHooksGetTriggerAsyncId
PR-URL: https://github.com/nodejs/node/pull/13490
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2017-06-14 12:39:53 +02:00
Rich Trott
a08b59f2a6
test: refactor async-hooks test-callback-error
...
Two child processes have their logic in a switch statement and a third
uses an `if` statement to detect it. Move all three child process tasks
into switch statement.
PR-URL: https://github.com/nodejs/node/pull/13554
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: David Cai <davidcai1993@yahoo.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com >
2017-06-11 11:20:31 -07:00
David Cai
35353a45fc
test: increase coverage of async_hooks
...
PR-URL: https://github.com/nodejs/node/pull/13336
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Andreas Madsen <amwebdk@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2017-06-07 11:02:47 +08:00
Roman Reiss