 Ruben Bridgewater
|
1fc373bdf6
|
Revert "repl: refactor tests to not rely on timing"
This reverts commit de848ac1e0.
The commit broke multiline repl.
PR-URL: https://github.com/nodejs/node/pull/18715
Refs: https://github.com/nodejs/node/pull/17828
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
2018-02-12 15:42:06 +01:00 |
|
|
Bradley Farias
|
de848ac1e0
|
repl: refactor tests to not rely on timing
Tests relying on synchronous timing have been migrated to use events.
PR-URL: https://github.com/nodejs/node/pull/17828
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
2018-02-10 14:19:54 +01:00 |
|
|
Sebastiaan Deckers
|
bb29405904
|
lib,src: fix consistent spacing inside braces
PR-URL: https://github.com/nodejs/node/pull/14162
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
|
2017-07-21 15:13:47 -04:00 |
|
|
Anna Henningsen
|
64d0a73574
|
test: minor fixups for REPL eval tests
The `process.on("exit")` event handlers are unnecessary, so it’s okay
to drop them.
PR-URL: https://github.com/nodejs/node/pull/11946
Ref: https://github.com/nodejs/node/pull/11871
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
2017-03-22 09:17:34 -07:00 |
|
|
Prince J Wesley
|
9366b8d90a
|
repl: preprocess only for defaultEval
Code preprocessing is applicable only for default
eval function. Therefore, Moved `preprocess` function
invocation inside `defaultEval` function.
Fixes: https://github.com/nodejs/node/issues/9743
PR-URL: https://github.com/nodejs/node/pull/9752
Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
2016-12-05 19:30:56 +05:30 |
|
|
Rich Trott
|
90451a67ca
|
test: minimal repl eval option test
Fixes: https://github.com/nodejs/node/issues/3544
PR-URL: https://github.com/nodejs/node/pull/5192
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
|
2016-02-12 13:41:22 -08:00 |
|