BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
35,276 Commits 266 Branches 972 Tags
59558807ceeb84eef6f2f736a440caec5d4a8eee
Commit Graph
142 Commits
Author SHA1 Message Date
Mestery 665b404e65 build: improve readability of texts in workflows 
PR-URL: https://github.com/nodejs/node/pull/40988
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-12-19 16:12:57 +00:00
Antoine du Hamel 10df3af981 tools: fix CQ and auto-start-ci jobs 
PR-URL: https://github.com/nodejs/node/pull/41230
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-12-18 06:07:22 -08:00
Antoine du Hamel 587b167cc4 tools: fix GitHub Actions status when CQ is empty 
Refs: https://github.com/nodejs/node/pull/40985#issuecomment-995252065

PR-URL: https://github.com/nodejs/node/pull/41193
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-12-18 01:52:54 +00:00
Rich Trott 41e1de6f40 build,tools: automate enforcement of emeritus criteria 
PR-URL: https://github.com/nodejs/node/pull/41155
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gus Caplan <me@gus.host>
 2021-12-15 21:38:35 +00:00
Mestery 6267e55685 build: fix comment-labeled workflow 
Refs: https://github.com/nodejs/node/pull/40985#issuecomment-994056146

PR-URL: https://github.com/nodejs/node/pull/41176
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-12-14 23:09:12 +00:00
Mestery f404cd5ce2 build: use gh cli in workflows file 
PR-URL: https://github.com/nodejs/node/pull/40985
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-12-14 19:06:36 +00:00
Rich Trott 73fe15bf24 build: fix commit-queue-rebase functionality 
For commit-queue-rebase only, commit-queue.sh uses `git push` which
requires the credentials from the git checkout. Remove
`persist-credentials: false` from this workflow.

PR-URL: https://github.com/nodejs/node/pull/41140
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-12-11 11:00:00 +00:00
Rich Trott 781408f377 build: fail early in test-macos.yml 
PR-URL: https://github.com/nodejs/node/pull/41035
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-12-03 21:29:24 -08:00
Rich Trott 71c04b12a6 build: add tools/doc to tools.yml updates 
PR-URL: https://github.com/nodejs/node/pull/41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
 2021-12-02 13:14:22 -08:00
Antoine du Hamel d81f328aa5 tools: ignore unrelated workflow changes in slow Actions tests 
Changes in the workflow files never affect the node binary, running
build tasks seems unnecessary.

Refs: https://github.com/nodejs/node/pull/40928

PR-URL: https://github.com/nodejs/node/pull/40990
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-11-30 19:11:16 +00:00
Mestery 6b202cc383 build: update Actions versions 
PR-URL: https://github.com/nodejs/node/pull/40987
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-11-30 19:11:07 +00:00
Rich Trott 6fd0a60d60 tools: update ESLint update script to consolidate dependencies 
PR-URL: https://github.com/nodejs/node/pull/40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-11-29 14:52:36 -08:00
Rich Trott 1217087110 build: set persist-credentials: false on workflows 
Out of extra caution, instruct `actions/checkout` to not save GitHub
authentication credentials in the git config for use by future steps.

PR-URL: https://github.com/nodejs/node/pull/40972
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-11-27 22:12:26 +00:00
Rich Trott e64c66c1a9 build: ignore unrelated workflow changes in slow Actions tests 
test-asan and test-macos are very slow and tend to get backed up. While
I'm literally waiting hours right now for test-macos to finish so I can
land a PR, I'm opening this pull request to have it be skipped when
things other than its own workflow file are the only changes in the PR.

PR-URL: https://github.com/nodejs/node/pull/40928
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-11-27 01:18:37 +00:00
Antoine du Hamel 27b10881d3 tools: fix commit-lint GH Actions CI 
PR-URL: https://github.com/nodejs/node/pull/40845
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-11-25 12:14:40 -08:00
Rich Trott f7ac6ba60c tools: ping TSC members identified as inactive 
When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.

PR-URL: https://github.com/nodejs/node/pull/40915
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
 2021-11-24 18:33:04 +00:00
Rich Trott 516e29d8cf build: fix branch name for lint-md-dependencies update 
Refs: https://github.com/nodejs/node/runs/4288412090?check_suite_focus=true

PR-URL: https://github.com/nodejs/node/pull/40924
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-11-22 23:26:45 +00:00
Rich Trott bad6526a00 build: fix make invocation in tools.yml 
Be in the correct directory for `make lint-md-rollup`.

PR-URL: https://github.com/nodejs/node/pull/40890
Refs: https://github.com/nodejs/node/runs/4270533399?check_suite_focus=true
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-11-22 05:01:56 +00:00
Rich Trott 129c12e252 tools: add find-inactive-tsc 
Automate the implementation of rules in the TSC Charter around automatic
removal of members who do not participate in TSC votes and attend fewer
than 25% of the meetings in a 3-month period.

PR-URL: https://github.com/nodejs/node/pull/40884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-11-21 15:10:04 +00:00
Rich Trott e0233fc7dc build: fix tools.yml errors 
PR-URL: https://github.com/nodejs/node/pull/40870
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-11-19 09:18:06 +00:00
Antoine du Hamel 9cd30894f6 tools: only validate first commit message of a PR 
PR-URL: https://github.com/nodejs/node/pull/40740
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-11-12 23:35:22 +01:00
Rich Trott e8d16eee26 build: add GitHub Action to update tools modules 
Update ESLint, Babel, remark, and so on. Run once a week.

PR-URL: https://github.com/nodejs/node/pull/40644
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-11-08 11:47:51 -08:00
Michaël Zasso 873119385f tools: simplify and fix commit queue 
Use `gh` CLI for CI and commit queue jobs, and use the correct token
to merge PRs.

PR-URL: https://github.com/nodejs/node/pull/40742
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
 2021-11-07 15:26:45 +01:00
Antoine du Hamel 14825d63c0 tools: fix commit-lint workflow 
PR-URL: https://github.com/nodejs/node/pull/40673
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-11-01 19:57:30 +01:00
Antoine du Hamel b5aa08d2f9 tools: avoid fetch extra commits when validating commit messages 
PR-URL: https://github.com/nodejs/node/pull/39128
Reviewed-By: Mary Marchini <oss@mmarchini.me>
 2021-10-30 17:45:25 +02:00
Rich Trott 8eebc33c02 build: skip long-running Actions for README-only modifications 
If the only file modified is README.md do not run test-linux or
build-windows tasks. This will help streamline onboarding sessions but
may help some other cases too.

PR-URL: https://github.com/nodejs/node/pull/40571
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-10-24 19:01:18 +00:00
Mestery ed76b49834 build: fix actions pull request's branch 
PR-URL: https://github.com/nodejs/node/pull/40494
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-10-18 15:32:55 +02:00
Jiawen Geng 6baea14506 build: avoid run find inactive authors on forked repo 
PR-URL: https://github.com/nodejs/node/pull/40465
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-10-15 18:30:17 +00:00
FrankQiu 983b757f3f build: update codeowners-validator to 0.6 
PR-URL: https://github.com/nodejs/node/pull/40307
Reviewed-By: Mary Marchini <oss@mmarchini.me>
 2021-10-13 11:31:04 +00:00
Rich Trott 73c3885e10 build: remove duplicate check for authors.yml 
update-authors.js will print if there are duplicates in the new entries
so we can remove the (not working) duplication check in the authors.yml
file. It would still be nice to get the information about duplicates
into the body of the GitHub PR so no one has to manually check for
duplicates (by either examining the file or looking at the Actions
output), but that can be a future improvement.

PR-URL: https://github.com/nodejs/node/pull/40393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-10-12 01:48:33 +00:00
FrankQiu 7752088ef6 build: support Python 3.10.0 
PR-URL: https://github.com/nodejs/node/pull/40296
Fixes: https://github.com/nodejs/node/issues/40294
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-10-06 17:07:07 -07:00
Rich Trott 2a3a9b8b71 build: check for duplicates in new AUTHORS entries 
When the GitHub Action adds new entries to the AUTHORS file, have it
also flag new entries that might be duplicates.

PR-URL: https://github.com/nodejs/node/pull/40264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-10-03 20:44:01 +00:00
Jiawen Geng 35d9222f30 build: limit update authors CI scope 
PR-URL: https://github.com/nodejs/node/pull/40219
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-09-27 00:28:16 +00:00
Rich Trott 8d83c47029 tools: re-implement lint-md without unified-args 
`unified-args` ignores settings in the preset, expecting them to be in
remarkrc files or passed on the command line instead. Realizing that
we always send the same configuration options via the command-line
anyway, this removes `unified-args`. This means the preset settings are
now respected and it removes nearly 30000 lines of code in the resulting
rollup file.

I wasn't sure I was going to want to keep rollup so I started
re-implementing this without it, but ended up putting a minimal rollup
back as it still saves about 90000 lines of code vs. checking in
`node_modules`.

PR-URL: https://github.com/nodejs/node/pull/40180
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-25 03:51:52 +00:00
SURYAPRATAP SINGH SURYAVANSHI c7da13c7c4 build: fix "test-internet.yml" workflows 
PR-URL: https://github.com/nodejs/node/pull/40177
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-09-22 15:30:57 -07:00
Michaël Zasso f367af4434 tools: extend default yamllint config 
PR-URL: https://github.com/nodejs/node/pull/40150
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-21 17:03:51 +00:00
Rich Trott 3decfa75d2 build: run modified internet tests on GitHub Actions 
If internet tests are modified in a pull request, run the internet tests
in GitHub Actions.

PR-URL: https://github.com/nodejs/node/pull/40100
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-09-16 22:42:53 +00:00
Rich Trott 0f1765e134 build: add .mailmap/AUTHORS to paths-ignore for test-macos 
PR-URL: https://github.com/nodejs/node/pull/40109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-16 16:40:50 +00:00
Rich Trott 884b478624 build: add .mailmap/AUTHORS to path-ignore for test-asan 
PR-URL: https://github.com/nodejs/node/pull/40109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-16 16:40:49 +00:00
Rich Trott ecb6c84832 build: add paths-ignore for build-tarball workflow 
In GitHub Actions, don't run build-tarball if the only changed files are
docs.

PR-URL: https://github.com/nodejs/node/pull/40109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-16 16:40:48 +00:00
Michaël Zasso 798c0cb6bc build: only lint version numbers for pull requests 
Fixes: https://github.com/nodejs/node/issues/39850

PR-URL: https://github.com/nodejs/node/pull/40027
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-09-15 06:50:45 +00:00
Rich Trott ed556c0ddd build: add daily/on-demand internet test workflow 
PR-URL: https://github.com/nodejs/node/pull/40086
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-09-13 18:41:55 +00:00
Jiawen Geng 513a979b44 deps: patch for v8 on windows 
PR-URL: https://github.com/nodejs/node/pull/40010
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-09-09 06:36:50 +00:00
Rich Trott b016d5dffc build: add YAML linting to GitHub Actions 
PR-URL: https://github.com/nodejs/node/pull/40007
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-09-07 13:54:10 +00:00
Rich Trott 77c81cbc4a tools,build: update YAML files in preparation for linting 
Fix indentation, traiiling spaces, and missing newline issues in
preparation for linting.

PR-URL: https://github.com/nodejs/node/pull/40007
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-09-07 13:54:09 +00:00
Rich Trott 773a989708 build: run AUTHORS update weekly 
PR-URL: https://github.com/nodejs/node/pull/40004
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-09-07 13:54:00 +00:00
Michaël Zasso 95dffe727a Revert "build: add windows-2022 to GitHub test matrix" 
This reverts commit 13b569c679.

V8 9.3 is not compatible.

Refs: https://github.com/nodejs/node/issues/39976

PR-URL: https://github.com/nodejs/node/pull/39982
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-09-03 12:22:42 +00:00
Michaël Zasso 13b569c679 build: add windows-2022 to GitHub test matrix 
PR-URL: https://github.com/nodejs/node/pull/39857
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-09-01 23:11:35 +02:00
Rich Trott 5763d4723a build: fix find-inactive-collaborators workflow token 
Use a token that will result in GitHub CI running on the pull requests
that this workflow opens.

PR-URL: https://github.com/nodejs/node/pull/39909
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-30 23:42:04 +00:00
Rich Trott e8718b2c64 build: update token used for pull requests 
Refs: https://github.com/nodejs/node/pull/39874#issuecomment-905538468

PR-URL: https://github.com/nodejs/node/pull/39907
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-30 23:41:55 +00:00