Rich Trott
1217087110
build: set persist-credentials: false on workflows
...
Out of extra caution, instruct `actions/checkout` to not save GitHub
authentication credentials in the git config for use by future steps.
PR-URL: https://github.com/nodejs/node/pull/40972
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-11-27 22:12:26 +00:00
Antoine du Hamel
27b10881d3
tools: fix commit-lint GH Actions CI
...
PR-URL: https://github.com/nodejs/node/pull/40845
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-11-25 12:14:40 -08:00
Antoine du Hamel
9cd30894f6
tools: only validate first commit message of a PR
...
PR-URL: https://github.com/nodejs/node/pull/40740
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-11-12 23:35:22 +01:00
Antoine du Hamel
14825d63c0
tools: fix commit-lint workflow
...
PR-URL: https://github.com/nodejs/node/pull/40673
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-11-01 19:57:30 +01:00
Antoine du Hamel
b5aa08d2f9
tools: avoid fetch extra commits when validating commit messages
...
PR-URL: https://github.com/nodejs/node/pull/39128
Reviewed-By: Mary Marchini <oss@mmarchini.me >
2021-10-30 17:45:25 +02:00
Rich Trott
d6bb7ed6c8
build: use lts shorthand in GitHub Actions
...
Rather than hard-coding GitHub Actions to use Node.js 14.x, use the
`lts/*` shorthand for "most recent LTS version".
PR-URL: https://github.com/nodejs/node/pull/39538
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-07-29 04:57:11 +00:00
Rich Trott
fc6de093e2
build: use Node.js 14 in commit-lint.yml
...
All of our workflows use Node.js 14.x or 16.x except for commit-lint.yml
which has 12.x hard-coded. Update it to 14.x and change it to using an
environment variable so it is consistent with our other workflows.
PR-URL: https://github.com/nodejs/node/pull/39506
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-07-26 07:52:14 -07:00
Rich Trott
bfc07ef6a5
build: update to setup-node@v2
...
commit-lint.yml uses setup-node@v1 but all our other GitHub Actions use
v2. Update commit-lint.yml.
PR-URL: https://github.com/nodejs/node/pull/39366
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-07-14 12:23:29 -07:00
Mary Marchini
e0ebc6b30d
build: fix commit linter on unrebased PRs
...
The commit linter was checking out the PR HEAD commit instead of
merge/rebase commit, causing it to fail for any PRs that were not
rebased on our default branch. Removing `ref` should fix the issue.
PR-URL: https://github.com/nodejs/node/pull/39121
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-06-22 15:45:03 -07:00
Matheus Marchini
53a63deadf
build: use Actions to validate commit message
...
Actions interface has a better integration with GitHub, and with
Annotations and Problem Matcher we can display all failed checks in a
single place, so that users don't have to go through the logs to figure
out what's wrong. Since the job on Travis was allowed to fail and is not
as easy to read, remove it from our Matrix.
The Action will check every commit in the Pull Request, skipping commits
with "fixup" or "squash".
PR-URL: https://github.com/nodejs/node/pull/32417
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2021-06-22 10:20:59 -07:00
Rich Trott