Rich Trott
55ceaec111
tools,benchmark,lib,test: enable no-case-declarations lint rule
...
PR-URL: https://github.com/nodejs/node/pull/41385
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Ricky Zhou <0x19951125@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2022-01-05 07:42:19 -08:00
Rich Trott
e7d4e6b680
tools: remove conditional assignment in custom ESLint rule
...
These changes no-duplicate-require.js so that it doesn't use an
assignment in a conditional, which can be easy to misread as a
comparison rather than an assignment. It also means we change a do/while
(which we don't use much in our code) to the much more common while
construct.
PR-URL: https://github.com/nodejs/node/pull/41325
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-01-05 06:11:29 -08:00
Node.js GitHub Bot
1344b36fe3
tools: update lint-md-dependencies to @rollup/plugin-node-resolve@13.1.2
...
PR-URL: https://github.com/nodejs/node/pull/41369
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-01-05 11:54:02 +01:00
Node.js GitHub Bot
513e9fd0b6
tools: update doc to rehype-raw@6.1.1
...
PR-URL: https://github.com/nodejs/node/pull/41367
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2022-01-04 19:34:36 -08:00
Rich Trott
5f07d00c60
tools: remove last of error-masking in commit-queue.sh
...
Remove the lats of the unintentional error-masking in commit-queue.sh.
With this change, `tools/lint-sh.js . --from-npx` at last passes.
PR-URL: https://github.com/nodejs/node/pull/41356
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-01-01 17:25:36 +00:00
Node.js GitHub Bot
9b637ca255
tools: update eslint to 8.6.0
...
PR-URL: https://github.com/nodejs/node/pull/41368
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-01-01 17:25:28 +00:00
Rich Trott
e7a924e086
tools: do not mask errors on multiple commit retrieval
...
In commit-queue.sh, the assignment to `commits` will succeed and the
script will continue if one of the two `git` commands fails, even with
`-e` set. Split it into three separate assignments so that failures in
the `git` commands will be clearly logged and cause the script to exit
with a failure status code.
PR-URL: https://github.com/nodejs/node/pull/41340
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
2021-12-30 05:57:57 +00:00
Benjamin Gruenbaum and Robert Nagy
b97b81d4ec
stream: add map method to Readable
...
Implement the map method on readable stream. This starts the alignment
with the tc39-iterator-helpers proposal and adds a `.map` method to
every Node.js readable stream.
Co-Authored-By: Robert Nagy <ronag@icloud.com >
PR-URL: https://github.com/nodejs/node/pull/40815
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2021-12-29 20:32:36 +01:00
Rich Trott
e4aa575b05
tools: improve section tag additions in HTML doc generator
...
There is an edge case involving GFM footnotes where our current code
adds an empty section which results in a warning (but not an error) in
HTML validators. This change causes the HTML generator to skip the
unnecessary addition of a section tag in that one edge case.
PR-URL: https://github.com/nodejs/node/pull/41318
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2021-12-27 20:13:22 +00:00
Rich Trott
67cd4a61ac
tools: simplify commit-queue.sh merge command
...
The mergeUrl() function is only used in one place. It's a one-liner and
inlining it makes the script easier to understand, I think. It also
means no future shellcheck complaints about needing to add error
handling.
PR-URL: https://github.com/nodejs/node/pull/41314
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2021-12-27 14:48:07 +00:00
Node.js GitHub Bot
4624cef455
tools: update lint-md-dependencies to rollup@2.62.0
...
PR-URL: https://github.com/nodejs/node/pull/41315
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-12-27 14:47:57 +00:00
Rich Trott
b330ab86a4
tools: use Object.hasOwn() in alljson.mjs
...
Replace hasOwnProperty() with Object.hasOwn().
PR-URL: https://github.com/nodejs/node/pull/41306
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-12-26 02:24:34 +00:00
Rich Trott
83f442a1fa
tools: avoid generating duplicate id attributes
...
In all.html, we currently generate hundreds of duplicate id attributes
because of conflicts between the way allhtml.mjs prefixes in-page links
with the module name on the one hand, and the existence of legacy id
attributes hardcoded into the page on the other hand.
This prefaces the module name with `all_` to avoid the conflicts.
PR-URL: https://github.com/nodejs/node/pull/41291
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-12-25 05:59:33 +00:00
Rich Trott
5cc4b69fd4
tools: be intentional about masking possible error in start-ci.sh
...
Revise start-ci.sh to conform with shellcheck 0.8.0 default checks.
Refs: https://www.shellcheck.net/wiki/SC2312
PR-URL: https://github.com/nodejs/node/pull/41284
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-12-24 19:25:06 +00:00
Rich Trott
2b63dfe423
tools: use {N} for spaces in regex
...
Spaces are hard to count. Use {N} notation to indicate how many spaces
in regular expressions in find-inactive-collaborators.
PR-URL: https://github.com/nodejs/node/pull/41295
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-12-23 23:19:19 +00:00
Rich Trott
f72c1978e0
tools: consolidate update-authors.js logic
...
Use a single regex and fewer logical branches in the code.
PR-URL: https://github.com/nodejs/node/pull/41255
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2021-12-23 06:46:26 +00:00
Rich Trott
1c6d81edaf
tools: update doc dependency mdast-util-gfm-table to 1.0.2
...
This fixes a bug that causes our tooling to generate invalid HTML. (The
`align` attribute on `tr` and `td` elements was ending up with the
invalid value of `"none"`.)
Refs: https://github.com/remarkjs/remark-gfm/issues/29
Refs: https://github.com/syntax-tree/mdast-util-gfm-table/commit/a28b860c8930088c32edf96e42b0e72787d473d1
PR-URL: https://github.com/nodejs/node/pull/41260
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-12-23 00:00:23 +00:00
Rich Trott
83dfa6e4ba
tools: make license-builder.sh comply with shellcheck 0.8.0
...
Fixes for SC2312 added in shellcheck 0.8.0.
PR-URL: https://github.com/nodejs/node/pull/41258
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2021-12-22 14:38:13 +00:00
Rich Trott
27c6fdf3b2
tools: use arrow function for callback in lint-sh.js
...
The function declaration inside an else block is odd (and violates a
recommended ESLint rule). We tend to use arrow functions for callbacks
anyway, so switch to that.
PR-URL: https://github.com/nodejs/node/pull/41256
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-12-22 10:44:09 +00:00
Rich Trott
9e1a08057a
tools: add double-quotes to make-v8.sh
...
This is not being flagged in CI because (I'm guessing) shellcheck in CI
is 0.7.0 but latest is 0.8.0.
PR-URL: https://github.com/nodejs/node/pull/41257
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-12-22 03:49:56 +00:00
Node.js GitHub Bot
94d493896e
tools: update eslint to 8.5.0
...
PR-URL: https://github.com/nodejs/node/pull/41228
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2021-12-19 15:28:41 +00:00
Rich Trott
29f714b152
lib,tools: remove empty lines between JSDoc tags
...
This is in preparation for enabling a recommended JSDoc lint rule.
PR-URL: https://github.com/nodejs/node/pull/41147
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-12-19 05:30:09 +00:00
Node.js GitHub Bot
26d2f0b4ee
tools: update lint-md-dependencies to @rollup/plugin-node-resolve@13.1.1
...
PR-URL: https://github.com/nodejs/node/pull/41227
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-12-18 16:57:49 +00:00
Robert Nagy
752d75d8bc
stream: add isErrored helper
...
Refs: https://github.com/nodejs/undici/pull/1134
PR-URL: https://github.com/nodejs/node/pull/41121
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
2021-12-16 14:28:31 +01:00
Cheng Zhao
e56bf500c7
build: use '<(python)' instead of 'python'
...
PR-URL: https://github.com/nodejs/node/pull/41146
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2021-12-16 02:10:14 +00:00
Rich Trott
41e1de6f40
build,tools: automate enforcement of emeritus criteria
...
PR-URL: https://github.com/nodejs/node/pull/41155
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Stewart X Addison <sxa@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Gus Caplan <me@gus.host >
2021-12-15 21:38:35 +00:00
Node.js GitHub Bot
bc6072e28b
tools: update doc to remark-rehype@10.1.0
...
PR-URL: https://github.com/nodejs/node/pull/41149
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-12-13 14:29:24 +01:00
Node.js GitHub Bot
ad91abcbad
tools: update lint-md-dependencies to rollup@2.61.1 vfile-reporter@7.0.3
...
PR-URL: https://github.com/nodejs/node/pull/41150
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-12-12 18:43:52 -08:00
Rich Trott
03c9837457
tools: update ESLint to 8.4.1
...
PR-URL: https://github.com/nodejs/node/pull/41114
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2021-12-10 10:26:57 +00:00
Rich Trott
8aa3ce8b59
doc,lib,tools: align multiline comments
...
These changes are in preparation for enabling a JSDoc lint rule.
PR-URL: https://github.com/nodejs/node/pull/41109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-12-09 08:31:35 -08:00
Rich Trott
c93a639788
tools: strip comments from lint-md rollup output
...
Refs: https://github.com/nodejs/node/pull/41081#issuecomment-986259228
PR-URL: https://github.com/nodejs/node/pull/41092
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
2021-12-07 23:34:13 +00:00
Rich Trott
32f7218388
tools: update highlight.js to 11.3.1
...
PR-URL: https://github.com/nodejs/node/pull/41091
Fixes: https://github.com/nodejs/node/issues/41077
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-12-07 09:24:40 -08:00
Michaël Zasso
ca353de05f
build: re-enable V8 concurrent marking
...
It was unintentionally disabled during a V8 update.
Fixes: https://github.com/nodejs/node/issues/41012
PR-URL: https://github.com/nodejs/node/pull/41013
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-12-06 08:22:34 +01:00
Luigi Pinca
42b51afb75
tools: update ESLint to 8.4.0
...
PR-URL: https://github.com/nodejs/node/pull/41085
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is >
2021-12-06 06:56:36 +00:00
Jonah Snider
6ef6bdf1fd
build: add --without-corepack
...
PR-URL: https://github.com/nodejs/node/pull/41060
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2021-12-05 10:23:25 +00:00
Richard Lau
c802c4b173
tools: rollback highlight.js
...
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.
PR-URL: https://github.com/nodejs/node/pull/41078
Refs: https://github.com/nodejs/node/issues/41077
Refs: https://github.com/nodejs/node/pull/41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-12-04 12:19:21 +00:00
Rich Trott
14d9c38c09
tools: remove Babel from license-builder.sh
...
Babel is now installed as a dependency in our ESLint installation. The
current license-builder.sh will fail to find the license for Babel.
The license is sill present in the repository/code base/file system. So
as with all other dependencies that are installed in
tools/node_modules/eslint/node_modules and have an MIT license, we are
still complying with the license. The inclusion in our own LICENSE was
to clearly signal that things under tools/node_modules/@babel were not
covered by the Node.js license. Because it is now under
tools/node_modules/eslint, that "we aren't the license-holders of this
code" aspect of things is already covered by the inclusion of the ESLint
license.
PR-URL: https://github.com/nodejs/node/pull/41049
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-12-03 14:56:52 +00:00
Rich Trott
42e13c2a10
tools: udpate packages in tools/doc
...
PR-URL: https://github.com/nodejs/node/pull/41036
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yash Ladha <yash@yashladha.in >
2021-12-02 13:14:19 -08:00
Rich Trott
e601c0d678
tools: install and enable JSDoc linting in ESLint
...
PR-URL: https://github.com/nodejs/node/pull/41027
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-12-01 20:00:17 -08:00
Rich Trott
df5e82bfd1
tools: include JSDoc in ESLint updating tool
...
PR-URL: https://github.com/nodejs/node/pull/41027
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-12-01 20:00:11 -08:00
Rich Trott
6d8ab767e4
tools: remove unneeded tool in update-eslint.sh
...
The tool to remove absolute paths from package.json files is no longer
necessary. It appears that npm no longer stores these paths, or at least
not in a way that causes the kind of churn we saw in the past.
PR-URL: https://github.com/nodejs/node/pull/40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-11-29 14:52:45 -08:00
Rich Trott
4c41fea7a7
tools: consolidate ESLint dependencies
...
PR-URL: https://github.com/nodejs/node/pull/40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-11-29 14:52:42 -08:00
Rich Trott
6fd0a60d60
tools: update ESLint update script to consolidate dependencies
...
PR-URL: https://github.com/nodejs/node/pull/40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-11-29 14:52:36 -08:00
Rich Trott
45422db074
tools: run ESLint update to minimize diff on subsequent update
...
PR-URL: https://github.com/nodejs/node/pull/40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-11-29 14:52:33 -08:00
Rich Trott
1e8b296c58
lib,test,tools: use consistent JSDoc types
...
This could be in preparation of implementing the jsdoc/check-types
ESLint rule.
PR-URL: https://github.com/nodejs/node/pull/40989
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2021-11-29 06:48:00 +00:00
Rich Trott
f7341e3f95
tools,test: make -J behavior default for test.py
...
PR-URL: https://github.com/nodejs/node/pull/40945
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2021-11-27 05:45:01 +00:00
Michaël Zasso
b3073f3737
tools: update gyp-next to v0.10.1
...
PR-URL: https://github.com/nodejs/node/pull/40934
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-11-26 06:23:46 +00:00
Rich Trott
78cc2bd2eb
build: remove extraneous quotation marks from commit body
...
Refs: https://github.com/nodejs/node/pull/40915#issuecomment-978562259
PR-URL: https://github.com/nodejs/node/pull/40963
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-11-25 08:44:55 +00:00
Rich Trott
f7ac6ba60c
tools: ping TSC members identified as inactive
...
When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.
PR-URL: https://github.com/nodejs/node/pull/40915
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
2021-11-24 18:33:04 +00:00
Node.js GitHub Bot
d9de812cb8
tools: update lint-md-dependencies to rollup@2.60.1
...
PR-URL: https://github.com/nodejs/node/pull/40929
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-11-22 21:39:53 -08:00