BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
31,915 Commits 266 Branches 972 Tags
59d578e1fcb5d9a3830e50bdf3e7da0336046292
Commit Graph
99 Commits
Author SHA1 Message Date
cclauss c8b950a7af build: gitHub actions: Python 3.9 and actions/setup-python@v2 
PR-URL: https://github.com/nodejs/node/pull/35521
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-10-09 03:36:15 +00:00
James M Snell dae283d96f crypto: refactoring internals, add WebCrypto 
Fixes: https://github.com/nodejs/node/issues/678
Refs: https://github.com/nodejs/node/issues/26854

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/35093
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-10-07 17:27:05 -07:00
Matteo Collina 492e260578 meta: add nodejs/streams to CODEOWNERS 
PR-URL: https://github.com/nodejs/node/pull/35411
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-10-04 09:34:39 +00:00
Joyee Cheung f826760be5 meta: add startup team in CODEOWNERS 
PR-URL: https://github.com/nodejs/node/pull/35406
Fixes: https://github.com/nodejs/node/issues/35215
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-10-03 10:44:24 +08:00
Mary Marchini 919be9196f build: fix CQ after latest ncu release 
The new behavior of node-core-utils (which fetches the merge commit
instead of fetching the patch files) requires the whole repo to be
cloned, instead of just the last commit.

PR-URL: https://github.com/nodejs/node/pull/35468
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
 2020-10-02 13:52:40 -07:00
Phillip Johnsen c24ad832bb build: increase API requests for stale action 
The second attempt at getting the auto closing of issues & PRs to work
as expected without hitting a maximum operations allowed error we've
been seeing.

Recently discovered that the mentioned error is actually self imposed
by the stale action itself. It keeps track of how many outgoing GitHub
API requests it performs, and if that count exceeds the configured
`operations-per-run` option, it exits to avoid hitting API rate limits.

Default `operations-per-run` value is set to `30`.

That's a very low limit and we're not at all concerned hitting that
rate limit as of now, so we're bumping `operations-per-run` to `500`
with these changes.

Refs https://github.com/nodejs/node/issues/35144

PR-URL: https://github.com/nodejs/node/pull/35235
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-09-17 11:54:28 -07:00
Phillip Johnsen 692910dd30 build: filter issues & PRs to auto close by matching on stalled label 
The auto closing of issues & PRs labelled with `stalled` doesn't seem
to be working as expected. The GitHub Action UI gives the impression
the stale action tries to execute more operations than it is allowed to
do.

Previously there was no filtering on issues & PRs. So when it tries to
fetch all the currently open issues, checking whether or not they should
be get closed, it would have to perform quite a few requests pagination
requests to get the information needed.

Knowing that we only care about issues & PRs already labelled `stalled`,
we can provide the [`only-labels`](https://github.com/actions/stale/blob/13b324e4b28a2708236aadb11361fa65af60d201/action.yml#L38)
option to make sure we only fetch relevant issues.

Refs https://github.com/nodejs/node/issues/35144

PR-URL: https://github.com/nodejs/node/pull/35159
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-09-13 21:56:03 +00:00
Mary Marchini 9d9d2f0cf7 meta: add links to OpenJSF Slack 
The OpenJS Foundation has an official Slack, and the Node.js project has
many channels there for working groups as well as for general
discussions. Add links to the workspace and channels for folks who want
to join.

PR-URL: https://github.com/nodejs/node/pull/35128
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-09-13 06:33:32 -07:00
Rich Trott 6f2af08245 Revert "build: require "allow edits" to be checked" 
This reverts commit 07423b5472.

Refs: https://github.com/nodejs/node/pull/35002#issuecomment-688363345

PR-URL: https://github.com/nodejs/node/pull/35094
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2020-09-07 22:23:24 -07:00
Jordan Harband 07423b5472 build: require "allow edits" to be checked 
PR-URL: https://github.com/nodejs/node/pull/35002
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-09-03 20:39:18 -07:00
Phillip Johnsen b23a932bfd build: comment about auto close when stalled via with github action 
As part of automatically closing issues and PRs 30 days after they got
labelled with `stalled`, these changes adds a GitHub Action workflow
posting a comment information about what will happen in 30 days upon
being labelled.

PR-URL: https://github.com/nodejs/node/pull/34555
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
 2020-09-02 17:46:54 -07:00
Phillip Johnsen d89cc98e47 build: close stalled issues and PRs with github action 
This introduces a GitHub Action workflow to close issues and PRs
which has been labelled `stalled` 30 days ago (or more).

`stale` labelling and unlabelling of issues and PRs are still done
manually by collaborators.

Refs https://github.com/nodejs/github-bot/issues/261

PR-URL: https://github.com/nodejs/node/pull/34555
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
 2020-09-02 17:46:52 -07:00
Denys Otrishko 6199678d67 build: use latest node-core-utils from npm 
PR-URL: https://github.com/nodejs/node/pull/34969
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
 2020-08-31 14:22:01 -07:00
Antoine du Hamel 622ea7514e meta: update module pages in CODEOWNERS 
PR-URL: https://github.com/nodejs/node/pull/34932
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-08-31 09:55:06 -04:00
gengjiawen c6b96895cc meta: enable wasi for CODEOWNERS 
PR-URL: https://github.com/nodejs/node/pull/34889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
 2020-08-26 00:53:55 +00:00
Richard Lau 1b87035a76 build: run link checker in linter workflow 
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: https://github.com/nodejs/node/pull/34810
Refs: https://github.com/nodejs/node/issues/34787
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-08-19 10:42:22 -07:00
Mary Marchini 5835367df4 meta: fix codeowners docs path 
s/docs/doc/g
Signed-off-by: Mary Marchini <mmarchini@netflix.com>

PR-URL: https://github.com/nodejs/node/pull/34811
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2020-08-17 11:42:11 -07:00
Mary Marchini 8b818cf925 build: add CODEOWNERS linter action 
PR-URL: https://github.com/nodejs/node/pull/34739
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2020-08-17 10:29:01 -07:00
Mary Marchini 5f78dea1a4 meta: add TSC as owner of governance-related docs 
PR-URL: https://github.com/nodejs/node/pull/34737
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-08-14 23:20:55 +00:00
Mary Marchini a84716a21b build: implement a Commit Queue in Actions 
This is a (still experimental) implementation of a Commit Queue on
GitHub Actions, using labels and the scheduler event to land Pull
Requests. It uses `node-core-utils` to validate Pull Requests and to
prepare the commit message, and then it uses a GitHub personal token to
push changes back to the repository. If the Queue fails to land a Pull
Request, that PR will be removed from the queue and the
`node-core-utils` output will be pasted in the Pull Request.

An overview of the implementation is provided in
doc/guides/commit-queue.md, as well as current limitations.

Ref: https://github.com/mmarchini-oss/automated-merge-test
Ref: https://github.com/nodejs/build/issues/2201

PR-URL: https://github.com/nodejs/node/pull/34112
Refs: https://github.com/mmarchini-oss/automated-merge-test
Refs: https://github.com/nodejs/build/issues/2201
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2020-08-13 18:47:27 -07:00
Mary Marchini 84ef92f7cb meta: uncomment all codeowners 
A recent feature was added to github-bot to ping codeowners defined on
the CODEOWNERS file even if the team doesn't have write permission to
the repository. That means we can enable codeowners everywhere in the
repository.

Ref: https://github.com/nodejs/github-bot/pull/265
Fix: https://github.com/nodejs/node/issues/33984

PR-URL: https://github.com/nodejs/node/pull/34670
Fixes: https://github.com/nodejs/node/issues/33984
Refs: https://github.com/nodejs/github-bot/pull/265
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2020-08-09 14:04:43 -07:00
Evan Lucas ac5773b1c3 build: do not run auto-start-ci on forks 
Previously, the auto-start-ci action would run on forks.
Without the secrets, the action would fail over and over again.
This caused a lot of email spam. Now, we only run this action
when the repository is nodejs/node.

PR-URL: https://github.com/nodejs/node/pull/34650
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2020-08-07 11:40:33 -07:00
Mary Marchini 46bef7b771 test: add Actions annotation output 
It's possible to annotate failures in Actions by printing
"::error file={},line={},col={}::{message}". This methos is preferrable
over using a problem matcher because problem matchers only allow
single-line messages, whereas ::error allows multi-line messages.

PR-URL: https://github.com/nodejs/node/pull/34590
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2020-08-06 20:07:49 -07:00
Rich Trott a11aa9b980 meta: enable http2 team for CODEOWNERS 
PR-URL: https://github.com/nodejs/node/pull/34534
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-08-06 19:42:52 -07:00
Shelley Vohr e43bb2f101 build: run CI on release branches 
PR-URL: https://github.com/nodejs/node/pull/34649
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
 2020-08-06 10:43:46 -07:00
gengjiawen df17fcdc71 build: enable build for node-v8 push 
PR-URL: https://github.com/nodejs/node/pull/34634
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
 2020-08-06 01:56:58 +00:00
Mary Marchini e0d181cf2b build: increase startCI verbosity and fix job name 
Ref: https://github.com/nodejs/node/issues/34594#issuecomment-669245839

PR-URL: https://github.com/nodejs/node/pull/34635
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2020-08-05 10:18:36 -07:00
Mary Marchini 9b6c16c5ac build: don't run auto-start-ci on push 
PR-URL: https://github.com/nodejs/node/pull/34588
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2020-08-01 10:19:19 -07:00
Mary Marchini 4268c6112f build: fix auto-start-ci script path 
PR-URL: https://github.com/nodejs/node/pull/34588
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2020-08-01 10:19:16 -07:00
Mary Marchini 6cab3b0e26 build: auto start Jenkins CI via PR labels 
Add an Action that will find every PR with the `request-ci` label and
will start a Jenkins CI for each of these Pull Requests. The scheduler
event is used to circumvent GitHub Actions limitations on Pull Requests
from forks (where secrets are not accessible and the GITHUB_TOKEN is
read-only).

If the Action fails to start a CI, it will add a `request-ci-failed`
label and will leave a comment with the error message from NCU.

Fixes: https://github.com/nodejs/github-bot/issues/234

PR-URL: https://github.com/nodejs/node/pull/34089
Reviewed-By: Christian Clauss <cclauss@me.com>
 2020-07-31 16:09:41 -07:00
gengjiawen ccbd1d5efa build: add quic to github action 
PR-URL: https://github.com/nodejs/node/pull/34336
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-07-28 00:38:14 +00:00
Richard Lau 3e6b05e1aa build: speed up source tarball creation 
Avoid building the node binary when building the source tarball. We
need a node binary to build the docs, but it doesn't have to be one
we build from scratch and can reuse any available node binary.

Skip building the xz compressed tarball in the build-tarball workflow
as we only use the gzip compressed tarball in the subsequent build
jobs.

PR-URL: https://github.com/nodejs/node/pull/34508
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
 2020-07-27 05:56:08 -04:00
Richard Lau b2c08f279a build: don't run test-asan workflow on non-master pushes 
PR-URL: https://github.com/nodejs/node/pull/34509
Refs: https://github.com/nodejs/node/pull/34464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2020-07-27 02:37:28 +00:00
Myles Borins 090ad7d4a1 build: remove test-tarball action for windows + osx 
This GitHub action takes quite a bit of time to build and is regularly
flaky. Removing the OSX and Windows target from this action to avoid
having red actions CI runs.

Refs: https://github.com/nodejs/node/issues/34123

PR-URL: https://github.com/nodejs/node/pull/34440
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-07-23 11:42:12 -04:00
Shelley Vohr 3f455cbddb build: don't run Actions on non-master pushes 
PR-URL: https://github.com/nodejs/node/pull/34464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-07-21 21:00:51 +02:00
Derek Lewis 2a29650eb3 meta: make issue template mobile friendly and address nits 
PR-URL: https://github.com/nodejs/node/pull/34243
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
 2020-07-14 15:12:26 +02:00
Michaël Zasso 913d36d97d build: recommend Python 3.8 to build on Windows 
PR-URL: https://github.com/nodejs/node/pull/34182
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2020-07-13 11:52:04 +02:00
Michael Dawson bff7de3b43 meta: add N-API to codeowners coverage 
We have this guidance for contributing to N-API:
https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md

It makes sense to have one of the N-API team sign off on commits
that changes N-API

Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: https://github.com/nodejs/node/pull/34039
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-07-03 18:14:58 -04:00
James M Snell e20beaf004 meta: fixup CODEOWNERS so it hopefully works 
the CODEOWNERS rules for QUIC are not working and it's not entirely clear why.
Hoping it's just the way the paths were specified.

PR-URL: https://github.com/nodejs/node/pull/34147
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2020-06-30 17:43:54 -07:00
James M Snell fdf10adef8 meta: introduce codeowners again 
The [Contributor's Survey
results](https://github.com/nodejs/TSC/pull/882) highlight the fact that
it is often not easy for contributors to know who the right people are
to talk to about a proposed change or who to ask for reviews of a given
subsystem. We briefly toyed around with codeowners before when GitHub
introduced it but just as quickly disabled it because the structure of
our repository made it exceedingly difficult to get right.

Rather than start with a codeowners for the entire project, I propose
that we start with a small experiment focused on specific subsystems.
Specifically, codeowners for modules, streams, net/tls, http/http2, and
quic (once that lands). We can expand out from there as we see how
things go with the minimal starter set. Initially this just enables
codeowners for the `quic` subsystem.

A couple of points:

1. A codeowner should always be a team, never an individual person
2. Each codeowner team should contain at least one TSC member (to
provide coverage for signing off on semver-major changes)
3. PRs touching any code with a codeowner must be signed off by at least
one person on the codeowner team

PR-URL: https://github.com/nodejs/node/pull/33895
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-06-19 17:51:37 -07:00
Michaël Zasso e0586d0f70 build: output dots in "Build from tarball" action 
Signed-off-by: Michaël Zasso <targos@protonmail.com>

PR-URL: https://github.com/nodejs/node/pull/33696
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-06-06 10:58:14 +02:00
cjihrig b1704e4347 meta: fix a typo in the flaky test template 
"occasionally" was spelled incorrectly.

PR-URL: https://github.com/nodejs/node/pull/33677
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2020-06-01 21:05:29 -04:00
cjihrig 70e2cd7860 meta: wrap flaky test template at 80 characters 
The other issue templates are wrapped at 80 characters. This
commit updates the flaky test template to be consistent.

PR-URL: https://github.com/nodejs/node/pull/33677
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2020-06-01 21:05:29 -04:00
sapics a437a84f80 doc: fix urls to avoid redirection 
Replace redirected urls with the final ones.
Replace http urls with https ones.

PR-URL: https://github.com/nodejs/node/pull/33614
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2020-05-30 10:01:57 -07:00
Richard Lau 69612b70da build: fix python-version selection with actions 
s/PYTHON\_VERSION/python-version

Refs: https://github.com/actions/setup-python
Refs: https://github.com/nodejs/node/pull/32609

PR-URL: https://github.com/nodejs/node/pull/33589
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2020-05-29 12:50:59 -04:00
Ash Cripps fb33b673f1 meta: add flaky test issue template 
Add a flaky test issue template to ensure that enough information is
provided for investigation

PR-URL: https://github.com/nodejs/node/pull/33500
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
 2020-05-28 10:49:12 -07:00
Anna Henningsen 7c755b06ce build: run full test suite in ASAN action 
Refs: https://github.com/nodejs/node/pull/32776

PR-URL: https://github.com/nodejs/node/pull/33170
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
 2020-05-19 23:33:41 +02:00
Richard Lau fcc183c994 build: enable --error-on-warn for POSIX workflows 
Treat warnings as errors for non-deps code on Linux and macOS workflows.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: https://github.com/nodejs/node/pull/33357
Refs: https://github.com/nodejs/node/pull/32685
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2020-05-13 12:07:33 -04:00
Derek Lewis 3226731dec meta: add issue template for API reference docs 
Prior to this commit, there was no GitHub issue template guiding
users to open issues about gaps in the API reference docs.

Refs: https://github.com/nodejs/node/pull/31123
PR-URL: https://github.com/nodejs/node/pull/32944
Fixes: https://github.com/nodejs/nodejs.org/issues/2866
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-05-09 07:53:31 +02:00
Matheus Marchini 81c03bcebd build: re-enable ASAN Action using clang 
clang's linker seems to use considerably less memory than gcc, allowing
us to run on Actions without running out of memory.

Signed-off-by: Matheus Marchini <mmarchini@netflix.com>

PR-URL: https://github.com/nodejs/node/pull/32776
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2020-04-13 15:41:32 -07:00