4 Commits

Include renames

Author	SHA1	Message	Date
Chris Opperwall	f52da9484d	debugger: validate sec-websocket-accept response header ... This addresses a TODO to validate that the sec-websocket-accept header in the WebSocket handshake response is valid. To do this we need to append the WebSocket GUID to the original key sent in sec-websocket-key, sha1 hash it, and then compare the base64 encoding with the value sent in the sec-websocket-accept response header. If they don't match, an error is thrown. PR-URL: https://github.com/nodejs/node/pull/39357 Refs: https://github.com/nodejs/node-inspect/pull/93 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	2021-07-18 14:53:23 -07:00
Rich Trott	c12db606ee	debugger: rename internal module ... All other files in `lib/internal` do not start with `_`. For consistency, move `lib/internal/debugger/_inspect.js` to `lib/internal/debugger/inspect.js`. PR-URL: https://github.com/nodejs/node/pull/39378 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>	2021-07-15 17:19:07 -07:00
Rich Trott	3c099874aa	debugger: remove final lint exceptions in inspect_repl.js ... Adding a return when it's not really a getter is kind of misleading, but so is using a getter for something that doesn't return anything, so ¯\_(ツ)_/¯. PR-URL: https://github.com/nodejs/node/pull/39078 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>	2021-06-25 22:05:18 -07:00
Rich Trott	4330fb757f	debugger: rename internal library for clarity ... When I moved these files from node-inspect to Node.js core, I put them in lib/internal/inspector. That was a mistake. They should be in lib/internal/debugger. PR-URL: https://github.com/nodejs/node/pull/39080 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	2021-06-20 22:33:32 -07:00